)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b830ad513a8d95b8726c3544bdb77b43774521aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thiago Paiva \u003cthiagop@lsd.ufcg.edu.br\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-23 16:33:38 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fine tunning features to run ironic on tempest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest historically avoid running some tests for features unsupported by ironic"},{"line_number":10,"context_line":"when it is enabled on the environment, but instead we should be controlling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_e9247fb3","line":7,"updated":"2016-08-24 16:17:42.000000000","message":"nit: s/tunning/tuning/","commit_id":"0e71a9262406312c8a9edcc7e4c342d0f9f4e9f6"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"b7662c56580718e214e173aac2fc0b11ff0dcc40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thiago Paiva \u003cthiagop@lsd.ufcg.edu.br\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-23 16:33:38 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fine tunning features to run ironic on tempest"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tempest historically avoid running some tests for features unsupported by ironic"},{"line_number":10,"context_line":"when it is enabled on the environment, but instead we should be controlling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_844a12ab","line":7,"in_reply_to":"1ac06dbe_e9247fb3","updated":"2016-08-24 16:50:28.000000000","message":"Done","commit_id":"0e71a9262406312c8a9edcc7e4c342d0f9f4e9f6"}],"lib/tempest":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9e274ffbafb4de8dfe3718f021d67f5013572ea9","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":512,"context_line":"        iniset $TEMPEST_CONFIG auth create_isolated_networks False"},{"line_number":513,"context_line":"        if [[ \"$IPV6_ENABLED\" !\u003d \"True\" ]]; then"},{"line_number":514,"context_line":"            echo \"Baremetal doesn\u0027t supports ipv6 networks. Disabling\""},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6 False"},{"line_number":517,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes False"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_b3fba8c0","line":514,"updated":"2016-08-22 17:52:17.000000000","message":"This message could be more clear that this is implicit behavior. I would suggest the following wording:\n\n  echo \"Automatically disabling tempest ipv6 support because baremetal does not support IPv6 networks.\"","commit_id":"6e6abc78f089938a7ddbcc0ffc2be1b7a872a75c"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"f4c7537e0893c960d04a7ae8e3f14af9b22df86c","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":512,"context_line":"        iniset $TEMPEST_CONFIG auth create_isolated_networks False"},{"line_number":513,"context_line":"        if [[ \"$IPV6_ENABLED\" !\u003d \"True\" ]]; then"},{"line_number":514,"context_line":"            echo \"Baremetal doesn\u0027t supports ipv6 networks. Disabling\""},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6 False"},{"line_number":517,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes False"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_96e65a13","line":514,"in_reply_to":"1ac06dbe_b3fba8c0","updated":"2016-08-22 18:16:15.000000000","message":"Done","commit_id":"6e6abc78f089938a7ddbcc0ffc2be1b7a872a75c"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9e274ffbafb4de8dfe3718f021d67f5013572ea9","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6 False"},{"line_number":517,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes False"},{"line_number":518,"context_line":"        fi"},{"line_number":519,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_admin_state_change False"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_d3ec64f5","line":518,"updated":"2016-08-22 17:52:17.000000000","message":"where is the \"else\" block for this?\n\nif the devstack config specifies that ipv6 should be enabled AND ironic should be enabled, shouldn\u0027t we raise an error and abort? \n\nI dont know what (if anything) that will break, though this patch seems to imply that it already isn\u0027t supported...","commit_id":"6e6abc78f089938a7ddbcc0ffc2be1b7a872a75c"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"f4c7537e0893c960d04a7ae8e3f14af9b22df86c","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6 False"},{"line_number":517,"context_line":"            iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes False"},{"line_number":518,"context_line":"        fi"},{"line_number":519,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_admin_state_change False"},{"line_number":520,"context_line":"    fi"},{"line_number":521,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_b656f659","line":518,"in_reply_to":"1ac06dbe_d3ec64f5","updated":"2016-08-22 18:16:15.000000000","message":"IPv6 is enabled in devstack by default. If we error it, we would have to oblige devstack users to disable it when deploying with ironic.\n\nI\u0027ve been told that PXE doesn\u0027t work with ipv6, that was the motive why the neutron ipv6 tests were disabled when running tempest with baremetal.","commit_id":"6e6abc78f089938a7ddbcc0ffc2be1b7a872a75c"}]}
