)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"39b29773705067bc4a475a5c7c04b4a9a7300359","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    local project_id\u003d$1"},{"line_number":235,"context_line":"    local subnet_params\u003d\"--tenant-id $project_id \""},{"line_number":236,"context_line":"    subnet_params+\u003d\"--ip_version 4 \""},{"line_number":237,"context_line":"    if [[ \"$NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":238,"context_line":"        subnet_params+\u003d\"--gateway $NETWORK_GATEWAY \""},{"line_number":239,"context_line":"    fi"},{"line_number":240,"context_line":"    subnet_params+\u003d\"--name $PRIVATE_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_4189b174","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":43},"updated":"2016-08-22 23:12:09.000000000","message":"As a bash script, I prefer to using \"-n\" :\n\n  if [ -n \"$NETWORK_GATEWAY\" ]; then\n\nAs far as I checked, \u0027-n\u0027 is commonly used in devstack.","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33be5829f194cb59f6367bd93e176154f624ccf5","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    local project_id\u003d$1"},{"line_number":235,"context_line":"    local subnet_params\u003d\"--tenant-id $project_id \""},{"line_number":236,"context_line":"    subnet_params+\u003d\"--ip_version 4 \""},{"line_number":237,"context_line":"    if [[ \"$NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":238,"context_line":"        subnet_params+\u003d\"--gateway $NETWORK_GATEWAY \""},{"line_number":239,"context_line":"    fi"},{"line_number":240,"context_line":"    subnet_params+\u003d\"--name $PRIVATE_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_6bbda7b6","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":43},"in_reply_to":"1ac06dbe_4189b174","updated":"2016-08-23 01:03:29.000000000","message":"Done","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"39b29773705067bc4a475a5c7c04b4a9a7300359","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    local ipv6_modes\u003d\"--ipv6-ra-mode $IPV6_RA_MODE --ipv6-address-mode $IPV6_ADDRESS_MODE\""},{"line_number":254,"context_line":"    local subnet_params\u003d\"--tenant-id $project_id \""},{"line_number":255,"context_line":"    subnet_params+\u003d\"--ip_version 6 \""},{"line_number":256,"context_line":"    if [[ \"$IPV6_PRIVATE_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":257,"context_line":"        subnet_params+\u003d\"--gateway $IPV6_PRIVATE_NETWORK_GATEWAY \""},{"line_number":258,"context_line":"    fi"},{"line_number":259,"context_line":"    subnet_params+\u003d\"--name $IPV6_PRIVATE_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_817f2965","line":256,"updated":"2016-08-22 23:12:09.000000000","message":"ditto","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33be5829f194cb59f6367bd93e176154f624ccf5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    local ipv6_modes\u003d\"--ipv6-ra-mode $IPV6_RA_MODE --ipv6-address-mode $IPV6_ADDRESS_MODE\""},{"line_number":254,"context_line":"    local subnet_params\u003d\"--tenant-id $project_id \""},{"line_number":255,"context_line":"    subnet_params+\u003d\"--ip_version 6 \""},{"line_number":256,"context_line":"    if [[ \"$IPV6_PRIVATE_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":257,"context_line":"        subnet_params+\u003d\"--gateway $IPV6_PRIVATE_NETWORK_GATEWAY \""},{"line_number":258,"context_line":"    fi"},{"line_number":259,"context_line":"    subnet_params+\u003d\"--name $IPV6_PRIVATE_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_abb31fe8","line":256,"in_reply_to":"1ac06dbe_817f2965","updated":"2016-08-23 01:03:29.000000000","message":"Done","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"39b29773705067bc4a475a5c7c04b4a9a7300359","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Create public IPv4 subnet"},{"line_number":268,"context_line":"function _neutron_create_public_subnet_v4 {"},{"line_number":269,"context_line":"    local subnet_params+\u003d\"--ip_version 4 \""},{"line_number":270,"context_line":"    subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":271,"context_line":"    if [[ \"$PUBLIC_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":272,"context_line":"        subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_c1dc8175","line":269,"range":{"start_line":269,"start_character":23,"end_line":269,"end_character":25},"updated":"2016-08-22 23:12:09.000000000","message":"(not directly related to this patch) \u0027+\u003d\u0027 should be \u0027\u003d\u0027.","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33be5829f194cb59f6367bd93e176154f624ccf5","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Create public IPv4 subnet"},{"line_number":268,"context_line":"function _neutron_create_public_subnet_v4 {"},{"line_number":269,"context_line":"    local subnet_params+\u003d\"--ip_version 4 \""},{"line_number":270,"context_line":"    subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":271,"context_line":"    if [[ \"$PUBLIC_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":272,"context_line":"        subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_ab9cbf5d","line":269,"range":{"start_line":269,"start_character":23,"end_line":269,"end_character":25},"in_reply_to":"1ac06dbe_c1dc8175","updated":"2016-08-23 01:03:29.000000000","message":"Done","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"39b29773705067bc4a475a5c7c04b4a9a7300359","unresolved":false,"context_lines":[{"line_number":268,"context_line":"function _neutron_create_public_subnet_v4 {"},{"line_number":269,"context_line":"    local subnet_params+\u003d\"--ip_version 4 \""},{"line_number":270,"context_line":"    subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":271,"context_line":"    if [[ \"$PUBLIC_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":272,"context_line":"        subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""},{"line_number":273,"context_line":"    fi"},{"line_number":274,"context_line":"    subnet_params+\u003d\"--name $PUBLIC_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_e1989dc2","line":271,"updated":"2016-08-22 23:12:09.000000000","message":"ditto","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"33be5829f194cb59f6367bd93e176154f624ccf5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"function _neutron_create_public_subnet_v4 {"},{"line_number":269,"context_line":"    local subnet_params+\u003d\"--ip_version 4 \""},{"line_number":270,"context_line":"    subnet_params+\u003d\"${Q_FLOATING_ALLOCATION_POOL:+--allocation-pool $Q_FLOATING_ALLOCATION_POOL} \""},{"line_number":271,"context_line":"    if [[ \"$PUBLIC_NETWORK_GATEWAY\" !\u003d \"\" ]]; then"},{"line_number":272,"context_line":"        subnet_params+\u003d\"--gateway $PUBLIC_NETWORK_GATEWAY \""},{"line_number":273,"context_line":"    fi"},{"line_number":274,"context_line":"    subnet_params+\u003d\"--name $PUBLIC_SUBNET_NAME \""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_0bcd1366","line":271,"in_reply_to":"1ac06dbe_e1989dc2","updated":"2016-08-23 01:03:29.000000000","message":"Done","commit_id":"dd422415adad341982b6cdc63eb62a7e09890fe1"}]}