)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"438d2ab03d353394251a60090203996010419398","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow to set Q_TUNNEL_TYPES manually"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Q_ML2_TENANT_NETWORK_TYPE can be set to allow all kind of network type."},{"line_number":10,"context_line":"for example \"vlan,vxlan\",\"vlan,gre,vxlan\". In that case current code "},{"line_number":11,"context_line":"will always defined tunnel types to be \"gre\". adding an option to set"},{"line_number":12,"context_line":"the required tunnel type manually in local.conf."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_1097f048","line":10,"updated":"2016-08-28 09:00:43.000000000","message":"please remove the whitespace","commit_id":"65dc2d9d2c7bab2a672d1f2e6784f80a38f47cdf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f4c368f7948766724f7411613d052658e3cd3795","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow to set Q_TUNNEL_TYPES manually"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Q_ML2_TENANT_NETWORK_TYPE can be set to allow all kind of network type."},{"line_number":10,"context_line":"for example \"vlan,vxlan\",\"vlan,gre,vxlan\". In that case current code "},{"line_number":11,"context_line":"will always defined tunnel types to be \"gre\". adding an option to set"},{"line_number":12,"context_line":"the required tunnel type manually in local.conf."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_1d22a800","line":10,"in_reply_to":"fa7ab95a_1097f048","updated":"2016-08-28 12:53:41.000000000","message":"Done","commit_id":"65dc2d9d2c7bab2a672d1f2e6784f80a38f47cdf"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"80f0633696759a97f7e1b92e04eb1668c6e0de58","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to set Q_TUNNEL_TYPES directly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Q_ML2_TENANT_NETWORK_TYPE\" define which network type tenant allowed to"},{"line_number":10,"context_line":"create."},{"line_number":11,"context_line":"\"Q_TUNNEL_TYPES\" define which tunnel types to enable in your OpenStack"},{"line_number":12,"context_line":"environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba5201f7_9f226a00","line":9,"updated":"2017-01-09 18:40:10.000000000","message":"defines which network types a tenant is allowed to create","commit_id":"6499dbe9865ba489593ea4522141545ff622504c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"80f0633696759a97f7e1b92e04eb1668c6e0de58","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Q_ML2_TENANT_NETWORK_TYPE\" define which network type tenant allowed to"},{"line_number":10,"context_line":"create."},{"line_number":11,"context_line":"\"Q_TUNNEL_TYPES\" define which tunnel types to enable in your OpenStack"},{"line_number":12,"context_line":"environment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch clarify the use of the above parameters and allow to set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba5201f7_df731214","line":11,"updated":"2017-01-09 18:40:10.000000000","message":"deinfes which tunnel types are enabled in","commit_id":"6499dbe9865ba489593ea4522141545ff622504c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"80f0633696759a97f7e1b92e04eb1668c6e0de58","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\"Q_TUNNEL_TYPES\" define which tunnel types to enable in your OpenStack"},{"line_number":12,"context_line":"environment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch clarify the use of the above parameters and allow to set"},{"line_number":15,"context_line":"\"Q_TUNNEL_TYPES\" directly in advance OpenStack networking cases."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Example:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ba5201f7_5f5e4277","line":14,"updated":"2017-01-09 18:40:10.000000000","message":"This patch clarifies the use of the above parameters and allows users to","commit_id":"6499dbe9865ba489593ea4522141545ff622504c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"5cd96f67591261defe025744995f65b5cdb143c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to set Q_TUNNEL_TYPES directly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Q_ML2_TENANT_NETWORK_TYPE\" defines which network types tenant allowed to"},{"line_number":10,"context_line":"create."},{"line_number":11,"context_line":"\"Q_TUNNEL_TYPES\" defines which tunnel types are enabled in your OpenStack"},{"line_number":12,"context_line":"environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba5201f7_c2c30e56","line":9,"updated":"2017-01-10 14:43:34.000000000","message":"types a tenant is allowed to","commit_id":"5487520a0ed4daf9ebb9ab7afb2a82dc325661c7"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"addafed8fdf1c46868192216d319404aa0208623","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1ac06dbe_4ebd82d6","line":11,"updated":"2016-08-25 17:42:06.000000000","message":"This comment will need to be updated","commit_id":"b1cce544bba38d2d2086b011db8bb4885e2fd83a"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"13dbfbb05205a363d10c1b33c2321d029d43c70d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1ac06dbe_8c2662b8","line":11,"in_reply_to":"1ac06dbe_4ebd82d6","updated":"2016-08-25 18:28:56.000000000","message":"Done","commit_id":"b1cce544bba38d2d2086b011db8bb4885e2fd83a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"5f0625814d94f0ad9ed545de39331ff2a1d01939","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027 for when you have"},{"line_number":12,"context_line":"# mixed environment with vlan and vxlan/gre Q_ML2_TENANT_NETWORK_TYPE\u003dvlan,vxlan."},{"line_number":13,"context_line":"# When Q_TUNNEL_TYPES is not defined as follow."},{"line_number":14,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_0c8a72bf","line":11,"updated":"2016-08-25 18:42:05.000000000","message":"OK- so my suggestion is\n\n\"Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, \u0027gre,vxlan\u0027, or \u0027vxlan,vlan\u0027\n\nPretty much everything else you added is confusing.","commit_id":"8ebf3a7b0352b587b0e8d37065418ffeb6d3c745"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"3ab5d4e9b6d5a1835ab9d3b883b2d5eb1c2a394a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027 for when you have"},{"line_number":12,"context_line":"# mixed environment with vlan and vxlan/gre Q_ML2_TENANT_NETWORK_TYPE\u003dvlan,vxlan."},{"line_number":13,"context_line":"# When Q_TUNNEL_TYPES is not defined as follow."},{"line_number":14,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1ac06dbe_5d50920a","line":11,"in_reply_to":"1ac06dbe_0c8a72bf","updated":"2016-08-25 19:23:28.000000000","message":"Done","commit_id":"8ebf3a7b0352b587b0e8d37065418ffeb6d3c745"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"2b6aa99ea12bedeef898132b4a9b05416fee068e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027."},{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa7ab95a_482213bb","line":11,"updated":"2016-08-25 20:42:07.000000000","message":"where is the \u0027vxlan,vlan\u0027 option?","commit_id":"f5501709d25399b005712235104be4f65b85cd91"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"43cce3e43a770f2240607aaae02801e32dd34df8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027."},{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa7ab95a_28e1c49a","line":11,"in_reply_to":"fa7ab95a_454b78c9","updated":"2016-08-29 13:34:42.000000000","message":"OK, then you need to put a comment that indicates this clearly, that you can set Q_ML2_TENANT_NETWORK_TYPE to \"vlan,vxlan\"","commit_id":"f5501709d25399b005712235104be4f65b85cd91"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"d80f69c377e6c254d741e6abbe1d6275475949c5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027."},{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa7ab95a_454b78c9","line":11,"in_reply_to":"fa7ab95a_482213bb","updated":"2016-08-28 07:32:36.000000000","message":"vlan is not a tunnel type. \ni set this fix because $Q_ML2_TENANT_NETWORK_TYPE can be possibly configure to \"vlan,vxlan\" and this okay.\nbut when we do so user shell pre-defined what the tunnel types he wants to configure.","commit_id":"f5501709d25399b005712235104be4f65b85cd91"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"2f412c088712ee8ab5259cd8a2a89155a7205313","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"},{"line_number":15,"context_line":"    if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" "},{"line_number":16,"context_line":"    || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre,vxlan\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan,gre\" ]]; then"},{"line_number":17,"context_line":"        Q_TUNNEL_TYPES\u003d$Q_ML2_TENANT_NETWORK_TYPE"},{"line_number":18,"context_line":"    elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_48b8c8c8","line":15,"updated":"2016-08-29 13:34:48.000000000","message":"whitespace","commit_id":"2cb177225cfab02eff7ebeb003ed869d5bb0063e"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"dc8933e9e873056bd1e58b16552dd499a7cafe51","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":13,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":14,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"},{"line_number":15,"context_line":"    if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" "},{"line_number":16,"context_line":"    || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre,vxlan\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan,gre\" ]]; then"},{"line_number":17,"context_line":"        Q_TUNNEL_TYPES\u003d$Q_ML2_TENANT_NETWORK_TYPE"},{"line_number":18,"context_line":"    elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1a95cdbc_e1b91930","line":15,"in_reply_to":"fa7ab95a_48b8c8c8","updated":"2016-10-05 09:58:44.000000000","message":"Done","commit_id":"2cb177225cfab02eff7ebeb003ed869d5bb0063e"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"741da1e299cb1d6cf79a0bb96ef34ed18c67bcbc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":11,"context_line":"# Setting Q_TUNNEL_TYPES in local.conf to either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027."},{"line_number":12,"context_line":"# Q_ML2_TENANT_NETWORK_TYPE can be set to \"vlan,vxlan\" you need to defined desired tunnel types with"},{"line_number":13,"context_line":"# Q_TUNNEL_TYPES."},{"line_number":14,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"vxlan\"}"},{"line_number":15,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":16,"context_line":"if [ -z \"$Q_TUNNEL_TYPES\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5da102_85da9ae6","line":13,"updated":"2016-11-02 15:41:16.000000000","message":"This needs some grammar fixes.\n\n\"If you wish to define Q_ML2_TENANT_NETWORK_TYPE to \"vlan,vxlan\" you will also need to define the desired tunnel types with the Q_TUNNEL_TYPES variable\"\n\n?","commit_id":"a5ad1a31ebc19a58a4c84929531c0a189d988602"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"5bed5e6c6807253c24050f78debf0db92a9bd3e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Ensure \"Q_TUNNEL_TYPES\" is set when \"Q_ML2_TENANT_NETWORK_TYPE\" is set to \"gre\" or \"vxlan\""},{"line_number":21,"context_line":"# or \"ENABLE_TENANT_TUNNELS\" is set to \"True\" default to \"gre\"."},{"line_number":22,"context_line":"if [ \"$Q_TUNNEL_TYPES\" \u003d\u003d \"\" ]; then"},{"line_number":23,"context_line":"    if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" ]]; then"},{"line_number":24,"context_line":"        Q_TUNNEL_TYPES\u003d$Q_ML2_TENANT_NETWORK_TYPE"},{"line_number":25,"context_line":"    elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"7a77a97e_e80770c7","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":28},"updated":"2016-11-19 10:14:04.000000000","message":"you can use [ -z $Q_TUNNEL_TYPES ] to check it the variable is empty","commit_id":"d5f1e1b0a805cba2eb5ee27e1cc61bf4ee6f57ad"}]}