)]}'
{"id":"openstack%2Fdevstack~36096","triplet_id":"openstack%2Fdevstack~master~I96fe749013b5cf1fd3411b2ba661302873e92994","project":"openstack/devstack","branch":"master","topic":"init_cinder","hashtags":[],"change_id":"I96fe749013b5cf1fd3411b2ba661302873e92994","subject":"clean logical volumes in init_cinder","status":"MERGED","created":"2013-07-08 15:14:35.000000000","updated":"2013-07-15 14:11:19.000000000","submitted":"2013-07-15 14:11:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"65ec8cef97c9ac6e075bb77088284b42b6f6d62f","_number":36096,"virtual_id_number":36096,"owner":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-07-15 14:11:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-12 12:42:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":2,"date":"2013-07-12 15:15:06.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":1,"date":"2013-07-15 13:13:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-08 19:05:23.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-07-15 13:13:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-07-15 14:11:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3bdfa332fb2cfaa0addbeff2e337a05d90988332","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-08 15:57:33.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/36096/1/check/gate-tempest-devstack-vm-full/29303 : SUCCESS in 42m 32s\n- http://logs.openstack.org/36096/1/check/gate-tempest-devstack-vm-postgres-full/29009 : SUCCESS in 42m 51s\n- http://logs.openstack.org/36096/1/check/gate-tempest-devstack-vm-neutron/387 : SUCCESS in 17m 02s\n- http://logs.openstack.org/36096/1/check/gate-grenade-devstack-vm/15543 : FAILURE in 12m 09s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"67aae49d713bad8735171a33d18b0829e8362f41","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-08 19:05:23.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI think this is ok, though it\u0027s hard for me to see if the cleanup is exactly the same as this call being removed. I know that cinder over quota issues tends to be the most broken part of long running devstack installs.","accounts_in_message":[],"_revision_number":1},{"id":"a33214fac1a215c96f5f19adc0ce59e5d79c4b51","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-08 19:40:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nDevStack performs some \u0027safety\u0027 cleans on startup to eliminate problems from subsequent runs of stack.sh without an intervening unstack.sh, clean.sh or reboot.  We do this with system-level services: kvm instances, iscsi volumes, databases.  cleanup_cinder() is not called here as it does more than we need.  That is part of the reason _cleanup_lvm() (formerly _clean_volume_group()) was factored out.  Renaming the two _clean_volume_group() calls is the only work I see here.","accounts_in_message":[],"_revision_number":1},{"id":"ad7f7a36127963986fb43b482e38b91cf8dede63","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2013-07-09 12:39:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"351b10942b4f6b308a1b1235b1634701cd8ac009","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2013-07-09 12:43:02.000000000","message":"Patch Set 2:\n\nI had to split the function cleanup_lvm because it was doing more thing than what the previous function _clean_volume_group was doing.","accounts_in_message":[],"_revision_number":2},{"id":"40c144a8a98c147026878dcecab207d62e5b8bf4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-09 13:24:04.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-full/29783 : SUCCESS in 44m 16s\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-postgres-full/29489 : SUCCESS in 43m 51s\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-neutron/936 : FAILURE in 20m 51s\n- http://logs.openstack.org/36096/2/check/gate-grenade-devstack-vm/15969 : FAILURE in 12m 30s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"9afd8773b727f0fed74ecc42a7eb9ee19ba76d1b","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2013-07-09 16:49:43.000000000","message":"Patch Set 2:\n\nrecheck bug 1194026","accounts_in_message":[],"_revision_number":2},{"id":"cd8f233121dd0f0f4885e819465b7c4b897e3e24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-09 17:39:18.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-full/29875 : SUCCESS in 43m 25s\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-postgres-full/29581 : SUCCESS in 49m 23s\n- http://logs.openstack.org/36096/2/check/gate-tempest-devstack-vm-neutron/1039 : SUCCESS in 20m 14s\n- http://logs.openstack.org/36096/2/check/gate-grenade-devstack-vm/16055 : FAILURE in 25m 44s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"5aa4a1e3fe2c896456a4c6be00b33bdf3451f19d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-10 15:00:21.000000000","message":"Patch Set 2: (1 inline comment)\n\nI\u0027m good with this after one annoying whitespace cleanup.","accounts_in_message":[],"_revision_number":2},{"id":"73e029c0ec90a745286416b176e9f1360dd81dea","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2013-07-10 15:03:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ee2f401a98d380ae60638e26e5de5ccc85ccfb7d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-10 15:57:33.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-full/30370 : SUCCESS in 54m 13s\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-postgres-full/30074 : SUCCESS in 42m 30s\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-neutron/1595 : FAILURE in 21m 05s\n- http://logs.openstack.org/36096/3/check/gate-grenade-devstack-vm/16515 : FAILURE in 21m 00s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"3bc587ac1a98880b260617fe89a9316799eb9eee","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2013-07-12 12:42:45.000000000","message":"Patch Set 3:\n\nrecheck bug 1194026","accounts_in_message":[],"_revision_number":3},{"id":"792ef324d46402e18cbdc404775a8c065c5dd508","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-12 13:39:25.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-full/31612 : SUCCESS in 45m 11s\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-postgres-full/31305 : SUCCESS in 56m 32s\n- http://logs.openstack.org/36096/3/check/gate-tempest-devstack-vm-neutron/2969 : SUCCESS in 22m 04s (non-voting)\n- http://logs.openstack.org/36096/3/check/gate-grenade-devstack-vm/17627 : FAILURE in 22m 43s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"00aa9bc1def11d52c7686c30e66f8b8980f0a6f9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-12 15:15:06.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"e7dc5d74c0fe4a8d56676dcb9dc5986aa885a739","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-15 13:13:41.000000000","message":"Patch Set 3: Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d4fd0386e9149aab711ef08746ba655bdf201711","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-15 13:13:44.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"03f60f3e1cdabe86947c37f4b5e3b755091c5a20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-15 14:11:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"cd63cb00eb6fbeaa2a9836aee18083a0a5bae9b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-15 14:11:19.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/36096/3/gate/gate-tempest-devstack-vm-full/32130 : SUCCESS in 45m 25s\n- http://logs.openstack.org/36096/3/gate/gate-tempest-devstack-vm-postgres-full/31822 : SUCCESS in 57m 31s\n- http://logs.openstack.org/36096/3/gate/gate-tempest-devstack-vm-neutron/3600 : SUCCESS in 22m 42s (non-voting)\n- http://logs.openstack.org/36096/3/gate/gate-grenade-devstack-vm/18071 : FAILURE in 18m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"022e991a54cce612a5b4a6d9a62227307800a25e","revisions":{"f10be8424ec5a9d49e2fc05d646f518b10f1dfcb":{"kind":"REWORK","_number":1,"created":"2013-07-08 15:14:35.000000000","uploader":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"ref":"refs/changes/96/36096/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/96/36096/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/96/36096/1"}}},"commit":{"parents":[{"commit":"2076647e2116ab2c2068e18d118c96f51a5dc926","subject":"Merge \"update for name change to Neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2076647e2116ab2c2068e18d118c96f51a5dc926"}]}],"author":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-08 15:10:25.000000000","tz":120},"committer":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-08 15:14:29.000000000","tz":120},"subject":"init_cinder is no place for cleaning up","message":"init_cinder is no place for cleaning up\n\ncleanup_cinder() should be the only place where clean up is done.\nThis function should be reliable so that any subsequent run of devstack\nshould succeed. Moreover _clean_volume_group() doesn\u0027t exist anymore.\n\nChange-Id: I96fe749013b5cf1fd3411b2ba661302873e92994\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f10be8424ec5a9d49e2fc05d646f518b10f1dfcb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f10be8424ec5a9d49e2fc05d646f518b10f1dfcb"}]},"branch":"refs/heads/master"},"ffbb9267773324248117288c934136548c97e510":{"kind":"REWORK","_number":2,"created":"2013-07-09 12:39:38.000000000","uploader":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"ref":"refs/changes/96/36096/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/96/36096/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/96/36096/2"}}},"commit":{"parents":[{"commit":"e49b081b6c2d7f701b3038fa1aa629909c109a6b","subject":"Merge \"More neutron renames\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e49b081b6c2d7f701b3038fa1aa629909c109a6b"}]}],"author":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-09 12:14:48.000000000","tz":120},"committer":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-09 12:39:28.000000000","tz":120},"subject":"clean logical volumes in init_cinder","message":"clean logical volumes in init_cinder\n\nThis part of code was forgotten when _clean_volume_group()\nhas been renamed.\n\nChange-Id: I96fe749013b5cf1fd3411b2ba661302873e92994\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ffbb9267773324248117288c934136548c97e510"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ffbb9267773324248117288c934136548c97e510"}]},"branch":"refs/heads/master"},"022e991a54cce612a5b4a6d9a62227307800a25e":{"kind":"REWORK","_number":3,"created":"2013-07-10 15:03:10.000000000","uploader":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"ref":"refs/changes/96/36096/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/96/36096/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/96/36096/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/96/36096/3"}}},"commit":{"parents":[{"commit":"cf6d809d8d13b8177826b9c95b0ccab6f0dcb9c4","subject":"Add openSUSE support for openvswitch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cf6d809d8d13b8177826b9c95b0ccab6f0dcb9c4"}]}],"author":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-09 12:14:48.000000000","tz":120},"committer":{"name":"JordanP","email":"jordan.pittier-ext@cloudwatt.com","date":"2013-07-10 15:02:59.000000000","tz":120},"subject":"clean logical volumes in init_cinder","message":"clean logical volumes in init_cinder\n\nThis part of code was forgotten when _clean_volume_group()\nhas been renamed.\n\nChange-Id: I96fe749013b5cf1fd3411b2ba661302873e92994\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/022e991a54cce612a5b4a6d9a62227307800a25e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/022e991a54cce612a5b4a6d9a62227307800a25e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}