)]}'
{"lib/nova":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f3143910b207bfcd842e4f54897064d74ff5adc7","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    if is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-api; then"},{"line_number":685,"context_line":"        # (Re)create nova databases"},{"line_number":686,"context_line":"        recreate_database nova"},{"line_number":687,"context_line":"        recreate_database nova_api_cell0"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        # Migrate nova database. If \"nova-manage cell_v2 simple_cell_setup\" has"},{"line_number":690,"context_line":"        # been run this migrates the \"nova\" and \"nova_api_cell0\" database."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_a284c50a","line":687,"updated":"2016-08-30 13:04:39.000000000","message":"should this not be done if the following is true:\nif is_service_enabled n-cell; then?","commit_id":"d3fadae0b12590662a9d612f91ed027307e74890"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7aed42387dd2cdb4b27a0b64af051d682dab6113","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    if is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-api; then"},{"line_number":685,"context_line":"        # (Re)create nova databases"},{"line_number":686,"context_line":"        recreate_database nova"},{"line_number":687,"context_line":"        recreate_database nova_api_cell0"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        # Migrate nova database. If \"nova-manage cell_v2 simple_cell_setup\" has"},{"line_number":690,"context_line":"        # been run this migrates the \"nova\" and \"nova_api_cell0\" database."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_95e9bdb9","line":687,"in_reply_to":"fa7ab95a_a284c50a","updated":"2016-08-30 13:21:20.000000000","message":"If this were for cellsv1 then it should be guarded by the n-cell check. But this is for v2 which is the default configuration for Nova going forward so no guard is necessary.","commit_id":"d3fadae0b12590662a9d612f91ed027307e74890"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d745f3a6d660ab4a5e1930bd992ef40ae29fda2f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"FORCE_CONFIG_DRIVE\u003d${FORCE_CONFIG_DRIVE:-\"False\"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# Option to initialize CellsV2 environment"},{"line_number":89,"context_line":"NOVA_CONFIGURE_CELLSV2\u003d${NOVA_CONFIGURE_CELLSV2:-\"False\"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Nova supports pluggable schedulers.  The default ``FilterScheduler``"},{"line_number":92,"context_line":"# should work in most cases."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa7ab95a_9af26599","line":89,"updated":"2016-08-31 18:55:25.000000000","message":"better to do:\n\nNOVA_CONFIGURE_CELLSV2\u003d$(trueorfalse False NOVA_CONFIGURE_CELLSV2)\n\nWhich means it can only have values of True or False","commit_id":"bb9f8508ad34a1ccd246f36e9b593ae8f041b8d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3b785cbca152057641d5f30118766fc6df99caf6","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            recreate_database nova_api_cell0"},{"line_number":692,"context_line":"        fi"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Migrate nova database. If \"nova-manage cell_v2 simple_cell_setup\" has"},{"line_number":695,"context_line":"        # been run this migrates the \"nova\" and \"nova_api_cell0\" database."},{"line_number":696,"context_line":"        # Otherwise it just migrates the \"nova\" database."},{"line_number":697,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if is_service_enabled n-cell; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa7ab95a_da878d10","line":696,"range":{"start_line":694,"start_character":33,"end_line":696,"end_character":57},"updated":"2016-08-31 18:51:46.000000000","message":"I sort of seems weird that we mention this in this change, when the change that actually calls simple_cell_setup happens after it here:\n\nhttps://review.openstack.org/#/c/355602/","commit_id":"bb9f8508ad34a1ccd246f36e9b593ae8f041b8d5"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"231e79b674b63ebb2724b39dfd3231ee02a727f7","unresolved":false,"context_lines":[{"line_number":691,"context_line":"            recreate_database nova_api_cell0"},{"line_number":692,"context_line":"        fi"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Migrate nova database. If \"nova-manage cell_v2 simple_cell_setup\" has"},{"line_number":695,"context_line":"        # been run this migrates the \"nova\" and \"nova_api_cell0\" database."},{"line_number":696,"context_line":"        # Otherwise it just migrates the \"nova\" database."},{"line_number":697,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        if is_service_enabled n-cell; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa7ab95a_3a479978","line":696,"range":{"start_line":694,"start_character":33,"end_line":696,"end_character":57},"in_reply_to":"fa7ab95a_da878d10","updated":"2016-08-31 19:00:35.000000000","message":"I originally wrote it like this because afaict the init_nova method can be run multiple times, and if it\u0027s run again after a simple_cell_setup then the behavior changes slightly.\n\nIf it will only ever be run once then this addition isn\u0027t necessary.","commit_id":"bb9f8508ad34a1ccd246f36e9b593ae8f041b8d5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7a359f6dd882603cb60ef72b6d1b586a086cb3b2","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    if is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-api; then"},{"line_number":688,"context_line":"        # (Re)create nova databases"},{"line_number":689,"context_line":"        recreate_database nova"},{"line_number":690,"context_line":"        if [ \"$NOVA_CONFIGURE_CELLSV2\" !\u003d \"False\" ]; then"},{"line_number":691,"context_line":"            recreate_database nova_api_cell0"},{"line_number":692,"context_line":"        fi"},{"line_number":693,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa7ab95a_fd2d2bfe","line":690,"updated":"2016-08-31 19:09:39.000000000","message":"nit: in the top change you check \u003d\u003d \"True\", could do the same here, but meh.","commit_id":"eb6ef2f80ea11aa7ba3f9ff52cb03704db3547d4"}]}