)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"aca4ce4a45b710a86b115d8e450363fbc4c5ee1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.install apache and wsgi module"},{"line_number":10,"context_line":"2.config apache2 vhost and wsgi files for admin and public service."},{"line_number":11,"context_line":"3.refactor apache functions from horizon and swift into lib/apache"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3a5d1e511c5dca1e6d01a1adca8fda0a43d4f222"},{"line_number":14,"context_line":"Implements: blueprint devstack-setup-apache-keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAQn%2F%2FL%2Fs%3D","line":11,"updated":"2013-08-05 18:58:40.000000000","message":"Remove #3?","commit_id":"2e4b2908cc3bc50e98890a6de6f76a9ce9728197"}],"README.md":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Apache Frontend"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Apache web server is enabled for wsgi services by setting `APACHE_ENABLED_SERVICES` in your localrc. But remember to enable these services at first as above."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Example:"},{"line_number":91,"context_line":"    APACHE_ENABLED_SERVICES+\u003dkeystone,swift"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"AAAAP3%2F%2Fsm4%3D","line":88,"updated":"2013-07-12 20:49:01.000000000","message":"This sentence does not make sense.  \"But remember to enable these services at first as above\"  Perhaps you mean \"But remember to enable these services as shown in the following example\"   Also it looks like the line length is too long. Did you forget a return?","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Apache Frontend"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Apache web server is enabled for wsgi services by setting `APACHE_ENABLED_SERVICES` in your localrc. But remember to enable these services at first as above."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Example:"},{"line_number":91,"context_line":"    APACHE_ENABLED_SERVICES+\u003dkeystone,swift"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"AAAAQn%2F%2F7FE%3D","line":88,"in_reply_to":"AAAAP3%2F%2Fsm4%3D","updated":"2013-07-19 02:52:47.000000000","message":"A little confuse here. I mean to enable apache for these services, you need to install them at first by adding it in ENABLED_SERVICES at first. will polish it.","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}],"files/keystone/admin.wsgi":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if CONF.debug:"},{"line_number":17,"context_line":"    CONF.log_opt_values(logging.getLogger(CONF.prog), logging.DEBUG)"},{"line_number":18,"context_line":"    "},{"line_number":19,"context_line":"application \u003d deploy.loadapp(\u0027config:%s\u0027 % config.find_paste_config(), name\u003d\u0027admin\u0027)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAP3%2F%2Fsms%3D","line":18,"updated":"2013-07-12 20:49:01.000000000","message":"remove unnecessary blank space","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}],"lib/horizon":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Dependencies:"},{"line_number":6,"context_line":"# ``functions`` file"},{"line_number":7,"context_line":"# ``apache`` file"},{"line_number":8,"context_line":"# ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"},{"line_number":9,"context_line":"# \u003clist other global vars that are assumed to be defined\u003e"},{"line_number":10,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAP3%2F%2Fsl0%3D","line":7,"updated":"2013-07-12 20:49:01.000000000","message":"Nice!!!","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}],"lib/keystone":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        s/35357/$KEYSTONE_AUTH_PORT/g"},{"line_number":97,"context_line":"    \" -i /etc/$APACHE_NAME/site-available/keystone"},{"line_number":98,"context_line":"    ! is_fedora \u0026\u0026 sudo a2ensite keystone"},{"line_number":99,"context_line":"    "},{"line_number":100,"context_line":"    sudo cp $FILES/keystone/*.wsgi $KEYSTONE_WSGI_DIR"},{"line_number":101,"context_line":"    sudo sed -e \""},{"line_number":102,"context_line":"        s/\\/var\\/www\\/keystone/$KEYSTONE_WSGI_DIR/g"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAP3%2F%2Fskk%3D","line":99,"updated":"2013-07-12 20:49:01.000000000","message":"remove unnecessary whitespace","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        s/35357/$KEYSTONE_AUTH_PORT/g"},{"line_number":97,"context_line":"    \" -i /etc/$APACHE_NAME/site-available/keystone"},{"line_number":98,"context_line":"    ! is_fedora \u0026\u0026 sudo a2ensite keystone"},{"line_number":99,"context_line":"    "},{"line_number":100,"context_line":"    sudo cp $FILES/keystone/*.wsgi $KEYSTONE_WSGI_DIR"},{"line_number":101,"context_line":"    sudo sed -e \""},{"line_number":102,"context_line":"        s/\\/var\\/www\\/keystone/$KEYSTONE_WSGI_DIR/g"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2F7Dw%3D","line":99,"in_reply_to":"AAAAP3%2F%2Fskk%3D","updated":"2013-07-19 02:52:47.000000000","message":"Done","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    cp $KEYSTONE_DIR/etc/logging.conf.sample $KEYSTONE_CONF_DIR/logging.conf"},{"line_number":213,"context_line":"    iniset $KEYSTONE_CONF_DIR/logging.conf logger_root level \"DEBUG\""},{"line_number":214,"context_line":"    iniset $KEYSTONE_CONF_DIR/logging.conf logger_root handlers \"devel,production\""},{"line_number":215,"context_line":"    "},{"line_number":216,"context_line":"    echo \"decide if apache wsgi serviceis enabled\""},{"line_number":217,"context_line":"    if is_apache_enabled_service keystone; then"},{"line_number":218,"context_line":"    \techo \"configing apache wsgi service....\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAP3%2F%2FskY%3D","line":215,"updated":"2013-07-12 20:49:01.000000000","message":"remove white space","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    cp $KEYSTONE_DIR/etc/logging.conf.sample $KEYSTONE_CONF_DIR/logging.conf"},{"line_number":213,"context_line":"    iniset $KEYSTONE_CONF_DIR/logging.conf logger_root level \"DEBUG\""},{"line_number":214,"context_line":"    iniset $KEYSTONE_CONF_DIR/logging.conf logger_root handlers \"devel,production\""},{"line_number":215,"context_line":"    "},{"line_number":216,"context_line":"    echo \"decide if apache wsgi serviceis enabled\""},{"line_number":217,"context_line":"    if is_apache_enabled_service keystone; then"},{"line_number":218,"context_line":"    \techo \"configing apache wsgi service....\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2F7D0%3D","line":215,"in_reply_to":"AAAAP3%2F%2FskY%3D","updated":"2013-07-19 02:52:47.000000000","message":"Done","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    "},{"line_number":216,"context_line":"    echo \"decide if apache wsgi serviceis enabled\""},{"line_number":217,"context_line":"    if is_apache_enabled_service keystone; then"},{"line_number":218,"context_line":"    \techo \"configing apache wsgi service....\""},{"line_number":219,"context_line":"        _config_keystone_apache_wsgi"},{"line_number":220,"context_line":"    fi"},{"line_number":221,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAP3%2F%2FskU%3D","line":218,"updated":"2013-07-12 20:49:01.000000000","message":"remove whatever is causing problems here","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    "},{"line_number":216,"context_line":"    echo \"decide if apache wsgi serviceis enabled\""},{"line_number":217,"context_line":"    if is_apache_enabled_service keystone; then"},{"line_number":218,"context_line":"    \techo \"configing apache wsgi service....\""},{"line_number":219,"context_line":"        _config_keystone_apache_wsgi"},{"line_number":220,"context_line":"    fi"},{"line_number":221,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2F7D4%3D","line":218,"in_reply_to":"AAAAP3%2F%2FskU%3D","updated":"2013-07-19 02:52:47.000000000","message":"Done","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}],"lib/swift":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"71cb1d509a73609d8e3d921f9ee4bdbeee5f317e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      rm ${SWIFT_DATA_DIR}/drives/images/swift.img"},{"line_number":102,"context_line":"   fi"},{"line_number":103,"context_line":"   rm -rf ${SWIFT_DATA_DIR}/run/"},{"line_number":104,"context_line":"   if is_apache_enabled_service swift; then"},{"line_number":105,"context_line":"       _cleanup_swift_apache_wsgi"},{"line_number":106,"context_line":"   fi"},{"line_number":107,"context_line":"}"}],"source_content_type":"text/x-swift","patch_set":2,"id":"AAAAP3%2F%2FsL0%3D","line":104,"updated":"2013-07-12 22:37:01.000000000","message":"What is this?  It looks like it is for Swift apach support, which should be a separate patch","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      rm ${SWIFT_DATA_DIR}/drives/images/swift.img"},{"line_number":102,"context_line":"   fi"},{"line_number":103,"context_line":"   rm -rf ${SWIFT_DATA_DIR}/run/"},{"line_number":104,"context_line":"   if is_apache_enabled_service swift; then"},{"line_number":105,"context_line":"       _cleanup_swift_apache_wsgi"},{"line_number":106,"context_line":"   fi"},{"line_number":107,"context_line":"}"}],"source_content_type":"text/x-swift","patch_set":2,"id":"AAAAQn%2F%2F7Do%3D","line":104,"in_reply_to":"AAAAP3%2F%2FsL0%3D","updated":"2013-07-19 02:52:47.000000000","message":"agree with you. It has been submitted as a separate patch which  was early than this one. But this one has dependency on that, so I combined them in this draft patch for easier review. When that one got merged, I\u0027ll rebase it.","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}],"stack.sh":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"1c2b6810c98a45ce1d1ef66d61b9af28ba9cdabd","unresolved":false,"context_lines":[{"line_number":298,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"# Source project function libraries"},{"line_number":301,"context_line":"source $TOP_DIR/lib/apache"},{"line_number":302,"context_line":"source $TOP_DIR/lib/tls"},{"line_number":303,"context_line":"source $TOP_DIR/lib/horizon"},{"line_number":304,"context_line":"source $TOP_DIR/lib/keystone"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAP3%2F%2FslA%3D","line":301,"updated":"2013-07-12 20:49:01.000000000","message":"why does your line have a + at the beginning and the others do not?","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"5e0dc859ca1fe4d18ae98af958b6b9f680fe3b5e","unresolved":false,"context_lines":[{"line_number":298,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"# Source project function libraries"},{"line_number":301,"context_line":"source $TOP_DIR/lib/apache"},{"line_number":302,"context_line":"source $TOP_DIR/lib/tls"},{"line_number":303,"context_line":"source $TOP_DIR/lib/horizon"},{"line_number":304,"context_line":"source $TOP_DIR/lib/keystone"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAQn%2F%2F7DQ%3D","line":301,"in_reply_to":"AAAAP3%2F%2FslA%3D","updated":"2013-07-19 02:52:47.000000000","message":"I didn\u0027t see any + here.","commit_id":"7a76447f406782b4950a08760857b3a83b1d2422"}]}