)]}'
{"id":"openstack%2Fdevstack~365146","triplet_id":"openstack%2Fdevstack~master~I67cc103269d2d612ad443c72f2a77d7ae2ca09e3","project":"openstack/devstack","branch":"master","topic":"cleanup","hashtags":[],"change_id":"I67cc103269d2d612ad443c72f2a77d7ae2ca09e3","subject":"Remove the same configurations as the default","status":"MERGED","created":"2016-09-02 21:20:56.000000000","updated":"2016-09-26 16:53:43.000000000","submitted":"2016-09-26 16:53:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"067d3ea74b7f5ccb87f72b35e28345636523ad3e","_number":365146,"virtual_id_number":365146,"owner":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":2,"date":"2016-09-26 16:53:43.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":2,"date":"2016-09-06 16:03:33.000000000","_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-13 03:43:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},{"value":1,"date":"2016-09-07 07:06:12.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2016-09-26 12:45:24.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2016-09-26 12:45:24.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-06 16:03:33.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-09-07 07:06:12.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2016-09-13 03:43:30.000000000","updated_by":{"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},"reviewer":{"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},"state":"REVIEWER"},{"updated":"2016-09-26 12:45:24.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-09-26 16:53:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f70c4813e54d2de98e4af2bd3e97932bd409d817","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2016-09-02 21:20:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dda8688974b1db4ffc0f786aff3d6250e71de3f0","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-09-02 22:26:14.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/46/365146/1/check/check-ibm-tempest-dsvm-full/483111f/ : SUCCESS in 1h 04m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b61d1ec4c2b615ff3f74accd6c69a8e5ff922a17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-02 22:38:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-grenade-dsvm-neutron-ubuntu-trusty http://logs.openstack.org/46/365146/1/check/gate-grenade-dsvm-neutron-ubuntu-trusty/73e0b2a/ : SUCCESS in 44m 52s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/d926f85/ : SUCCESS in 1h 14m 01s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-full-ubuntu-xenial/1a35078/ : SUCCESS in 51m 16s\n- gate-grenade-dsvm-ubuntu-trusty http://logs.openstack.org/46/365146/1/check/gate-grenade-dsvm-ubuntu-trusty/d20148f/ : SUCCESS in 55m 23s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/46/365146/1/check/gate-devstack-docs-ubuntu-xenial/2eb555f//doc/build/html/ : SUCCESS in 3m 31s\n- gate-devstack-bashate http://logs.openstack.org/46/365146/1/check/gate-devstack-bashate/4ef6fc2/ : SUCCESS in 3m 11s\n- gate-devstack-unit-tests http://logs.openstack.org/46/365146/1/check/gate-devstack-unit-tests/ff1bcda/ : SUCCESS in 2m 23s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv/d706e0c/ : SUCCESS in 22m 39s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/46/365146/1/check/gate-devstack-dsvm-updown/4af40ac/ : SUCCESS in 13m 40s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/784de5a/ : FAILURE in 11m 45s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/46/365146/1/check/gate-swift-dsvm-functional-nv/9b88d6b/ : SUCCESS in 23m 46s (non-voting)\n- gate-tempest-dsvm-multinode-full http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-multinode-full/338e380/ : SUCCESS in 53m 41s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-neutron-multinode-full/8f95113/ : SUCCESS in 1h 16m 00s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/46/365146/1/check/gate-grenade-dsvm-multinode/743ea8c/ : SUCCESS in 47m 22s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/46/365146/1/check/gate-grenade-dsvm-neutron-multinode/3dba8ae/ : SUCCESS in 37m 30s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-platform-centos7-nv/2bc8525/ : SUCCESS in 59m 48s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/46/365146/1/check/gate-tempest-dsvm-platform-fedora23-nv/86ccf02/ : SUCCESS in 54m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a6ec2cd1e94d848382403e48288770ba01bbb040","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-09-03 00:10:16.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- dsvm-tempest-nova-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/365146/1/check/dsvm-tempest-nova-network/b0fb51a : SUCCESS in 1h 44m 19s\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/46/365146/1/check/dsvm-tempest-neutron-network/adcf5f3 : SUCCESS in 2h 19m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"88d20bb690cf5805e079982cf37454467fdaa896","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-09-03 03:04:30.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-nfv-networking http://intel-openstack-ci-logs.ovh/46/365146/1/check/tempest-dsvm-ovsdpdk-nfv-networking/b7b8ec4 : SUCCESS in 1h 03m 18s\n- tempest-dsvm-full-nfv http://intel-openstack-ci-logs.ovh/46/365146/1/check/tempest-dsvm-full-nfv/ecdda33 : SUCCESS in 2h 02m 10s","accounts_in_message":[],"_revision_number":1},{"id":"08e6ce4b7305481e0fd04a93011638c8de2de673","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-09-05 01:28:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8e3061f2b1fdffdf4a568f768dcbe730f73707d7","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-09-06 16:03:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"084cea44f0a30cd3438cd79c5219603d388b5da2","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2016-09-07 07:06:12.000000000","message":"Patch Set 1: Code-Review+1\n\nYea, its nice not to redefine the same default value as default value change can be caught with that.","accounts_in_message":[],"_revision_number":1},{"id":"1fdd98bf8fbec9b656773b32b1922374aca163ea","author":{"_account_id":23303,"name":"howardlee","email":"lihongweibj@inspur.com","username":"howardlee"},"date":"2016-09-13 03:43:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5a434256b4d8a450adbe7ca38b2aca5cf5e6f096","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-09-26 12:45:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI think stripping out default values is useful, it also lets us catch times where defaults change on us.","accounts_in_message":[],"_revision_number":1},{"id":"ce74f7cf75a4ccd005af9fa26c5c5b68276a294f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-26 12:45:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"861da716bdbb5ed3caa3709de97c047886cb81b2","date":"2016-09-26 16:53:43.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"06f3c8282ecb94455543a48ba1280f0beccac151","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-26 16:53:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/46/365146/1/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f2cf43e/ : SUCCESS in 1h 13m 09s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/46/365146/1/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/db2d531/ : SUCCESS in 1h 01m 27s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/46/365146/1/gate/gate-tempest-dsvm-full-ubuntu-xenial/e7b5c56/ : SUCCESS in 1h 03m 24s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/46/365146/1/gate/gate-grenade-dsvm-ubuntu-xenial/0145e19/ : SUCCESS in 49m 19s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/46/365146/1/gate/gate-devstack-docs-ubuntu-xenial/f1cbf10//doc/build/html/ : SUCCESS in 1m 54s\n- gate-devstack-bashate http://logs.openstack.org/46/365146/1/gate/gate-devstack-bashate/e1dea47/ : SUCCESS in 4m 45s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/46/365146/1/gate/gate-grenade-dsvm-multinode/fc059d5/ : SUCCESS in 47m 21s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/46/365146/1/gate/gate-grenade-dsvm-neutron-multinode/583da5a/ : SUCCESS in 33m 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"085f2fb0e2d399281b137c9fa95a7a39e270be7d","revisions":{"085f2fb0e2d399281b137c9fa95a7a39e270be7d":{"kind":"REWORK","_number":1,"created":"2016-09-02 21:20:56.000000000","uploader":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"ref":"refs/changes/46/365146/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/46/365146/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/365146/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/365146/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/46/365146/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/46/365146/1"}}},"commit":{"parents":[{"commit":"6affe6db29ee3ad51a3768afb7e9ba05d25188e7","subject":"Merge \"Change quota_injected_file_path_bytes to quota_injected_file_path_length\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6affe6db29ee3ad51a3768afb7e9ba05d25188e7"}]}],"author":{"name":"Ken\u0027ichi Ohmichi","email":"ken-oomichi@wx.jp.nec.com","date":"2016-09-02 21:00:39.000000000","tz":-420},"committer":{"name":"Ken\u0027ichi Ohmichi","email":"ken-oomichi@wx.jp.nec.com","date":"2016-09-02 21:19:52.000000000","tz":-420},"subject":"Remove the same configurations as the default","message":"Remove the same configurations as the default\n\nThe default value of force_dhcp_release is True on Nova side:\nhttps://github.com/openstack/nova/blob/master/nova/conf/network.py#L306\nThe default value of vnc.enabled is True on Nova side:\nhttps://github.com/openstack/nova/blob/master/nova/conf/vnc.py#L27\nThe default value of spice.enabled is False on Nova side:\nhttps://github.com/openstack/nova/blob/master/nova/conf/spice.py#L30\n\nSo it is not necessary to set them on Devstack.\n\nChange-Id: I67cc103269d2d612ad443c72f2a77d7ae2ca09e3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/085f2fb0e2d399281b137c9fa95a7a39e270be7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/085f2fb0e2d399281b137c9fa95a7a39e270be7d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}