)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5b94d6ebbd0a1e02c5600f6011e80b726210eb7d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Midonet plugin support to devstack."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for Midokura\u0027s Midonet plugin to devstack, in lib/neutron_plugins and lib/neutron_thirdparty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9b4d90eab09bbb21b9ba251a311620e0a21e8219"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2Fhuk%3D","line":9,"updated":"2013-07-29 19:30:07.000000000","message":"Please line-wrap this to less than 72 chars","commit_id":"668719b36b2c90d21206fd154085eb0bc0ee3432"}],"lib/neutron_plugins/midonet":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"057c33d2d4284f8c673be915384e73727b82ebf7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Neutron MidoNet plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"},{"line_number":5,"context_line":"MY_XTRACE\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2FuOc%3D","line":2,"updated":"2013-07-24 13:13:47.000000000","message":"can you please have this the same length as the header above (it is cleaner)","commit_id":"86a6d51384493f0d72ecdc9f57988d5319970896"},{"author":{"_account_id":8081,"name":"Alex Vasilyev","email":"avasilyev@midokura.com","username":"av"},"change_message_id":"7b8cc288b20940bc2b89e0355d04c04f3531f107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Neutron MidoNet plugin"},{"line_number":2,"context_line":"# ---------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Save trace setting"},{"line_number":5,"context_line":"MY_XTRACE\u003d$(set +o | grep xtrace)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2Fr3Q%3D","line":2,"in_reply_to":"AAAAQn%2F%2FuOc%3D","updated":"2013-07-25 03:12:23.000000000","message":"Sure, I\u0027ll update this.","commit_id":"86a6d51384493f0d72ecdc9f57988d5319970896"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"057c33d2d4284f8c673be915384e73727b82ebf7","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"function neutron_plugin_create_nova_conf() {"},{"line_number":15,"context_line":"    # Requires installing MidoNet OpenStack package from source:"},{"line_number":16,"context_line":"    # https://github.com/midokura/midonet-openstack"},{"line_number":17,"context_line":"    NOVA_VIF_DRIVER\u003d${NOVA_VIF_DRIVER:-\"midonet.nova.virt.libvirt.vif.MidonetVifDriver\"}"},{"line_number":18,"context_line":"}"},{"line_number":19,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2FuOA%3D","line":16,"updated":"2013-07-24 13:13:47.000000000","message":"Comment ere was confusing - saw that you addressed this in lib/neutron_thirdparty/midonet","commit_id":"86a6d51384493f0d72ecdc9f57988d5319970896"}],"lib/neutron_thirdparty/midonet":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4fe16cbad64350c1dbb18815e36eacf9c3426cbb","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # Initialize DB.  Evaluate the output of setup_midonet_topology.py to set"},{"line_number":40,"context_line":"    # env variables for provider router ID"},{"line_number":41,"context_line":"    eval `python $MIDONET_SETUP_SCRIPT admin $ADMIN_PASSWORD $ADMIN_TENANT provider_devices 2\u003e /dev/null`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE MIDONET provider_router_id $provider_router_id"},{"line_number":44,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE MIDONET metadata_router_id $metadata_router_id"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAQn%2F%2FnwE%3D","line":41,"updated":"2013-07-26 11:10:15.000000000","message":"why dumping STDERR?","commit_id":"95d124ad4d1864a32080bedf75070ea7513e6558"},{"author":{"_account_id":8081,"name":"Alex Vasilyev","email":"avasilyev@midokura.com","username":"av"},"change_message_id":"7f373afa9b935b8b38af8d60bf232e31dd294ee0","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # Initialize DB.  Evaluate the output of setup_midonet_topology.py to set"},{"line_number":40,"context_line":"    # env variables for provider router ID"},{"line_number":41,"context_line":"    eval `python $MIDONET_SETUP_SCRIPT admin $ADMIN_PASSWORD $ADMIN_TENANT provider_devices 2\u003e /dev/null`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE MIDONET provider_router_id $provider_router_id"},{"line_number":44,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE MIDONET metadata_router_id $metadata_router_id"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAQn%2F%2FkIY%3D","line":41,"in_reply_to":"AAAAQn%2F%2FnwE%3D","updated":"2013-07-29 02:58:29.000000000","message":"changed this to use die_if_not_set","commit_id":"95d124ad4d1864a32080bedf75070ea7513e6558"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4fe16cbad64350c1dbb18815e36eacf9c3426cbb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    export PYTHONPATH\u003d$MIDONET_CLIENT_DIR/src:$MIDONET_OS_DIR/src:$PYTHONPATH"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"function start_midonet() {"},{"line_number":54,"context_line":"    enable_service midolman"},{"line_number":55,"context_line":"    screen_it midolman \"tail -f $MIDOLMAN_LOG\""},{"line_number":56,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAQn%2F%2Fnv8%3D","line":53,"updated":"2013-07-26 11:10:15.000000000","message":"do we really need to add these as screen sessions? They don\u0027t demonize properly?","commit_id":"95d124ad4d1864a32080bedf75070ea7513e6558"},{"author":{"_account_id":8081,"name":"Alex Vasilyev","email":"avasilyev@midokura.com","username":"av"},"change_message_id":"7f373afa9b935b8b38af8d60bf232e31dd294ee0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    export PYTHONPATH\u003d$MIDONET_CLIENT_DIR/src:$MIDONET_OS_DIR/src:$PYTHONPATH"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"function start_midonet() {"},{"line_number":54,"context_line":"    enable_service midolman"},{"line_number":55,"context_line":"    screen_it midolman \"tail -f $MIDOLMAN_LOG\""},{"line_number":56,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAQn%2F%2FkIU%3D","line":53,"in_reply_to":"AAAAQn%2F%2Fnv8%3D","updated":"2013-07-29 02:58:29.000000000","message":"removed","commit_id":"95d124ad4d1864a32080bedf75070ea7513e6558"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5b94d6ebbd0a1e02c5600f6011e80b726210eb7d","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"function start_midonet() {"},{"line_number":56,"context_line":"    enable_service midolman"},{"line_number":57,"context_line":"    enable_service mido-api"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function stop_midonet() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAQn%2F%2Fhus%3D","line":57,"updated":"2013-07-29 19:30:07.000000000","message":"I\u0027m not sure I understand why these are here (the disable_service() calls below too).  enable_service() is a wrapper for adding a service name to the ENABLED_SERVICES environment variable.  start_midonet() is called when the service is supposed to be started; if it runs outside of devstack\u0027s control then this should be empty.","commit_id":"668719b36b2c90d21206fd154085eb0bc0ee3432"},{"author":{"_account_id":8081,"name":"Alex Vasilyev","email":"avasilyev@midokura.com","username":"av"},"change_message_id":"5eb21037176e844ee00a0c742b15bc2d45bcf8f5","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"function start_midonet() {"},{"line_number":56,"context_line":"    enable_service midolman"},{"line_number":57,"context_line":"    enable_service mido-api"},{"line_number":58,"context_line":"}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"function stop_midonet() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAQn%2F%2FgmU%3D","line":57,"in_reply_to":"AAAAQn%2F%2Fhus%3D","updated":"2013-07-30 01:43:44.000000000","message":"Oh you\u0027re right, I didn\u0027t realize this. These were in our previous scripts we had but I guess they\u0027re not needed, thanks for pointing this out.\nI\u0027ll submit a new patch but I would actually like to add the screen_it calls back into this function, they tail the logs and make development more convenient for anyone running devstack with the midonet plugin. Those who don\u0027t use midonet won\u0027t be affected so it won\u0027t clutter their screen session.","commit_id":"668719b36b2c90d21206fd154085eb0bc0ee3432"}]}