)]}'
{"clean.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"92c15bcd9619bcf59783c0361f19c38bb9a8df41","unresolved":false,"context_lines":[{"line_number":124,"context_line":"if [[ -n \"$LOGFILE\" ]] \u0026\u0026 [[ -f \"$LOGFILE\" ]]; then"},{"line_number":125,"context_line":"    sudo rm -f $LOGFILE"},{"line_number":126,"context_line":"fi"},{"line_number":127,"context_line":"if [[ -n \"$LOGDIR\" ]] \u0026\u0026 [[ -d \"$LOGDIR\" ]] \u0026\u0026 [[ \"$LOGDIR\" !\u003d \"$HOME\" ]]; then"},{"line_number":128,"context_line":"    sudo rm -rf $LOGDIR"},{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":"if [[ -n \"$SCREEN_LOGDIR\" ]] \u0026\u0026 [[ -d \"$SCREEN_LOGDIR\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_48fbf846","line":127,"updated":"2016-09-08 19:40:28.000000000","message":"This kind of feels like a user config issue, and a thing that you just shouldn\u0027t do. This will start to balloon through the whole code.","commit_id":"abaafbdbd78a5e4554285141f3aaf1b0197ef1ab"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a56ceb9c9e758a07e9049f03f2ca7a309d6e1da2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"if [[ -n \"$LOGFILE\" ]] \u0026\u0026 [[ -f \"$LOGFILE\" ]]; then"},{"line_number":125,"context_line":"    sudo rm -f $LOGFILE"},{"line_number":126,"context_line":"fi"},{"line_number":127,"context_line":"if [[ -n \"$LOGDIR\" ]] \u0026\u0026 [[ -d \"$LOGDIR\" ]] \u0026\u0026 [[ \"$LOGDIR\" !\u003d \"$HOME\" ]]; then"},{"line_number":128,"context_line":"    sudo rm -rf $LOGDIR"},{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":"if [[ -n \"$SCREEN_LOGDIR\" ]] \u0026\u0026 [[ -d \"$SCREEN_LOGDIR\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_43b83b2a","line":127,"in_reply_to":"9a89bdaa_48fbf846","updated":"2016-09-08 19:48:30.000000000","message":"I agree that it is misconfiguration issue, There are two patches https://review.openstack.org/#/c/366518/ and https://review.openstack.org/258021, last one is already merged, but they doesn\u0027t fix issue that is described in the bug.\nWhy we can\u0027t skip removing $HOME directory in such way?","commit_id":"abaafbdbd78a5e4554285141f3aaf1b0197ef1ab"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"937fff22ece9c4257dfead11003cfed48a9551bc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"if [[ -n \"$LOGDIR\" ]] \u0026\u0026 [[ -d \"$LOGDIR\" ]] \u0026\u0026 [[ \"$LOGDIR\" !\u003d \"$HOME\" ]]; then"},{"line_number":128,"context_line":"    sudo rm -rf $LOGDIR"},{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":"if [[ -n \"$SCREEN_LOGDIR\" ]] \u0026\u0026 [[ -d \"$SCREEN_LOGDIR\" ]]; then"},{"line_number":131,"context_line":"    sudo rm -rf $SCREEN_LOGDIR"},{"line_number":132,"context_line":"fi"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_1e867c13","line":130,"range":{"start_line":130,"start_character":11,"end_line":130,"end_character":24},"updated":"2016-09-09 00:56:32.000000000","message":"lGTM but, It should add  \u0026\u0026 [[ \"$SCREEN_LOGDIR\" !\u003d \"$HOME\" ]] to avoid set wrong SCREEN_LOGDIR.","commit_id":"abaafbdbd78a5e4554285141f3aaf1b0197ef1ab"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"80ebcce8f34901d1df06c63766f1d189250d1e7c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"if [[ -n \"$LOGDIR\" ]] \u0026\u0026 [[ -d \"$LOGDIR\" ]] \u0026\u0026 [[ \"$LOGDIR\" !\u003d \"$HOME\" ]]; then"},{"line_number":128,"context_line":"    sudo rm -rf $LOGDIR"},{"line_number":129,"context_line":"fi"},{"line_number":130,"context_line":"if [[ -n \"$SCREEN_LOGDIR\" ]] \u0026\u0026 [[ -d \"$SCREEN_LOGDIR\" ]]; then"},{"line_number":131,"context_line":"    sudo rm -rf $SCREEN_LOGDIR"},{"line_number":132,"context_line":"fi"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_8085c2ae","line":130,"range":{"start_line":130,"start_character":11,"end_line":130,"end_character":24},"in_reply_to":"9a89bdaa_1e867c13","updated":"2016-09-09 07:27:17.000000000","message":"Done","commit_id":"abaafbdbd78a5e4554285141f3aaf1b0197ef1ab"}]}
