)]}'
{"id":"openstack%2Fdevstack~368919","triplet_id":"openstack%2Fdevstack~master~I1c1ef093b70007100646c086dc5724cd64751d00","project":"openstack/devstack","branch":"master","topic":"bug/1622649","hashtags":[],"change_id":"I1c1ef093b70007100646c086dc5724cd64751d00","subject":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue","status":"MERGED","created":"2016-09-12 15:27:43.000000000","updated":"2016-09-12 19:57:41.000000000","submitted":"2016-09-12 18:31:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"902286169b57ee8503a6accc85176294bd4e6555","_number":368919,"virtual_id_number":368919,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-09-12 18:31:56.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2016-09-12 19:57:41.000000000","post_submit":true,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2016-09-12 15:45:29.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2016-09-12 15:43:43.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-09-12 15:45:29.000000000","_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-12 15:43:43.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2016-09-12 15:45:29.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2016-09-12 18:31:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-12 19:57:41.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"73b4ec408bda5d884e88f8f19f62044312ca7a41","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-09-12 15:27:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"659ef8ea0b51b3647f36cdb66b73bbe8a4d26c35","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2016-09-12 15:29:31.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7decebeb3e3894d414742175ebf475e7ecbcbf1c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-09-12 15:30:49.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"2a76d08fe9a20ac81d129268b5f3c918b5ac0d70","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2016-09-12 15:32:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8a5c1f4789e68e6fbfe151f0ca7d4a98f861e6d3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-09-12 15:36:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a3731d9764db0e2c73b19ab745134614e6d0b74b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2016-09-12 15:43:43.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"cb3c0abac39a88894a17f195bfba4f658a0f6376","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2016-09-12 15:45:29.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"fac8c75b9810a0db506e00f37caef3bedd25dc08","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-09-12 16:36:08.000000000","message":"Patch Set 3:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/19/368919/3/check/check-ibm-tempest-dsvm-full/98dfea7/ : SUCCESS in 59m 44s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"cb92a2f9b2a0cc7f575495d85c598f4ed3a6b0fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 17:02:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-grenade-dsvm-neutron-ubuntu-trusty http://logs.openstack.org/19/368919/3/check/gate-grenade-dsvm-neutron-ubuntu-trusty/15798c7/ : SUCCESS in 46m 35s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fce9899/ : SUCCESS in 1h 01m 55s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-full-ubuntu-xenial/8643519/ : SUCCESS in 1h 01m 01s\n- gate-grenade-dsvm-ubuntu-trusty http://logs.openstack.org/19/368919/3/check/gate-grenade-dsvm-ubuntu-trusty/97d64f3/ : SUCCESS in 25m 06s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/19/368919/3/check/gate-devstack-docs-ubuntu-xenial/ec9bf7b//doc/build/html/ : SUCCESS in 3m 26s\n- gate-devstack-bashate http://logs.openstack.org/19/368919/3/check/gate-devstack-bashate/b452ca5/ : SUCCESS in 2m 25s\n- gate-devstack-unit-tests http://logs.openstack.org/19/368919/3/check/gate-devstack-unit-tests/46914bd/ : SUCCESS in 2m 36s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv/4167d69/ : SUCCESS in 27m 47s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/19/368919/3/check/gate-devstack-dsvm-updown/b4a215d/ : SUCCESS in 18m 20s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-nv http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-neutron-identity-v3-only-full-nv/788f996/ : FAILURE in 15m 17s (non-voting)\n- gate-swift-dsvm-functional-nv http://logs.openstack.org/19/368919/3/check/gate-swift-dsvm-functional-nv/7c98452/ : SUCCESS in 21m 50s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial/2a0e2a3/ : FAILURE in 1h 12m 42s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial/7fda48e/ : SUCCESS in 1h 20m 59s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/19/368919/3/check/gate-grenade-dsvm-multinode/93e0f88/ : SUCCESS in 46m 25s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/19/368919/3/check/gate-grenade-dsvm-neutron-multinode/bd5a010/ : SUCCESS in 56m 43s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-platform-centos7-nv/0ed5175/ : SUCCESS in 1h 07m 24s (non-voting)\n- gate-tempest-dsvm-platform-fedora23-nv http://logs.openstack.org/19/368919/3/check/gate-tempest-dsvm-platform-fedora23-nv/33636a1/ : SUCCESS in 55m 56s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"38215d863e530261818096d65f551531002f80e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 17:02:43.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"7e9bfa970ee644b3157327d8f768a66d8e5870c9","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-09-12 17:46:39.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- dsvm-tempest-nova-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/19/368919/3/check/dsvm-tempest-nova-network/3537a13 : SUCCESS in 1h 22m 58s\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/19/368919/3/check/dsvm-tempest-neutron-network/7d3b61c : SUCCESS in 2h 00m 36s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"88dd31e1669d5446e46b5460c8fd7054b52bae77","date":"2016-09-12 18:31:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"62af864a9239b2f148cccae0db69374fadfb8f83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 18:31:56.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-grenade-dsvm-neutron-ubuntu-trusty http://logs.openstack.org/19/368919/3/gate/gate-grenade-dsvm-neutron-ubuntu-trusty/82c1fb9/ : SUCCESS in 30m 09s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/a8ec6dc/ : SUCCESS in 1h 03m 19s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/19/368919/3/gate/gate-tempest-dsvm-full-ubuntu-xenial/8e5dc8e/ : SUCCESS in 48m 23s\n- gate-grenade-dsvm-ubuntu-trusty http://logs.openstack.org/19/368919/3/gate/gate-grenade-dsvm-ubuntu-trusty/ff30ba9/ : SUCCESS in 27m 32s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/19/368919/3/gate/gate-devstack-docs-ubuntu-xenial/cb044d7//doc/build/html/ : SUCCESS in 2m 03s\n- gate-devstack-bashate http://logs.openstack.org/19/368919/3/gate/gate-devstack-bashate/76c1ce3/ : SUCCESS in 2m 21s\n- gate-grenade-dsvm-multinode http://logs.openstack.org/19/368919/3/gate/gate-grenade-dsvm-multinode/95b3beb/ : SUCCESS in 27m 31s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/19/368919/3/gate/gate-grenade-dsvm-neutron-multinode/65c5cf7/ : SUCCESS in 36m 28s","accounts_in_message":[],"_revision_number":3},{"id":"6474ca57c0b6fa7bd8182aaf7134611d2e4e8167","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-09-12 19:57:41.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/19/368919/3/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/b0e0d26 : SUCCESS in 1h 03m 13s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/19/368919/3/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/a698266 : SUCCESS in 1h 12m 46s (non-voting)\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/19/368919/3/check/tempest-dsvm-full-nfv-xenial/29649f4 : SUCCESS in 1h 56m 44s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6390d5ef8236028c8dc00c5514e7ceac60ffd627","revisions":{"b2086eca1ada37f1ae31ad9eea3fb384a7d81ac0":{"kind":"REWORK","_number":1,"created":"2016-09-12 15:27:43.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/368919/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/19/368919/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/19/368919/1"}}},"commit":{"parents":[{"commit":"8a770cb050a5e49edba77f8e4de9076e88e3ec21","subject":"Merge \"Add thin-provisioning-tools for Cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8a770cb050a5e49edba77f8e4de9076e88e3ec21"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:23:19.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:23:19.000000000","tz":-240},"subject":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue","message":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue\n\nThere is a bit of a weird history here, but the net is we\u0027re not\ninstalling python-guestfs when ENABLE_FILE_INJECTION is set, which\nit is in the gate-tempest-dsvm-neutron-full-ssh job, which makes\nfile injection (personaility) tests fail.\n\nThe history:\n\nCommit 0ae942b41c6dcd0fe7353e7d68574194fb72a66d moved installing\npython-guestfs to the hypervisor-libvirt file and it was conditional\non a flag to enable file injection and the backing distro.\n\nCommit a3c94468baa159840a47c34cf94d97d816208313 removed the ability\nto configure nova for file injection, which never made any Tempest\ntests fail because we didn\u0027t have a job that tested file injection\nwith ssh, which is what gate-tempest-dsvm-neutron-full-ssh does.\n\nCommit 6d3670a65280d71529f8aad8ca5a0422abffebd0 added the ability\nback to enable file injection and the gate-tempest-dsvm-neutron-full-ssh\njob uses it, but missed added the condition back in from 0ae942b41\nwhich installed the python-guestfs package. This change adds that\nback in.\n\nChange-Id: I1c1ef093b70007100646c086dc5724cd64751d00\nCloses-Bug: #1622649\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b2086eca1ada37f1ae31ad9eea3fb384a7d81ac0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b2086eca1ada37f1ae31ad9eea3fb384a7d81ac0"}]},"branch":"refs/heads/master"},"557248f9c9f63551b1eb1fbaaa6455f6e6d1a92f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-09-12 15:30:49.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/368919/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/19/368919/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/19/368919/2"}}},"commit":{"parents":[{"commit":"8a770cb050a5e49edba77f8e4de9076e88e3ec21","subject":"Merge \"Add thin-provisioning-tools for Cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8a770cb050a5e49edba77f8e4de9076e88e3ec21"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:23:19.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:30:46.000000000","tz":0},"subject":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue","message":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue\n\nThere is a bit of a weird history here, but the net is we\u0027re not\ninstalling python-guestfs when ENABLE_FILE_INJECTION is set, which\nit is in the gate-tempest-dsvm-neutron-full-ssh job, which makes\nfile injection (personality) tests fail.\n\nThe history:\n\nCommit 0ae942b41c6dcd0fe7353e7d68574194fb72a66d moved installing\npython-guestfs to the hypervisor-libvirt file and it was conditional\non a flag to enable file injection and the backing distro.\n\nCommit a3c94468baa159840a47c34cf94d97d816208313 removed the ability\nto configure nova for file injection, which never made any Tempest\ntests fail because we didn\u0027t have a job that tested file injection\nwith ssh, which is what gate-tempest-dsvm-neutron-full-ssh does.\n\nCommit 6d3670a65280d71529f8aad8ca5a0422abffebd0 added the ability\nback to enable file injection and the gate-tempest-dsvm-neutron-full-ssh\njob uses it, but missed added the condition back in from 0ae942b41\nwhich installed the python-guestfs package. This change adds that\nback in.\n\nChange-Id: I1c1ef093b70007100646c086dc5724cd64751d00\nCloses-Bug: #1622649\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/557248f9c9f63551b1eb1fbaaa6455f6e6d1a92f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/557248f9c9f63551b1eb1fbaaa6455f6e6d1a92f"}]},"branch":"refs/heads/master"},"6390d5ef8236028c8dc00c5514e7ceac60ffd627":{"kind":"REWORK","_number":3,"created":"2016-09-12 15:36:09.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/368919/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/19/368919/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/19/368919/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/19/368919/3"}}},"commit":{"parents":[{"commit":"8a770cb050a5e49edba77f8e4de9076e88e3ec21","subject":"Merge \"Add thin-provisioning-tools for Cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8a770cb050a5e49edba77f8e4de9076e88e3ec21"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:23:19.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-09-12 15:35:22.000000000","tz":-240},"subject":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue","message":"libvirt: install python-guestfs when ENABLE_FILE_INJECTION\u003dTrue\n\nThere is a bit of a weird history here, but the net is we\u0027re not\ninstalling python-guestfs when ENABLE_FILE_INJECTION is set, which\nit is in the gate-tempest-dsvm-neutron-full-ssh job, which makes\nfile injection (personality) tests fail.\n\nThe history:\n\nCommit 0ae942b41c6dcd0fe7353e7d68574194fb72a66d moved installing\npython-guestfs to the hypervisor-libvirt file and it was conditional\non a flag to enable file injection and the backing distro.\n\nCommit a3c94468baa159840a47c34cf94d97d816208313 removed the ability\nto configure nova for file injection, which never made any Tempest\ntests fail because we didn\u0027t have a job that tested file injection\nwith ssh, which is what gate-tempest-dsvm-neutron-full-ssh does.\n\nCommit 6d3670a65280d71529f8aad8ca5a0422abffebd0 added the ability\nback to enable file injection and the gate-tempest-dsvm-neutron-full-ssh\njob uses it, but missed added the condition back in from 0ae942b41\nwhich installed the python-guestfs package. This change adds that\nback in.\n\nChange-Id: I1c1ef093b70007100646c086dc5724cd64751d00\nCloses-Bug: #1622649\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6390d5ef8236028c8dc00c5514e7ceac60ffd627"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6390d5ef8236028c8dc00c5514e7ceac60ffd627"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}