)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b8c4cd1ac2a0db44d07fe1314c85300f270b4303","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Rosenboom \u003cj.rosenboom@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-14 19:29:01 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Work around glance ignoring domain names in config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_5f227602","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":18},"updated":"2016-09-15 03:50:50.000000000","message":"I think more accurate description will be \"glance_store swift driver\".\n\nPlease see my further notes.","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cc883a7e9a6825ac85b347675adba034e67c531f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Rosenboom \u003cj.rosenboom@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-14 19:29:01 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Work around glance ignoring domain names in config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_a36a58b1","line":7,"in_reply_to":"7a8ec9b2_5f227602","updated":"2016-09-15 18:10:51.000000000","message":"Updated the title, I think the remainder of this discussion should better happen on the bug report.","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ca3371e07b9f9f9e6cf81468879def7cf5d3731a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jens Rosenboom \u003cj.rosenboom@x-ion.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-14 19:29:01 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Work around glance ignoring domain names in config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_ff4790b9","line":7,"in_reply_to":"7a8ec9b2_a36a58b1","updated":"2016-09-15 20:31:27.000000000","message":"Cool, wfm -- I\u0027m not picky on the commit messages unless they are significant to the release.","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b8c4cd1ac2a0db44d07fe1314c85300f270b4303","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Work around glance ignoring domain names in config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"},{"line_number":11,"context_line":"client, they override any settings to user_domain_name and"},{"line_number":12,"context_line":"project_domain_name that are made in the config, leading to authentication"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_9f4a3eab","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":8},"updated":"2016-09-15 03:50:50.000000000","message":"After studying that change and the behavior we see on the bug descriptions, the issue seems to be stemming from having defaults for \"[project, user]_domain_id\".","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b8c4cd1ac2a0db44d07fe1314c85300f270b4303","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Work around glance ignoring domain names in config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"},{"line_number":11,"context_line":"client, they override any settings to user_domain_name and"},{"line_number":12,"context_line":"project_domain_name that are made in the config, leading to authentication"},{"line_number":13,"context_line":"failures."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_bfee1a89","line":11,"range":{"start_line":10,"start_character":19,"end_line":11,"end_character":7},"updated":"2016-09-15 03:50:50.000000000","message":"These are merely defaults but passed to the keystone client when there is not alternate values given in the config file.\n\nAs mentioned in the logs for tests, domain_id are not specified and default values are being sent http://logs.openstack.org/75/369675/3/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/f748e8b/logs/etc/glance/glance-swift-store.conf.txt.gz","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b8c4cd1ac2a0db44d07fe1314c85300f270b4303","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With [1] glance_store introduces default settings for user_domain_id and"},{"line_number":10,"context_line":"project_domain_id. Sadly since these are always passed to the keystone"},{"line_number":11,"context_line":"client, they override any settings to user_domain_name and"},{"line_number":12,"context_line":"project_domain_name that are made in the config, leading to authentication"},{"line_number":13,"context_line":"failures."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So as a workaround until [2] is fixed, we explictly place the corresponding"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_7fabb21d","line":12,"range":{"start_line":11,"start_character":13,"end_line":12,"end_character":19},"updated":"2016-09-15 03:50:50.000000000","message":"The domain_id will not override the domain_name values and this needs further investigation for why we do see failures.\n\nMy current hunch says that the default values for domain_id are not working out so the authentication request is only partially correct (hence a 401).\n\n\nThe workflow is as follows:\n\n1. First swift store driver checks for existence of \"glance-swift-store.conf\" file https://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/_drivers/swift/utils.py#L121\n\n2. This being true for your case, _load_config is called https://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/_drivers/swift/utils.py#L147\n\n3. Defaults are passed, when configs are read from file \n\nhttps://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/_drivers/swift/utils.py#L151\n\nand\n\nhttps://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/_drivers/swift/utils.py#L100-L107\n\n4. Config values are used here and then passed to ks client https://github.com/openstack/glance_store/blob/5736659fe0edb4c8fd4d583a77017dc8beba774b/glance_store/_drivers/swift/utils.py#L163-L173","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b8c4cd1ac2a0db44d07fe1314c85300f270b4303","unresolved":false,"context_lines":[{"line_number":12,"context_line":"project_domain_name that are made in the config, leading to authentication"},{"line_number":13,"context_line":"failures."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So as a workaround until [2] is fixed, we explictly place the corresponding"},{"line_number":16,"context_line":"domain_ids into the config."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.openstack.org/297665"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8ec9b2_7f301202","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":37},"updated":"2016-09-15 03:50:50.000000000","message":"Yes, I think this is a good workaround as it sets the values as expected.\n\nI was told that the initial request for defaults was from ansible team. So, if we remove them in a hurry it will destabilize given they must have had a setup accordingly.\n\nHowever, I\u0027m of opinion that the defaults values need to be something that all project can live with. So, we need to have some cross project convo with keystone (for what happens when *_id and *_name values clash -- best way to resolve), ansible and tempest v3 gate.\n\nIf possible, let\u0027s avoid defaults in the code and use them in the config file. That way given multiple accounts are allowed to be setup individual teams are free to setup their account specific defaults in the file.","commit_id":"a4eecd24c011ddd91d0d3f9c4bef77e27125f763"}],"lib/glance":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0a0cddb2dda0164ba7377fc091895a65b1e339d5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Keystone is not yet running at this point, so we have to delay inserting the domain_id"},{"line_number":192,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_id REPLACEME"},{"line_number":193,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_id REPLACEME"},{"line_number":194,"context_line":"        # iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_name $SERVICE_DOMAIN_NAME"},{"line_number":195,"context_line":"        # iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_name $SERVICE_DOMAIN_NAME"},{"line_number":196,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 auth_version 3"},{"line_number":197,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a8ec9b2_2473ab16","line":194,"updated":"2016-09-15 20:15:31.000000000","message":"Is there a reason we commented this out instead of deleting it? We normally try not to leave commented code around like this. If it\u0027s just to make sure it\u0027s still there when 1620999 is fixed, we can just revert this to bring back the use of $SERVICE_DOMAIN_NAME","commit_id":"61092c75c065938455d0ebf1500f6d6b9f86925d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1329184858be78eb58968081eb4f3f94d435fc3b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Keystone is not yet running at this point, so we have to delay inserting the domain_id"},{"line_number":192,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_id REPLACEME"},{"line_number":193,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_id REPLACEME"},{"line_number":194,"context_line":"        # iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_name $SERVICE_DOMAIN_NAME"},{"line_number":195,"context_line":"        # iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_name $SERVICE_DOMAIN_NAME"},{"line_number":196,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 auth_version 3"},{"line_number":197,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a8ec9b2_7c9700ec","line":194,"in_reply_to":"7a8ec9b2_2473ab16","updated":"2016-09-16 05:39:33.000000000","message":"The idea was half allowing for easier revert, half making it easier to understand to kinda strange construct, but I\u0027ve deleted them now.","commit_id":"61092c75c065938455d0ebf1500f6d6b9f86925d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7476218ac631af04b44ca0ea3709111ace5b53a5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        # Note(frickler): Crude workaround for https://bugs.launchpad.net/glance-store/+bug/1620999"},{"line_number":191,"context_line":"        # Keystone is not yet running at this point, so we have to delay inserting the domain_id"},{"line_number":192,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_id REPLACEME"},{"line_number":193,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_id REPLACEME"},{"line_number":194,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 auth_version 3"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # commenting is not strictly necessary but it\u0027s confusing to have bad values in conf"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a8bc5a2_8b91d5f3","line":193,"updated":"2016-09-26 12:42:39.000000000","message":"instead of sticking dummy values here, why aren\u0027t we just doing this later.\n\nAlso, is there a reason domain name is not being used? Having to build this off an unknown id seems odd.","commit_id":"939e9e5a2f2f90768061463df1478e59e60b2c3f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fd20d023f33805f79aa0e687d3df008d9aaf5f5b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        # Note(frickler): Crude workaround for https://bugs.launchpad.net/glance-store/+bug/1620999"},{"line_number":191,"context_line":"        # Keystone is not yet running at this point, so we have to delay inserting the domain_id"},{"line_number":192,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 user_domain_id REPLACEME"},{"line_number":193,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 project_domain_id REPLACEME"},{"line_number":194,"context_line":"        iniset $GLANCE_SWIFT_STORE_CONF ref1 auth_version 3"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # commenting is not strictly necessary but it\u0027s confusing to have bad values in conf"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a8bc5a2_7d5d2e14","line":193,"in_reply_to":"5a8bc5a2_8b91d5f3","updated":"2016-09-26 13:13:16.000000000","message":"Hmm, right, one could just do the iniset at the later stage I guess.\n\nThe domain_name is ignored within the keystoneauth library when called with both domain_name and domain_id parameter being set, see https://bugs.launchpad.net/glance-store/+bug/1620999/comments/6","commit_id":"939e9e5a2f2f90768061463df1478e59e60b2c3f"}]}