)]}'
{"lib/tempest":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb822b61aaa4e39995418c052ad468e85524afde","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port_security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a8ec9b2_d1c64099","line":391,"updated":"2016-09-16 00:43:34.000000000","message":"Why do we need this condition?\n\nIf neutron is enabled, this extension is always enabled in devstack like https://github.com/openstack-dev/devstack/blob/master/lib/neutron#L169","commit_id":"c4eae3ab744d4b79d80025470dc1cafe90628028"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d86934d68c652d96d4c24263588f34c9e004872","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port_security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a8ec9b2_c0565029","line":391,"in_reply_to":"7a8ec9b2_00df580d","updated":"2016-09-16 12:46:17.000000000","message":"Ah the extension shows up as port-security, not port_security:\n\nhttp://logs.openstack.org/27/371227/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8799e92/logs/devstacklog.txt.gz#_2016-09-16_00_48_28_392","commit_id":"c4eae3ab744d4b79d80025470dc1cafe90628028"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7843ceda5cf20efdb6885bc06fb9bbd3d42e6ff3","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port_security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a8ec9b2_00df580d","line":391,"in_reply_to":"7a8ec9b2_31ff64ab","updated":"2016-09-16 12:39:15.000000000","message":"Hmm, something isn\u0027t working with the extension check:\n\nhttp://logs.openstack.org/27/371227/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8799e92/console.html#_2016-09-16_01_24_42_177904","commit_id":"c4eae3ab744d4b79d80025470dc1cafe90628028"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"85505f24fc72de323504be80efc7b0bbe697e54f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port_security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7a8ec9b2_31ff64ab","line":391,"in_reply_to":"7a8ec9b2_d1c64099","updated":"2016-09-16 00:51:22.000000000","message":"Because we have a mechanism to check and it\u0027s better to assume it\u0027s not hard-coded, because there is a todo here for it:\n\nhttps://github.com/openstack-dev/devstack/blob/master/lib/neutron#L164\n\nAnd also:\n\nhttps://github.com/openstack-dev/devstack/blob/master/lib/neutron_plugins/ml2#L38","commit_id":"c4eae3ab744d4b79d80025470dc1cafe90628028"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"542b43765bf7a31c5cbfe2ec76150b33f1339d6b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port-security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a8ec9b2_1b81778f","line":391,"updated":"2016-09-16 20:04:36.000000000","message":"So I actually just looked behind the curtain and I don\u0027t like this because it makes an API call to make this determination. This is normally not something we want to do because if neutron lies or we make a misconfiguration that changes what we think we\u0027re testing we still pass because things silently skip.","commit_id":"af20e2824100cc65dbabf839414ad08ea93c77bc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc98bc5bebb780215e38a83c5ce1cd5c27e33786","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port-security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a8ec9b2_a1668d4e","line":391,"in_reply_to":"7a8ec9b2_1b81778f","updated":"2016-09-16 22:33:58.000000000","message":"So you want a common variable used to set this in ml2.conf and in tempest.conf, and it would just default to True?","commit_id":"af20e2824100cc65dbabf839414ad08ea93c77bc"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"09b971f0fe37e9f557a1090abc622692656ab8e4","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":391,"context_line":"    if is_networking_extension_supported \u0027port-security\u0027; then"},{"line_number":392,"context_line":"        iniset $TEMPEST_CONFIG network-feature-enabled port_security True"},{"line_number":393,"context_line":"    fi"},{"line_number":394,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a98d1f4_aa421666","line":391,"in_reply_to":"7a8ec9b2_a1668d4e","updated":"2016-09-30 19:17:34.000000000","message":"Yes that would work","commit_id":"af20e2824100cc65dbabf839414ad08ea93c77bc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9583e8415ff1e7aeaa76b44c013e96a7ca03019","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_ML2_PORT_SECURITY"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # Orchestration Tests"},{"line_number":393,"context_line":"    if is_service_enabled heat; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a98d1f4_add6a64c","line":390,"updated":"2016-10-01 01:07:01.000000000","message":"Ah this doesn\u0027t have a failure:\n\nhttp://logs.openstack.org/27/371227/3/check/gate-grenade-dsvm-neutron-ubuntu-xenial/8d2fb3b/logs/grenade.sh.txt.gz#_2016-09-30_21_57_46_374\n\niniset /opt/stack/new/tempest/etc/tempest.conf network-feature-enabled port_security\n\nSo the $NEUTRON_ML2_PORT_SECURITY variable isn\u0027t getting in here.","commit_id":"31e1ad01322aa27b6b8b9af7c820b6e2bb697897"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"98db2e2a6cdfd8dc68e2a267c83d8fec67dbdb1a","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_ML2_PORT_SECURITY"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # Orchestration Tests"},{"line_number":393,"context_line":"    if is_service_enabled heat; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a95cdbc_a8ec5bc8","line":390,"updated":"2016-10-05 06:43:05.000000000","message":"what if the plugin running is not ml2?","commit_id":"4bcb7fa58ed9e2a30f644498d60b2a73a1166f83"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"165669b10bfd0e2a1544f886bb5fab91cab755a0","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_ML2_PORT_SECURITY"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # Orchestration Tests"},{"line_number":393,"context_line":"    if is_service_enabled heat; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba5da102_e36e3d2e","line":390,"in_reply_to":"1a95cdbc_a8ec5bc8","updated":"2016-10-31 15:58:40.000000000","message":"Is your concern just around the naming of the variable? If so, I can just change it to be \u0027NEUTRON_PORT_SECURITY\u0027. The reason it has ML2 in it is because it\u0027s used to set the ml2 config in the other scripts in devstack.","commit_id":"4bcb7fa58ed9e2a30f644498d60b2a73a1166f83"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"645c7f296fb4abf397964fddd08b8ee12758adbc","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    iniset $TEMPEST_CONFIG network default_network \"$FIXED_RANGE\""},{"line_number":388,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":389,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":390,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_ML2_PORT_SECURITY"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    # Orchestration Tests"},{"line_number":393,"context_line":"    if is_service_enabled heat; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba5da102_affa4a73","line":390,"in_reply_to":"ba5da102_e36e3d2e","updated":"2016-11-01 14:43:55.000000000","message":"If possible please use NEUTRON_PORT_SECURITY","commit_id":"4bcb7fa58ed9e2a30f644498d60b2a73a1166f83"}]}