)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3d616445533268d4e03e2c41cce890d2d8215940","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Chunduru \u003cravivsn@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-16 14:46:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"blueprint quantum-fwaas-devstack"},{"line_number":8,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This commit must be merged after below Neutron patch goes through"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAARn%2F%2F4ZA%3D","line":7,"updated":"2013-08-20 18:42:40.000000000","message":"please swap lines 7 and 8 here.","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"3df9a59339c3b2d0f2eea3fcd427626836243680","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Chunduru \u003cravivsn@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-16 14:46:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"blueprint quantum-fwaas-devstack"},{"line_number":8,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This commit must be merged after below Neutron patch goes through"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAARn%2F%2FzpE%3D","line":7,"in_reply_to":"AAAARn%2F%2F4ZA%3D","updated":"2013-08-21 17:52:19.000000000","message":"Done","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"30f3fc4377545002957c11173ea6ec3ca46d0059","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This commit must be merged after below Neutron patch goes through"},{"line_number":11,"context_line":"https://review.openstack.org/#/c/34074/"},{"line_number":12,"context_line":"Change-Id: I3c546433415ab18a5933a25774a06df7c4cb42e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAARn%2F%2F4Vk%3D","line":11,"updated":"2013-08-20 18:58:37.000000000","message":"please also drop the above two lines","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"3df9a59339c3b2d0f2eea3fcd427626836243680","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This commit must be merged after below Neutron patch goes through"},{"line_number":11,"context_line":"https://review.openstack.org/#/c/34074/"},{"line_number":12,"context_line":"Change-Id: I3c546433415ab18a5933a25774a06df7c4cb42e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAARn%2F%2FzpA%3D","line":11,"in_reply_to":"AAAARn%2F%2F4Vk%3D","updated":"2013-08-21 17:52:19.000000000","message":"Done","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"540a5103acba725349588705fb4b5a4c9bf1bcb6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Chunduru \u003cravivsn@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-16 20:40:12 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":8,"context_line":"blueprint quantum-fwaas-devstack"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I3c546433415ab18a5933a25774a06df7c4cb42e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAARn%2F%2FwUM%3D","line":7,"updated":"2013-08-22 08:30:40.000000000","message":"please add a new line after this","commit_id":"93a9eb1ccca2ab1a9015ec053bb9974a69db00f0"},{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"43f0235351f81611e9636cf776dc56264b642a59","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Chunduru \u003cravivsn@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-16 20:40:12 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for Openstack Networking FWaaS (Firewall)"},{"line_number":8,"context_line":"blueprint quantum-fwaas-devstack"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I3c546433415ab18a5933a25774a06df7c4cb42e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAARn%2F%2FuXU%3D","line":7,"in_reply_to":"AAAARn%2F%2FwUM%3D","updated":"2013-08-22 17:28:28.000000000","message":"Done\nseems it needs double lines.","commit_id":"93a9eb1ccca2ab1a9015ec053bb9974a69db00f0"}],"lib/horizon":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"7e03508e9fa4fd9666e7bc3f988a067f6b8914d0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # enable firewall dashboard in case service is enabled"},{"line_number":100,"context_line":"    if is_service_enabled q-fwaas; then"},{"line_number":101,"context_line":"        _horizon_config_set $local_settings OPENSTACK_NEUTRON_NETWORK enable_fw True"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    # Initialize the horizon database (it stores sessions and notices shown to"},{"line_number":105,"context_line":"    # users).  The user system is external (keystone)."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAARn%2F%2F8CY%3D","line":102,"updated":"2013-08-19 23:37:33.000000000","message":"I believe this is not consistent with the current horizon patch. It uses \"enable_firewall\" which should be replaced.\n\nAlso, running the devstack patch is currently setting this to:\nn    \u0027enable_fw\u0027: True,\n\n(note the spurious character) and that breaks horizon. I think you probably just want to set:\n     \u0027enable_firewall\u0027: True","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"1acca4122338b6489f29d4e1d2a398b2e95e6e52","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # enable firewall dashboard in case service is enabled"},{"line_number":100,"context_line":"    if is_service_enabled q-fwaas; then"},{"line_number":101,"context_line":"        _horizon_config_set $local_settings OPENSTACK_NEUTRON_NETWORK enable_fw True"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    # Initialize the horizon database (it stores sessions and notices shown to"},{"line_number":105,"context_line":"    # users).  The user system is external (keystone)."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAARn%2F%2F4bI%3D","line":102,"in_reply_to":"AAAARn%2F%2F8CY%3D","updated":"2013-08-20 18:29:08.000000000","message":"There is a bug in lib/horizon , hence we see character \u0027n\u0027 when the option for neutron service does not exist in local_settings.py.example.\nFixed it, will update the patch.","commit_id":"f2d42c55e482126eeedfe167bcb3bc22f6bdff00"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d528d070479a7427b3bb735fa0fb867f7c914bf1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if [ -n \"$line\" ]; then"},{"line_number":51,"context_line":"            sed -i -e \"/^$section/,/^}/ s/^\\( *\u0027$option\u0027\\) *:.*$/\\1: $value,/\" $file"},{"line_number":52,"context_line":"        else"},{"line_number":53,"context_line":"            sed -i -e \"/^$section/a\\    \u0027$option\u0027: $value,\" $file"},{"line_number":54,"context_line":"        fi"},{"line_number":55,"context_line":"    else"},{"line_number":56,"context_line":"        echo -e \"\\n\\n$section \u003d {\\n    \u0027$option\u0027: $value,\\n}\" \u003e\u003e $file"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAASX%2F%2F6hQ%3D","line":53,"updated":"2013-08-23 19:49:37.000000000","message":"is this related to the patch?","commit_id":"95c93e2b54ff0dcb5d7a4dd0f7f78e21c789f511"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"8352e62b17310fed20a7c99ea1b475b30106e178","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if [ -n \"$line\" ]; then"},{"line_number":51,"context_line":"            sed -i -e \"/^$section/,/^}/ s/^\\( *\u0027$option\u0027\\) *:.*$/\\1: $value,/\" $file"},{"line_number":52,"context_line":"        else"},{"line_number":53,"context_line":"            sed -i -e \"/^$section/a\\    \u0027$option\u0027: $value,\" $file"},{"line_number":54,"context_line":"        fi"},{"line_number":55,"context_line":"    else"},{"line_number":56,"context_line":"        echo -e \"\\n\\n$section \u003d {\\n    \u0027$option\u0027: $value,\\n}\" \u003e\u003e $file"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAASX%2F%2F4F8%3D","line":53,"in_reply_to":"AAAASX%2F%2F4Hw%3D","updated":"2013-08-25 08:49:54.000000000","message":"As I understand it, fixing this line of code is related to this patch. If it\u0027s not fixed, it does not configure the Horizon config file correctly (please see my comments in the earlier patch sets). What is open for review is whether this proposed fix is correct.","commit_id":"95c93e2b54ff0dcb5d7a4dd0f7f78e21c789f511"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"01526130420aa860a2ee06fe34441c5878510479","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if [ -n \"$line\" ]; then"},{"line_number":51,"context_line":"            sed -i -e \"/^$section/,/^}/ s/^\\( *\u0027$option\u0027\\) *:.*$/\\1: $value,/\" $file"},{"line_number":52,"context_line":"        else"},{"line_number":53,"context_line":"            sed -i -e \"/^$section/a\\    \u0027$option\u0027: $value,\" $file"},{"line_number":54,"context_line":"        fi"},{"line_number":55,"context_line":"    else"},{"line_number":56,"context_line":"        echo -e \"\\n\\n$section \u003d {\\n    \u0027$option\u0027: $value,\\n}\" \u003e\u003e $file"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAASX%2F%2F4Hw%3D","line":53,"in_reply_to":"AAAASX%2F%2F6Wk%3D","updated":"2013-08-25 08:14:35.000000000","message":"I think that it would be best to have a separate patch for this as it is not related to the FWaaS patch. Sorry for being pedantic","commit_id":"95c93e2b54ff0dcb5d7a4dd0f7f78e21c789f511"},{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"change_message_id":"2130ebf07b3047f1adc0ab137b708c2cb31ee516","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if [ -n \"$line\" ]; then"},{"line_number":51,"context_line":"            sed -i -e \"/^$section/,/^}/ s/^\\( *\u0027$option\u0027\\) *:.*$/\\1: $value,/\" $file"},{"line_number":52,"context_line":"        else"},{"line_number":53,"context_line":"            sed -i -e \"/^$section/a\\    \u0027$option\u0027: $value,\" $file"},{"line_number":54,"context_line":"        fi"},{"line_number":55,"context_line":"    else"},{"line_number":56,"context_line":"        echo -e \"\\n\\n$section \u003d {\\n    \u0027$option\u0027: $value,\\n}\" \u003e\u003e $file"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"AAAASX%2F%2F6Wk%3D","line":53,"in_reply_to":"AAAASX%2F%2F6hQ%3D","updated":"2013-08-23 20:39:43.000000000","message":"there was a bug in that line. It was adding character \u0027n\u0027 at the start of the line and also adding additional line for new option(for the options that are not present in the example file).","commit_id":"95c93e2b54ff0dcb5d7a4dd0f7f78e21c789f511"}],"lib/neutron":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ec99b3e02cbbac09c658726f9d344f770343e97c","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        Q_FWAAS_CONF_FILE\u003d$NEUTRON_CONF_DIR/fwaas_driver.ini"},{"line_number":568,"context_line":"    fi"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    cp $NEUTRON_DIR/etc/l3_agent.ini $Q_L3_CONF_FILE"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    iniset $Q_L3_CONF_FILE DEFAULT verbose True"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAQn%2F%2F41I%3D","line":570,"updated":"2013-07-19 19:14:56.000000000","message":"nit, one space only please","commit_id":"a31e539dc4b981ecf6e1994033ec204b7a51376c"}],"lib/neutron_plugins/services/firewall":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"424fe3989d69fbc18adb22919416e59e56b70925","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function neutron_fwaas_configure_driver() {"},{"line_number":20,"context_line":"    FWAAS_DRIVER_CONF_FILENAME\u003d/etc/neutron/fwaas_driver.ini"},{"line_number":21,"context_line":"    rm -f $FWAAS_DRIVEr_CONF_FILENAME"},{"line_number":22,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas_driver fwaas_driver \"neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\""},{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Restore xtrace"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAQn%2F%2F%2B4M%3D","line":22,"updated":"2013-07-18 01:56:47.000000000","message":"the section names and the conf names have changed. You can find the latest ini file here:\n\nhttps://review.openstack.org/#/c/34064/22/etc/fwaas_driver.ini\n\nIt looks like this:\n\n[fwaas]\n\ndriver \u003d neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver","commit_id":"3e0067d9880d1427ad0177859154e1de1a5bb75d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"144f80f55d52be77266f14f1612ddd3687404127","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function neutron_fwaas_configure_driver() {"},{"line_number":20,"context_line":"    FWAAS_DRIVER_CONF_FILENAME\u003d/etc/neutron/fwaas_driver.ini"},{"line_number":21,"context_line":"    rm -f $FWAAS_DRIVER_CONF_FILENAME"},{"line_number":22,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas driver \"neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\""},{"line_number":23,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas enabled True"},{"line_number":24,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAQn%2F%2FnuY%3D","line":21,"updated":"2013-07-26 11:19:10.000000000","message":"why delete the file?","commit_id":"8c02d4165eecf7f62447be64238d2b9fb57e2be5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4c5d66bde302fe53fb6aa4465244aa3279e76740","unresolved":false,"context_lines":[{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function neutron_fwaas_configure_driver() {"},{"line_number":20,"context_line":"    FWAAS_DRIVER_CONF_FILENAME\u003d/etc/neutron/fwaas_driver.ini"},{"line_number":21,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas driver \"neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\""},{"line_number":22,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas enabled True"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAARX%2F%2F%2FbY%3D","line":20,"updated":"2013-08-18 18:06:28.000000000","message":"When is the file copied from neutron code base to the /etc/neutron dir?\nFor example, for the l3 agent we have: cp $NEUTRON_DIR/etc/l3_agent.ini $Q_L3_CONF_FILE\nDid I miss the copy for this file?","commit_id":"a9cb90380ed9570152656e74788bd79f6497d151"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"29f347195ad0d9b2313c907d3722567521004389","unresolved":false,"context_lines":[{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function neutron_fwaas_configure_driver() {"},{"line_number":20,"context_line":"    FWAAS_DRIVER_CONF_FILENAME\u003d/etc/neutron/fwaas_driver.ini"},{"line_number":21,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas driver \"neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\""},{"line_number":22,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas enabled True"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAARn%2F%2F9OY%3D","line":20,"in_reply_to":"AAAARX%2F%2F%2FbY%3D","updated":"2013-08-19 18:22:19.000000000","message":"I believe we are not copying since there are only two config values both of which are being set here. Perhaps copying it over is a good idea nevertheless for any defaults that might get added later to the config file in the code base?","commit_id":"a9cb90380ed9570152656e74788bd79f6497d151"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c895c9defa8fc6d3d17621fc4334c430d60903a1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"function neutron_fwaas_configure_driver() {"},{"line_number":20,"context_line":"    FWAAS_DRIVER_CONF_FILENAME\u003d/etc/neutron/fwaas_driver.ini"},{"line_number":21,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas driver \"neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\""},{"line_number":22,"context_line":"    iniset_multiline $FWAAS_DRIVER_CONF_FILENAME fwaas enabled True"},{"line_number":23,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAARn%2F%2F9D4%3D","line":20,"in_reply_to":"AAAARn%2F%2F9OY%3D","updated":"2013-08-19 19:07:48.000000000","message":"Sumit, I think that is a good idea and is consistent with other config files and developers likely expectations.","commit_id":"a9cb90380ed9570152656e74788bd79f6497d151"}]}