)]}'
{"functions":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"34fe0517ae0e1030f7ac999af08f55c613eb2f2e","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    sudo modprobe bridge"},{"line_number":655,"context_line":"    # For newer kernels (3.18+), those sysctl settings are split into a separate"},{"line_number":656,"context_line":"    # kernel module (br_netfilter). Load it too, if present."},{"line_number":657,"context_line":"    sudo modprobe br_netfilter || true"},{"line_number":658,"context_line":"    # Enable bridge firewalling in case it\u0027s disabled in kernel (upstream"},{"line_number":659,"context_line":"    # default is enabled, but some distributions may decide to change it)."},{"line_number":660,"context_line":"    # This is at least needed for RHEL 7.2 and earlier releases."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3a98d1f4_5b87fcd6","line":657,"range":{"start_line":657,"start_character":4,"end_line":657,"end_character":38},"updated":"2016-09-29 13:50:35.000000000","message":"If this is not present, it\u0027s gonna produce an error message with \"FATAL\" word in it. Printing it logs can be missleading. How about:\n\n sudo modprobe br_netfilter 2\u003e\u003e /dev/null || :","commit_id":"0444518504495973f326ccee16abc6d609142830"}],"lib/neutron":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e187f42adb52c4b9fa988c00544f4145b14c8760","unresolved":false,"context_lines":[{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# configure_neutron() - Set config files, create data dirs, etc"},{"line_number":111,"context_line":"function configure_neutron_new {"},{"line_number":112,"context_line":"    sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa6399be_3522aba3","line":111,"updated":"2016-10-17 00:12:01.000000000","message":"so this is only in the configure_neutron_new cmd, which only works when the \"q-*\" services are *not* enabled ... i.e. not in our gate tests.\n\ni.e. it needs to be called in probably just \"configure_neutron\".\n\nthen again, it might just go in fixup_stuff.sh; i\u0027m not too fussed.\n\nbut at any rate, it isn\u0027t running in the gate with this change (worth double checking in the logs)","commit_id":"0c30b5a053f68c2c05ee4af3fb785325f48f2cb1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8c12f9f82978bd4e98348c3286787883e02cd16b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# configure_neutron() - Set config files, create data dirs, etc"},{"line_number":111,"context_line":"function configure_neutron_new {"},{"line_number":112,"context_line":"    sudo install -d -o $STACK_USER $NEUTRON_CONF_DIR"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa6399be_ff10095b","line":111,"in_reply_to":"fa6399be_3522aba3","updated":"2016-10-17 08:41:09.000000000","message":"Since I need to enable the kernel module only when lb agent or ovs agent is used, and only when security groups are enabled, I can\u0027t put it into configure_neutron.\n\nI updated the relevant bits in lib/neutron_plugins to enable the kernel firewall for both agents in the next PS.","commit_id":"0c30b5a053f68c2c05ee4af3fb785325f48f2cb1"}],"lib/nova":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"de7cfc20e4b14b658ad2074dd1a1ed6c3cf8a66a","unresolved":false,"context_lines":[{"line_number":866,"context_line":"    run_process n-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $compute_cell_conf\""},{"line_number":867,"context_line":"    run_process n-cell-region \"$NOVA_BIN_DIR/nova-cells --config-file $api_cell_conf\""},{"line_number":868,"context_line":"    run_process n-cell-child \"$NOVA_BIN_DIR/nova-cells --config-file $compute_cell_conf\""},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    run_process n-crt \"$NOVA_BIN_DIR/nova-cert --config-file $api_cell_conf\""},{"line_number":871,"context_line":"    run_process n-net \"$NOVA_BIN_DIR/nova-network --config-file $compute_cell_conf\""},{"line_number":872,"context_line":"    run_process n-sch \"$NOVA_BIN_DIR/nova-scheduler --config-file $compute_cell_conf\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a98d1f4_e9600538","side":"PARENT","line":869,"updated":"2016-09-29 13:36:03.000000000","message":"nit: unrelated","commit_id":"ced511c593c68764d007f8b559099d353bae6f45"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"de7cfc20e4b14b658ad2074dd1a1ed6c3cf8a66a","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        enable_kernel_bridge_firewall"},{"line_number":873,"context_line":"    fi"},{"line_number":874,"context_line":"    run_process n-net \"$NOVA_BIN_DIR/nova-network --config-file $compute_cell_conf\""},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    run_process n-sch \"$NOVA_BIN_DIR/nova-scheduler --config-file $compute_cell_conf\""},{"line_number":877,"context_line":"    run_process n-api-meta \"$NOVA_BIN_DIR/nova-api-metadata --config-file $compute_cell_conf\""},{"line_number":878,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a98d1f4_295bcd88","line":875,"updated":"2016-09-29 13:36:03.000000000","message":"nit: unrelated","commit_id":"8e03df17aef6fa69a12bb28c01ec160fbb6f0c4f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddfb114234a16c3675d35cbbbcc89a5e7f05fb62","unresolved":false,"context_lines":[{"line_number":872,"context_line":"        enable_kernel_bridge_firewall"},{"line_number":873,"context_line":"    fi"},{"line_number":874,"context_line":"    run_process n-net \"$NOVA_BIN_DIR/nova-network --config-file $compute_cell_conf\""},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"    run_process n-sch \"$NOVA_BIN_DIR/nova-scheduler --config-file $compute_cell_conf\""},{"line_number":877,"context_line":"    run_process n-api-meta \"$NOVA_BIN_DIR/nova-api-metadata --config-file $compute_cell_conf\""},{"line_number":878,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a98d1f4_5b729cae","line":875,"in_reply_to":"3a98d1f4_295bcd88","updated":"2016-09-29 13:40:41.000000000","message":"It is, I split n-net piece into a separate subsection for easier readability.","commit_id":"8e03df17aef6fa69a12bb28c01ec160fbb6f0c4f"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dfce3f08752bbf5ce5764cfa6f6565ad9e518b14","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# kernel module (br_netfilter). Load it too, if present."},{"line_number":170,"context_line":"sudo modprobe br_netfilter || true"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"if is_fedora; then"},{"line_number":173,"context_line":"    for proto in arp ip ip6; do"},{"line_number":174,"context_line":"        sudo sysctl -w net.bridge.bridge-nf-call-$(proto)tables\u003d1"},{"line_number":175,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a98d1f4_303a90ce","line":172,"updated":"2016-09-28 13:29:12.000000000","message":"why only fedora? I mean, it shall be of no harm to other systems which override this by default, as it\u0027s an idempotent change.","commit_id":"cd566aac3be18168548cabee2a468c9686c73948"}]}