)]}'
{"lib/neutron_plugins/openvswitch_agent":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"14984493c75ff9de3574d6a521267359c73804e0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs integration_bridge $XEN_INTEGRATION_BRIDGE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_3d6a3081","line":99,"updated":"2016-09-23 02:21:52.000000000","message":"3- \u003d\u003e 3?","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3fe1887410cf129e4ba96b5c9602f920d7261210","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs integration_bridge $XEN_INTEGRATION_BRIDGE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_e0e358d7","line":99,"in_reply_to":"5a8bc5a2_3d6a3081","updated":"2016-09-26 12:27:07.000000000","message":"Agreed.  3- might work but only if there really is never anything after the IP (e.g. an address of http://host/path/subpath would break things - although XAPI currently doesn\u0027t support that)","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"179e864b8cf85b28846dd101afea98e2ac9a2383","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs integration_bridge $XEN_INTEGRATION_BRIDGE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_93fc86b9","line":99,"in_reply_to":"5a8bc5a2_3d6a3081","updated":"2016-09-27 01:20:51.000000000","message":"sure, will change it","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"bf5b0f531e3daf8f14cb528a1e9e250fb1efa7a5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs integration_bridge $XEN_INTEGRATION_BRIDGE"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_93500734","line":99,"in_reply_to":"5a8bc5a2_e0e358d7","updated":"2016-09-27 01:18:56.000000000","message":"I see, will change this","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"14984493c75ff9de3574d6a521267359c73804e0","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"},{"line_number":103,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_dde78c10","line":100,"updated":"2016-09-23 02:21:52.000000000","message":"could we put the definition of the port# at a common central place instead of hardcoding at different places?","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"179e864b8cf85b28846dd101afea98e2ac9a2383","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Set OVS native interface for ovs-agent in compute node"},{"line_number":99,"context_line":"        XEN_DOM0_IP\u003d$(echo \"$XENAPI_CONNECTION_URL\" | cut -d \"/\" -f 3-)"},{"line_number":100,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs ovsdb_connection tcp:$XEN_DOM0_IP:6640"},{"line_number":101,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_address $HOST_IP"},{"line_number":102,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE ovs of_listen_port 6633"},{"line_number":103,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_7328da33","line":100,"in_reply_to":"5a8bc5a2_dde78c10","updated":"2016-09-27 01:20:51.000000000","message":"It\u0027s good suggestion, I see what you mean, but the port 6640 and 6633 are the default value for using ovs native interface, and we can see devstack by default will deploy ovs-agent with ovs native interface, but it didn\u0027t define these ports as they all have default value. We need to explict ovsdb_connection mainly to set the correct IP.\nAlso, these values can be override by use if they want, they can use local.conf [post-config] to override these","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"}],"lib/nova_plugins/hypervisor-xenserver":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3fe1887410cf129e4ba96b5c9602f920d7261210","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # Remove restriction on linux bridge in Dom0 when neutron is enabled"},{"line_number":94,"context_line":"    if is_service_enabled neutron; then"},{"line_number":95,"context_line":"        $ssh_dom0 \"rm -f /etc/modprobe.d/blacklist-bridge*\""},{"line_number":96,"context_line":"        $ssh_dom0 \"/usr/sbin/iptables -t filter -I RH-Firewall-1-INPUT -p tcp --dport 6640 -j ACCEPT\""},{"line_number":97,"context_line":"    fi"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_000a0479","line":96,"updated":"2016-09-26 12:27:07.000000000","message":"The blacklist bridge change is also in https://review.openstack.org/#/c/372960/3/lib/nova_plugins/hypervisor-xenserver; is it needed in both, or should we have it in a common parent change?\n\n\nSee also comment in that change for how we should improve this","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"bf5b0f531e3daf8f14cb528a1e9e250fb1efa7a5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # Remove restriction on linux bridge in Dom0 when neutron is enabled"},{"line_number":94,"context_line":"    if is_service_enabled neutron; then"},{"line_number":95,"context_line":"        $ssh_dom0 \"rm -f /etc/modprobe.d/blacklist-bridge*\""},{"line_number":96,"context_line":"        $ssh_dom0 \"/usr/sbin/iptables -t filter -I RH-Firewall-1-INPUT -p tcp --dport 6640 -j ACCEPT\""},{"line_number":97,"context_line":"    fi"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a8bc5a2_9369e7fb","line":96,"in_reply_to":"5a8bc5a2_000a0479","updated":"2016-09-27 01:18:56.000000000","message":"Yes, remove blacklist-bridge is common as long as we use neutron, because we will create linux bridge. I will create a new patch for the common part","commit_id":"3b9ede2099c4f55cab9031a149e3426a456ccd5b"}]}