)]}'
{"id":"openstack%2Fdevstack~37447","triplet_id":"openstack%2Fdevstack~master~Icf08409c9443ec703e5f1da4531aa34c326f3642","project":"openstack/devstack","branch":"master","topic":"swift-acc","hashtags":[],"change_id":"Icf08409c9443ec703e5f1da4531aa34c326f3642","subject":"Only create swift account if swift enabled","status":"MERGED","created":"2013-07-17 11:05:07.000000000","updated":"2013-07-17 17:33:07.000000000","submitted":"2013-07-17 17:33:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b74ae0a817212bf40ae370f68acd9de395fe9ff6","_number":37447,"virtual_id_number":37447,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-07-17 17:33:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"all":[{"value":0,"date":"2013-07-17 15:42:09.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-17 11:39:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":2,"date":"2013-07-17 16:46:37.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":2,"date":"2013-07-17 15:41:11.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"date":"2013-07-17 11:06:02.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-17 11:06:21.000000000","_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":1,"date":"2013-07-17 16:46:37.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-07-17 11:06:14.000000000","_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"date":"2013-07-17 11:06:27.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-17 11:06:02.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-07-17 11:06:14.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2013-07-17 11:06:21.000000000","updated_by":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"reviewer":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"state":"REVIEWER"},{"updated":"2013-07-17 11:06:27.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-07-17 16:46:37.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-07-17 17:33:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"108d2780a779a9daed3cf22511e35699399647e4","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-07-17 11:33:41.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\ntks fixing this up.","accounts_in_message":[],"_revision_number":1},{"id":"c9a322d482e2c18939c853f87424a152920b4100","author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"date":"2013-07-17 11:39:30.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4ca4426c0584379086c0ad3d09d2d01b2405305c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-17 11:54:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/37447/1/check/gate-tempest-devstack-vm-full/33108 : SUCCESS in 44m 51s\n- http://logs.openstack.org/37447/1/check/gate-tempest-devstack-vm-cells-full/937 : FAILURE in 15m 17s (non-voting)\n- http://logs.openstack.org/37447/1/check/gate-tempest-devstack-vm-postgres-full/32798 : SUCCESS in 49m 29s\n- http://logs.openstack.org/37447/1/check/gate-tempest-devstack-vm-neutron/4729 : SUCCESS in 17m 18s (non-voting)\n- http://logs.openstack.org/37447/1/check/gate-grenade-devstack-vm/18947 : SUCCESS in 21m 11s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"1d621bb04d7febbafabfdd4136e2ddaab6bec55d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-17 12:25:02.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\ncan we tuck this into create_swift_accounts itself. We\u0027re going to get lots of conditionals in here otherwise.","accounts_in_message":[],"_revision_number":1},{"id":"5ca317d5f52b96d8c828d8492233ab5650e9fc73","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-17 15:40:25.000000000","message":"Patch Set 1: (1 inline comment)\n\nSean, I\u0027d actually prefer to have these checks in stack.sh to help show the service dependencies there.  The create_swift_accounts() call could be moved down to where init_swift() is called too, with a check for keystone.\n\nI have been thinking we should group more of the service stuff together, similar to a grenade-style of startup where, for example, all the swift bits are together and its dependencies are all there, as in keystone in this instance.","accounts_in_message":[],"_revision_number":1},{"id":"517d13c26b0a4daff134a8f7190f4ec39688dd64","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-17 15:41:11.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nok, if you want it at this layer, I\u0027m good with it.","accounts_in_message":[],"_revision_number":1},{"id":"42d3e18001e53c98a3247d120ebd534f5d022b73","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-07-17 15:42:09.000000000","message":"Patch Set 1: No score\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"51f14b148ba8a7c5d8f87bab38bc5f185bd3fb1d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-17 16:46:37.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e47501b5c24a0a002b9694728d17a2f7bea4595b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-17 16:46:38.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4b63687059fd86e6d7456796636be48c692bab49","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-17 17:33:07.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/37447/1/gate/gate-tempest-devstack-vm-full/33222 : SUCCESS in 45m 17s\n- http://logs.openstack.org/37447/1/gate/gate-tempest-devstack-vm-postgres-full/32912 : SUCCESS in 46m 23s\n- http://logs.openstack.org/37447/1/gate/gate-tempest-devstack-vm-neutron/4858 : SUCCESS in 17m 57s (non-voting)\n- http://logs.openstack.org/37447/1/gate/gate-grenade-devstack-vm/19053 : SUCCESS in 21m 19s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"12ebdd8d722e254498db2a2d2bf0899348cf56b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-17 17:33:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0ff314c01dc1184fc443a85f4110615f32ec8d90","revisions":{"0ff314c01dc1184fc443a85f4110615f32ec8d90":{"kind":"REWORK","_number":1,"created":"2013-07-17 11:05:07.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/47/37447/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/47/37447/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/37447/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/37447/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/37447/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/47/37447/1"}}},"commit":{"parents":[{"commit":"7ad51b4a473ae464ca10bfac8aa6a6461a7c70cb","subject":"Merge \"Do not install mysql if mariadb is installed on openSUSE\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7ad51b4a473ae464ca10bfac8aa6a6461a7c70cb"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2013-07-17 06:30:19.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2013-07-17 11:01:43.000000000","tz":600},"subject":"Only create swift account if swift enabled","message":"Only create swift account if swift enabled\n\nOnly call the swift account creation function if swift is enabled,\notherwise the endpoints are created in keystone even though swift\nisn\u0027t running.\n\nThis causes failures when tempest queries keystone and thinks swift is\nthere; it starts running tests against it that fail with unhelpful\n\"connection refused\" errors.\n\nChange-Id: Icf08409c9443ec703e5f1da4531aa34c326f3642\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0ff314c01dc1184fc443a85f4110615f32ec8d90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0ff314c01dc1184fc443a85f4110615f32ec8d90"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}