)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"16b8c8ce361289150e3f60ac0092f1cb338c2613","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# Subnetpool defaults"},{"line_number":83,"context_line":"SUBNETPOOL_NAME\u003d${SUBNETPOOL_NAME:-\"shared-default-subnetpool\"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"SUBNETPOOL_PREFIX_V4\u003d${SUBNETPOOL_PREFIX_V4:-$FIXED_RANGE}"},{"line_number":86,"context_line":"SUBNETPOOL_PREFIX_V6\u003d${SUBNETPOOL_PREFIX_V6:-$FIXED_RANGE_V6}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"SUBNETPOOL_SIZE_V4\u003d${SUBNETPOOL_SIZE_V4:-24}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a98d1f4_ef571b00","line":85,"updated":"2016-09-29 16:03:40.000000000","message":"The default FIXED_RANGE is 10.0.0.0/24 so you would get a pool with just one subnet, which may not be what people expect. Could be fixed by changing the default to some larger net, like maybe the devstack-gate default of 10.1.0.0/20. Or you change the default SUBNETPOOL_SIZE_V4 below to maybe /26, so you would be able to squeeze four subnets out of the default.","commit_id":"69a59f2f373dbc6f7556d162dfed665a5ac2811a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"16b8c8ce361289150e3f60ac0092f1cb338c2613","unresolved":false,"context_lines":[{"line_number":83,"context_line":"SUBNETPOOL_NAME\u003d${SUBNETPOOL_NAME:-\"shared-default-subnetpool\"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"SUBNETPOOL_PREFIX_V4\u003d${SUBNETPOOL_PREFIX_V4:-$FIXED_RANGE}"},{"line_number":86,"context_line":"SUBNETPOOL_PREFIX_V6\u003d${SUBNETPOOL_PREFIX_V6:-$FIXED_RANGE_V6}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"SUBNETPOOL_SIZE_V4\u003d${SUBNETPOOL_SIZE_V4:-24}"},{"line_number":89,"context_line":"SUBNETPOOL_SIZE_V6\u003d${SUBNETPOOL_SIZE_V6:-64}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a98d1f4_6f630bdd","line":86,"updated":"2016-09-29 16:03:40.000000000","message":"A similar note applies here, though changing the default FIXED_RANGE_V6 to be a /56 instead of /64 should be pretty uncontroversial.","commit_id":"69a59f2f373dbc6f7556d162dfed665a5ac2811a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6096e86d853bd16ce11d3f58114a99f7cafe9cf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"SUBNETPOOL_PREFIX_V4\u003d${SUBNETPOOL_PREFIX_V4:-10.0.0.0/8}"},{"line_number":86,"context_line":"SUBNETPOOL_PREFIX_V6\u003d${SUBNETPOOL_PREFIX_V6:-2001:db8:8000::/48}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"SUBNETPOOL_SIZE_V4\u003d${SUBNETPOOL_SIZE_V4:-24}"},{"line_number":89,"context_line":"SUBNETPOOL_SIZE_V6\u003d${SUBNETPOOL_SIZE_V6:-64}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"default_v4_route_devs\u003d$(ip -4 route | grep ^default | awk \u0027{print $5}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a98d1f4_06121709","side":"PARENT","line":88,"updated":"2016-10-01 07:21:08.000000000","message":"Clark mentioned that some test jobs may need a private network larger than a /24, so you will still need to tweak this parameter too. Otherwise with current devstack-gate settings you would only get 10.1.0.0/24 as default private network.","commit_id":"ced511c593c68764d007f8b559099d353bae6f45"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"13f3389c03fc6319e5b28c7e8abf574445bae2fb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"SUBNETPOOL_PREFIX_V4\u003d${SUBNETPOOL_PREFIX_V4:-10.0.0.0/8}"},{"line_number":86,"context_line":"SUBNETPOOL_PREFIX_V6\u003d${SUBNETPOOL_PREFIX_V6:-2001:db8:8000::/48}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"SUBNETPOOL_SIZE_V4\u003d${SUBNETPOOL_SIZE_V4:-24}"},{"line_number":89,"context_line":"SUBNETPOOL_SIZE_V6\u003d${SUBNETPOOL_SIZE_V6:-64}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"default_v4_route_devs\u003d$(ip -4 route | grep ^default | awk \u0027{print $5}\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_fa6fec8f","side":"PARENT","line":88,"in_reply_to":"3a98d1f4_06121709","updated":"2016-10-12 00:23:06.000000000","message":"A test that needs a large subnet should specify its own size instead of taking the default. This is just a default size, right?","commit_id":"ced511c593c68764d007f8b559099d353bae6f45"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6096e86d853bd16ce11d3f58114a99f7cafe9cf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IPV6_ADDRESS_MODE\u003d${IPV6_ADDRESS_MODE:-slaac}"},{"line_number":68,"context_line":"IPV6_PUBLIC_SUBNET_NAME\u003d${IPV6_PUBLIC_SUBNET_NAME:-ipv6-public-subnet}"},{"line_number":69,"context_line":"IPV6_PRIVATE_SUBNET_NAME\u003d${IPV6_PRIVATE_SUBNET_NAME:-ipv6-private-subnet}"},{"line_number":70,"context_line":"FIXED_RANGE_V6\u003d${FIXED_RANGE_V6:-fd$IPV6_GLOBAL_ID::/56}"},{"line_number":71,"context_line":"IPV6_PRIVATE_NETWORK_GATEWAY\u003d${IPV6_PRIVATE_NETWORK_GATEWAY:-}"},{"line_number":72,"context_line":"IPV6_PUBLIC_RANGE\u003d${IPV6_PUBLIC_RANGE:-2001:db8::/64}"},{"line_number":73,"context_line":"IPV6_PUBLIC_NETWORK_GATEWAY\u003d${IPV6_PUBLIC_NETWORK_GATEWAY:-2001:db8::2}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a98d1f4_c60bcfd4","line":70,"updated":"2016-10-01 07:21:08.000000000","message":"My concern still stands that if this variable should still be used anywhere with the original intention of directly creating a subnet from it, then having a /56 subnet will deviate from the standard of using a /64 for directly connected subnets and may cause all kinds of unexpected complications.","commit_id":"7dec9a64ab7f180fb960edeb669be2eb3f394213"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"13f3389c03fc6319e5b28c7e8abf574445bae2fb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"IPV6_ADDRESS_MODE\u003d${IPV6_ADDRESS_MODE:-slaac}"},{"line_number":68,"context_line":"IPV6_PUBLIC_SUBNET_NAME\u003d${IPV6_PUBLIC_SUBNET_NAME:-ipv6-public-subnet}"},{"line_number":69,"context_line":"IPV6_PRIVATE_SUBNET_NAME\u003d${IPV6_PRIVATE_SUBNET_NAME:-ipv6-private-subnet}"},{"line_number":70,"context_line":"FIXED_RANGE_V6\u003d${FIXED_RANGE_V6:-fd$IPV6_GLOBAL_ID::/56}"},{"line_number":71,"context_line":"IPV6_PRIVATE_NETWORK_GATEWAY\u003d${IPV6_PRIVATE_NETWORK_GATEWAY:-}"},{"line_number":72,"context_line":"IPV6_PUBLIC_RANGE\u003d${IPV6_PUBLIC_RANGE:-2001:db8::/64}"},{"line_number":73,"context_line":"IPV6_PUBLIC_NETWORK_GATEWAY\u003d${IPV6_PUBLIC_NETWORK_GATEWAY:-2001:db8::2}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_7a3cbc93","line":70,"in_reply_to":"3a98d1f4_c60bcfd4","updated":"2016-10-12 00:23:06.000000000","message":"+1 This concerns me to. Given @Armando\u0027s comment below, which I also agree with, I think this should return to /64 and this shouldn\u0027t be used as the default for L86.","commit_id":"7dec9a64ab7f180fb960edeb669be2eb3f394213"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d1db164738e3c005939aac60974134ebb948c136","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# Subnetpool defaults"},{"line_number":83,"context_line":"SUBNETPOOL_NAME\u003d${SUBNETPOOL_NAME:-\"shared-default-subnetpool\"}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"SUBNETPOOL_PREFIX_V4\u003d${SUBNETPOOL_PREFIX_V4:-$FIXED_RANGE}"},{"line_number":86,"context_line":"SUBNETPOOL_PREFIX_V6\u003d${SUBNETPOOL_PREFIX_V6:-$FIXED_RANGE_V6}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"SUBNETPOOL_SIZE_V4\u003d${SUBNETPOOL_SIZE_V4:-24}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a98d1f4_b9d5c4e5","line":85,"updated":"2016-10-04 00:50:24.000000000","message":"I intentionally used different defaults in [1], because these are not quite the same: a subnetpool is used to generate many fixed ranges and using FIXED_RANGE as a subnetpool prefix feels wrong. Bear in mind that the size of the subnet pool was a loooot smaller the way I had envisioned and we went over and above with [2]. Perhaps we can simply scale back or adjust these in devstack-gate.\n\nEither way, I would rather avoid making these the same, because they aren\u0027t.\n\n[1] https://review.openstack.org/#/c/282559\n[2] https://review.openstack.org/#/c/283289","commit_id":"7dec9a64ab7f180fb960edeb669be2eb3f394213"}]}