)]}'
{"id":"openstack%2Fdevstack~379952","triplet_id":"openstack%2Fdevstack~master~Id927501bdfeb90199f3114afb3194614ad491c21","project":"openstack/devstack","branch":"master","topic":"tempest-serviceenabled-logic","hashtags":[],"change_id":"Id927501bdfeb90199f3114afb3194614ad491c21","subject":"Revert \"Fix the logic of if used with is_service_enabled\"","status":"ABANDONED","created":"2016-09-30 06:24:36.000000000","updated":"2016-09-30 14:03:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f6325cd2e25959e114cd5b7939a8e9994058ade4","_number":379952,"virtual_id_number":379952,"owner":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-09-30 08:21:44.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2016-09-30 07:52:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2016-09-30 07:35:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2016-09-30 08:30:50.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"date":"2016-09-30 08:13:30.000000000","_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2016-09-30 07:45:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-30 07:35:04.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-09-30 07:45:23.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2016-09-30 07:52:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-30 08:21:44.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-09-30 08:30:50.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb1f0a62a0f04b218ca61c88ed579926be7c091b","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 06:37:32.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"cc4124bf9fa10085a8cdd8138254f92393ee975d","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-09-30 07:35:04.000000000","message":"Patch Set 2:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/52/379952/2/check/check-ibm-tempest-dsvm-full/bcb4690/ : SUCCESS in 57m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"459e5caf6cfbb485f940a331c4181a0525661f9a","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2016-09-30 07:45:23.000000000","message":"Patch Set 2: Code-Review-1\n\nThe command did not change the logic, but fixed an error: the  logic was wrong. Is there a way to have the test not rely on that value?","accounts_in_message":[],"_revision_number":2},{"id":"82ff417d78bc8d459e147138e72419f86d2a0ec9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 07:52:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/aaaf94f/ : SUCCESS in 45m 24s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/96cbdb0/ : SUCCESS in 29m 37s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-full-ubuntu-xenial/407db9f/ : SUCCESS in 38m 41s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-grenade-dsvm-ubuntu-xenial/461b64f/ : SUCCESS in 25m 57s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/52/379952/2/check/gate-devstack-docs-ubuntu-xenial/51351ff//doc/build/html/ : SUCCESS in 2m 38s\n- gate-devstack-bashate http://logs.openstack.org/52/379952/2/check/gate-devstack-bashate/d317617/ : SUCCESS in 2m 27s\n- gate-devstack-unit-tests http://logs.openstack.org/52/379952/2/check/gate-devstack-unit-tests/86e193a/ : SUCCESS in 1m 54s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv/68a8fe6/ : SUCCESS in 23m 48s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/52/379952/2/check/gate-devstack-dsvm-updown/951878c/ : SUCCESS in 30m 21s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/ab2fc3e/ : FAILURE in 1h 13m 20s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/52/379952/2/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/b64f45e/ : SUCCESS in 16m 00s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial/e75bfac/ : FAILURE in 49m 31s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial/1b366aa/ : FAILURE in 17m 00s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/52/379952/2/check/gate-grenade-dsvm-multinode/b55618d/ : SUCCESS in 26m 26s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/52/379952/2/check/gate-grenade-dsvm-neutron-multinode/b77622e/ : SUCCESS in 32m 49s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-platform-centos7-nv/e236d2a/ : SUCCESS in 50m 15s (non-voting)\n- gate-tempest-dsvm-platform-fedora24-nv http://logs.openstack.org/52/379952/2/check/gate-tempest-dsvm-platform-fedora24-nv/cf5f381/ : FAILURE in 30m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4e003a9beab203e8a7729d53535e7a93689b30b8","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 08:13:30.000000000","message":"Patch Set 2:\n\n\u003e The command did not change the logic, but fixed an error: the \n \u003e logic was wrong. Is there a way to have the test not rely on that\n \u003e value?\n\nIronic requires fixed_network_name to be set explicitly can we left only:\nif ! is_service_enabled n-cell; then\n   ....\nfi\nhttps://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L1161","accounts_in_message":[],"_revision_number":2},{"id":"743b020d44ba1e94a9702a35bc16d29947ca24a0","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 08:17:54.000000000","message":"Patch Set 2:\n\n\u003e The command did not change the logic, but fixed an error: the \n \u003e logic was wrong. Is there a way to have the test not rely on that\n \u003e value?\n\nIt changed the logic and it break Ironic case:\nvsaienko@cz5578:~$ if [[ ! $(false) \u0026\u0026 ! $(true) ]]; then echo \"boom\"; fi\nboom\nvsaienko@cz5578:~$ if ! false \u0026\u0026 ! true; then echo \"boom\"; fi\nvsaienko@cz5578:~$","accounts_in_message":[],"_revision_number":2},{"id":"b9efe124870f6e2e7b97773d2d8fbf574ad2c580","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-09-30 08:21:44.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- dsvm-tempest-nova-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/52/379952/2/check/dsvm-tempest-nova-network/7908d2c : SUCCESS in 1h 13m 52s\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/52/379952/2/check/dsvm-tempest-neutron-network/c629bc3 : SUCCESS in 1h 43m 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"884a8612496fe6b9ad7c06c0a5a59294becbe492","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2016-09-30 08:26:10.000000000","message":"Patch Set 2:\n\nIf you use neutron, you can\u0027t rely on that key. You need to dynamically get the project network, which can be dynamically created. Unfortunately it seems that there is no public tempest API for this, but if your base test class still relies on the non-stable  BaseTestCase class, you can use get_tenant_network and try to work on tempest to have a public version of that method/function.\nIn other words: if you were that key for the private network in your neutron tests, your tests results were potentially unreliable.\n\nYes, the logic was changed, but now it\u0027s doing what was intended: not set the key when neutron is used. The previous bash logic was broken, as you can easily check by comparing what that if was intended to do from the comment and the commit message of the review where it was changed, and what it was really doing.","accounts_in_message":[],"_revision_number":2},{"id":"e394c5e067f9c20f408175516e9a32c6eca8e133","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 08:28:49.000000000","message":"Patch Set 2:\n\n\u003e If you use neutron, you can\u0027t rely on that key. You need to\n \u003e dynamically get the project network, which can be dynamically\n \u003e created. Unfortunately it seems that there is no public tempest API\n \u003e for this, but if your base test class still relies on the\n \u003e non-stable  BaseTestCase class, you can use get_tenant_network and\n \u003e try to work on tempest to have a public version of that\n \u003e method/function.\n \u003e In other words: if you were that key for the private network in\n \u003e your neutron tests, your tests results were potentially unreliable.\n \u003e \n \u003e Yes, the logic was changed, but now it\u0027s doing what was intended:\n \u003e not set the key when neutron is used. The previous bash logic was\n \u003e broken, as you can easily check by comparing what that if was\n \u003e intended to do from the comment and the commit message of the\n \u003e review where it was changed, and what it was really doing.\n\nIn case of Ironic we can provision instances only in specific network. We need to have access to/from this network to control plane (ironic conductor/ironic api) it is Ironic prerequirement.\n\nLets do not revert this but update the logic to always set fixed_network_name when ironic is enabled: https://review.openstack.org/#/c/380006","accounts_in_message":[],"_revision_number":2},{"id":"e1aba88bda5e95d100a0038e6932cb0d54e1faa7","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-09-30 08:30:50.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/52/379952/2/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/de38602 : SUCCESS in 58m 38s (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/52/379952/2/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/75d751d : SUCCESS in 58m 45s (non-voting)\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/52/379952/2/check/tempest-dsvm-full-nfv-xenial/e6dd109 : SUCCESS in 1h 50m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"62aa6bb779858aedfac829a751fb1bd097fec289","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2016-09-30 08:47:40.000000000","message":"Patch Set 2:\n\nThen you may want to use another variable, as that one has a specific meaning, which does not match your usage.","accounts_in_message":[],"_revision_number":2},{"id":"7d331ba9ad90a43397696286399819fe5d1c0d72","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 08:50:15.000000000","message":"Patch Set 2:\n\n\u003e Then you may want to use another variable, as that one has a\n \u003e specific meaning, which does not match your usage.\n\nI\u0027m sorry, could you please be more specific about which variable you are talking fixed_network_name?","accounts_in_message":[],"_revision_number":2},{"id":"bfc0047654a040e8ee37b38bba2828255fa0b8c5","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-09-30 14:03:35.000000000","message":"Abandoned\n\ntry to use other approach: https://review.openstack.org/#/c/380006","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"47cca007bf1abda773731db04f135a57fc4d0ed1","revisions":{"86babfdfaf0705952853443418d5e63608012365":{"kind":"REWORK","_number":1,"created":"2016-09-30 06:24:36.000000000","uploader":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"ref":"refs/changes/52/379952/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/52/379952/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/52/379952/1"}}},"commit":{"parents":[{"commit":"4c813ac0fb64c7b4eeec7f67692ccfd7affd2153","subject":"Fix the logic of if used with is_service_enabled","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4c813ac0fb64c7b4eeec7f67692ccfd7affd2153"}]}],"author":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2016-09-30 06:24:36.000000000","tz":0},"committer":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2016-09-30 06:24:36.000000000","tz":0},"subject":"Revert \"Fix the logic of if used with is_service_enabled\"","message":"Revert \"Fix the logic of if used with is_service_enabled\"\n\nThis commit changed logic, please have look: https://paste.mirantis.net/show/2699/\n\nAs result ironic-grenade job become broken since fixed_network_name is not set.\n\nThis reverts commit 4c813ac0fb64c7b4eeec7f67692ccfd7affd2153.\n\nChange-Id: Id927501bdfeb90199f3114afb3194614ad491c21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/86babfdfaf0705952853443418d5e63608012365"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/86babfdfaf0705952853443418d5e63608012365"}]},"branch":"refs/heads/master"},"47cca007bf1abda773731db04f135a57fc4d0ed1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-09-30 06:37:32.000000000","uploader":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"ref":"refs/changes/52/379952/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/52/379952/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/379952/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/52/379952/2"}}},"commit":{"parents":[{"commit":"4c813ac0fb64c7b4eeec7f67692ccfd7affd2153","subject":"Fix the logic of if used with is_service_enabled","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4c813ac0fb64c7b4eeec7f67692ccfd7affd2153"}]}],"author":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2016-09-30 06:24:36.000000000","tz":0},"committer":{"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","date":"2016-09-30 06:37:30.000000000","tz":0},"subject":"Revert \"Fix the logic of if used with is_service_enabled\"","message":"Revert \"Fix the logic of if used with is_service_enabled\"\n\nThis commit changed logic, please have look:\nhttp://paste.openstack.org/show/583580/\n\nAs result ironic-grenade job become broken since fixed_network_name\nis not set.\n\nThis reverts commit 4c813ac0fb64c7b4eeec7f67692ccfd7affd2153.\n\nChange-Id: Id927501bdfeb90199f3114afb3194614ad491c21\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/47cca007bf1abda773731db04f135a57fc4d0ed1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/47cca007bf1abda773731db04f135a57fc4d0ed1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}