)]}'
{"stack.sh":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0ba56d7fbecd35249db2f6d7388e0bf61ff685a0","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Unfortunately there is no in_array in bash we have to do a"},{"line_number":283,"context_line":"        # full loop again"},{"line_number":284,"context_line":"        for enabled_service in $ENABLED_SERVICE; do"},{"line_number":285,"context_line":"            [[ ${service} \u003d\u003d ${enabled_service} ]] \u0026\u0026 return 0"},{"line_number":286,"context_line":"            [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${enabled_service} \u003d\u003d n-* ]] \u0026\u0026 return 0"},{"line_number":287,"context_line":"            [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${enabled_service} \u003d\u003d g-* ]] \u0026\u0026 return 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXg%3D","line":284,"updated":"2012-02-06 21:27:14.000000000","message":"ENABLED_SERVICES (missing \u0027S\u0027)","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"7e6876bf5b05d248f9a8c9c52a2eecdcfb59da5c","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Unfortunately there is no in_array in bash we have to do a"},{"line_number":283,"context_line":"        # full loop again"},{"line_number":284,"context_line":"        for enabled_service in $ENABLED_SERVICE; do"},{"line_number":285,"context_line":"            [[ ${service} \u003d\u003d ${enabled_service} ]] \u0026\u0026 return 0"},{"line_number":286,"context_line":"            [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${enabled_service} \u003d\u003d n-* ]] \u0026\u0026 return 0"},{"line_number":287,"context_line":"            [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${enabled_service} \u003d\u003d g-* ]] \u0026\u0026 return 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXY%3D","line":284,"in_reply_to":"AAAAEn%2F%2F%2BXg%3D","updated":"2012-02-06 21:43:01.000000000","message":"Oops I have merged the wrong file, should be fixed. Thanks.","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0ba56d7fbecd35249db2f6d7388e0bf61ff685a0","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${enabled_service} \u003d\u003d n-* ]] \u0026\u0026 return 0"},{"line_number":287,"context_line":"            [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${enabled_service} \u003d\u003d g-* ]] \u0026\u0026 return 0"},{"line_number":288,"context_line":"            [[ ${service} \u003d\u003d \"quantum\" \u0026\u0026 ${enabled_service} \u003d\u003d q-* ]] \u0026\u0026 return 0"},{"line_number":289,"context_line":"        done"},{"line_number":290,"context_line":"    done"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXo%3D","line":289,"updated":"2012-02-06 21:27:14.000000000","message":"This loop isn\u0027t necessary.  Look at how we have been testing ENABLED_SERVICES with \u003d~, that should work here too.","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"7e6876bf5b05d248f9a8c9c52a2eecdcfb59da5c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            [[ ${service} \u003d\u003d \"nova\" \u0026\u0026 ${enabled_service} \u003d\u003d n-* ]] \u0026\u0026 return 0"},{"line_number":287,"context_line":"            [[ ${service} \u003d\u003d \"glance\" \u0026\u0026 ${enabled_service} \u003d\u003d g-* ]] \u0026\u0026 return 0"},{"line_number":288,"context_line":"            [[ ${service} \u003d\u003d \"quantum\" \u0026\u0026 ${enabled_service} \u003d\u003d q-* ]] \u0026\u0026 return 0"},{"line_number":289,"context_line":"        done"},{"line_number":290,"context_line":"    done"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXQ%3D","line":289,"in_reply_to":"AAAAEn%2F%2F%2BXo%3D","updated":"2012-02-06 21:43:01.000000000","message":"I am worried to be too greedy  for the catch all feature in case if we have a feature like foon-blah in the future that will be catched by the ENABLED_SERVICE \u003d~ n-* \n\n(see my example script in Cover Message)","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0ba56d7fbecd35249db2f6d7388e0bf61ff685a0","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            [[ ${service} \u003d\u003d \"quantum\" \u0026\u0026 ${enabled_service} \u003d\u003d q-* ]] \u0026\u0026 return 0"},{"line_number":289,"context_line":"        done"},{"line_number":290,"context_line":"    done"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Nova Network Configuration"},{"line_number":294,"context_line":"# --------------------------"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXk%3D","line":291,"updated":"2012-02-06 21:27:14.000000000","message":"What is the default return value?","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"7e6876bf5b05d248f9a8c9c52a2eecdcfb59da5c","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            [[ ${service} \u003d\u003d \"quantum\" \u0026\u0026 ${enabled_service} \u003d\u003d q-* ]] \u0026\u0026 return 0"},{"line_number":289,"context_line":"        done"},{"line_number":290,"context_line":"    done"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Nova Network Configuration"},{"line_number":294,"context_line":"# --------------------------"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAEn%2F%2F%2BXM%3D","line":291,"in_reply_to":"AAAAEn%2F%2F%2BXk%3D","updated":"2012-02-06 21:43:01.000000000","message":"Bash need a \"return 0\" to mean successful I can add a return 1 for explicitness.","commit_id":"b7df8ef78016e960d82a6bb40470ba7995f870ba"}]}