)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f4bf2d606ac0abc59eb12c634673b70d4a21a28a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although SECURE_DELETE was correctly handled in lib/cinder, that"},{"line_number":10,"context_line":"config flag was just completely ignored by lib/cinder_backend/lvm."},{"line_number":11,"context_line":"But the `volume_clear` config option must be set on a per backend"},{"line_number":12,"context_line":"basis, which means that without this patch CINDER_VOLUME_CLEAR"},{"line_number":13,"context_line":"has no effect(ignored) for the LVM backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_f198d51d","line":12,"updated":"2016-10-24 22:49:06.000000000","message":"I\u0027m just trying to understand what we actually need here.  It does seem it was missed  p.s. I know very little about this.  \n\nFrom what I can tell in I6afbdecea637f7e7d3417be537ab71fe97bffda3 and reading the code a bit this is saying the configuration is shared?  would we not just delete this bit in the LVM side all together?","commit_id":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b4d9d2dab672af4189d62e8ccbed4d6d38a3e776","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although SECURE_DELETE was correctly handled in lib/cinder, that"},{"line_number":10,"context_line":"config flag was just completely ignored by lib/cinder_backend/lvm."},{"line_number":11,"context_line":"But the `volume_clear` config option must be set on a per backend"},{"line_number":12,"context_line":"basis, which means that without this patch CINDER_VOLUME_CLEAR"},{"line_number":13,"context_line":"has no effect(ignored) for the LVM backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_c12fd8f4","line":12,"in_reply_to":"da6895a0_1f00d9a9","updated":"2016-10-26 08:31:48.000000000","message":"This doesn\u0027t reset the global value (the one in the DEAFULT section) because this value was and is not taken into account at all. \n\nSo if we remove this completely in cinder_backends/lvm, then volume_clear is set (for the LVM backend) to its default value, which is \"wipe with zeroes\"","commit_id":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"43c563e155e14592cf741844514556b5f5eb1330","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although SECURE_DELETE was correctly handled in lib/cinder, that"},{"line_number":10,"context_line":"config flag was just completely ignored by lib/cinder_backend/lvm."},{"line_number":11,"context_line":"But the `volume_clear` config option must be set on a per backend"},{"line_number":12,"context_line":"basis, which means that without this patch CINDER_VOLUME_CLEAR"},{"line_number":13,"context_line":"has no effect(ignored) for the LVM backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_1f00d9a9","line":12,"in_reply_to":"da6895a0_3daf7b82","updated":"2016-10-26 00:39:12.000000000","message":"I don\u0027t really disagree it is wrong, but my specific question is why don\u0027t we just remove this completely in cinder_backends/lvm?  this seems to just reset the global value?","commit_id":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ee8d155ce2d7c4b2945f825ed02dcfe61573bd94","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although SECURE_DELETE was correctly handled in lib/cinder, that"},{"line_number":10,"context_line":"config flag was just completely ignored by lib/cinder_backend/lvm."},{"line_number":11,"context_line":"But the `volume_clear` config option must be set on a per backend"},{"line_number":12,"context_line":"basis, which means that without this patch CINDER_VOLUME_CLEAR"},{"line_number":13,"context_line":"has no effect(ignored) for the LVM backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_0b518062","line":12,"in_reply_to":"da6895a0_3daf7b82","updated":"2016-10-25 18:08:47.000000000","message":"I meant, obviously, if SECURE_DELETE\u003dFalse...","commit_id":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4198552bc9564d461919332e26700c9eb9beaeac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although SECURE_DELETE was correctly handled in lib/cinder, that"},{"line_number":10,"context_line":"config flag was just completely ignored by lib/cinder_backend/lvm."},{"line_number":11,"context_line":"But the `volume_clear` config option must be set on a per backend"},{"line_number":12,"context_line":"basis, which means that without this patch CINDER_VOLUME_CLEAR"},{"line_number":13,"context_line":"has no effect(ignored) for the LVM backend."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_3daf7b82","line":12,"in_reply_to":"da6895a0_f198d51d","updated":"2016-10-25 08:06:14.000000000","message":"That review is from 2013, not sure it still applied. And it says \"At some point we shoudl restructure this a bit to allow multi-backends to specify independent settings for these configs.\" \n\nI don\"t really want to dig into the history but, without this patch, \"dd if\u003d/dev/zero ...\" is called on LVM volumes even if SECURE_DELETE\u003dTrue. Moreover, CINDER_VOLUME_CLEAR is deprecated for more than 1 year, so every patch to removes its usage in DevStack is a good patch :)","commit_id":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e"}]}