)]}'
{"id":"openstack%2Fdevstack~382409","triplet_id":"openstack%2Fdevstack~master~I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef","subject":"cinder_backends/lvm: use VOLUME_CLEAR instead of SECURE_DELETE","status":"ABANDONED","created":"2016-10-05 13:23:38.000000000","updated":"2016-10-31 02:37:44.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"64027d21f51c68053122221447825253987abbd9","_number":382409,"virtual_id_number":382409,"owner":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-10-05 15:16:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-10-25 08:06:14.000000000","_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"date":"2016-10-05 13:23:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2016-10-05 16:36:24.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2016-10-24 17:17:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":-1,"date":"2016-10-24 22:49:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-05 13:23:59.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-10-05 15:16:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-10-05 16:36:24.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-10-24 17:17:55.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2016-10-24 22:49:06.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"31cd45eae7ba22a5232b4b36f7b1a02766f74521","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-10-05 13:23:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0dea8367298c4f11818cec8d79d1a8f87ffea7db","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-10-05 13:23:59.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full check-ibm-tempest-dsvm-full : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e3fa7fb10713cea65ac94456d323f75a4191eb17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 15:16:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/0442f03/ : SUCCESS in 47m 30s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/faca367/ : SUCCESS in 31m 13s\n- gate-tempest-dsvm-full-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-full-ubuntu-xenial/34e77b4/ : SUCCESS in 39m 27s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-grenade-dsvm-ubuntu-xenial/e5c99ac/ : SUCCESS in 24m 41s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/09/382409/1/check/gate-devstack-docs-ubuntu-xenial/1cc130f//doc/build/html/ : SUCCESS in 2m 03s\n- gate-devstack-bashate http://logs.openstack.org/09/382409/1/check/gate-devstack-bashate/ee4a2f3/ : SUCCESS in 3m 54s\n- gate-devstack-unit-tests http://logs.openstack.org/09/382409/1/check/gate-devstack-unit-tests/b74e6a3/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-nv/a91d181/ : SUCCESS in 31m 38s (non-voting)\n- gate-devstack-dsvm-updown http://logs.openstack.org/09/382409/1/check/gate-devstack-dsvm-updown/92c5d41/ : SUCCESS in 16m 48s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/21c818b/ : SUCCESS in 46m 59s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/09/382409/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/52e2f5b/ : SUCCESS in 35m 35s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial/3d00c39/ : FAILURE in 1h 16m 35s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial/2f3bf32/ : SUCCESS in 1h 48m 51s (non-voting)\n- gate-grenade-dsvm-multinode http://logs.openstack.org/09/382409/1/check/gate-grenade-dsvm-multinode/97d3ac3/ : SUCCESS in 49m 40s\n- gate-grenade-dsvm-neutron-multinode http://logs.openstack.org/09/382409/1/check/gate-grenade-dsvm-neutron-multinode/c3f0734/ : SUCCESS in 35m 57s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-platform-centos7-nv/82e11c6/ : SUCCESS in 48m 11s (non-voting)\n- gate-tempest-dsvm-platform-fedora24-nv http://logs.openstack.org/09/382409/1/check/gate-tempest-dsvm-platform-fedora24-nv/4ad90a3/ : FAILURE in 32m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5602ef53564bfd44d3cc15b8f10b17a8717654eb","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-10-05 16:36:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/09/382409/1/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/4249c3a : FAILURE in 1h 19m 59s (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/09/382409/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/ca86977 : SUCCESS in 1h 06m 59s (non-voting)\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/09/382409/1/check/tempest-dsvm-full-nfv-xenial/b5b06a4 : SUCCESS in 1h 52m 53s","accounts_in_message":[],"_revision_number":1},{"id":"f794e07d57a526dd60c98098b85a59cfa9199d91","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2016-10-24 17:17:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f4bf2d606ac0abc59eb12c634673b70d4a21a28a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-24 22:49:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4198552bc9564d461919332e26700c9eb9beaeac","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-10-25 08:06:14.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ee8d155ce2d7c4b2945f825ed02dcfe61573bd94","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-10-25 18:08:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"43c563e155e14592cf741844514556b5f5eb1330","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-26 00:39:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b4d9d2dab672af4189d62e8ccbed4d6d38a3e776","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-10-26 08:31:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7977a4fd35612430c6569b847126b802ac725a8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-28 00:36:44.000000000","message":"Patch Set 1:\n\n\u003e This doesn\u0027t reset the global value (the one in the DEAFULT section) because this value was and is not taken into account at all. \n\nI don\u0027t see that this is set specifically in the LVM volume_opts [1], and it seems to just get the global value (_delete_volume).  I6afbdecea637f7e7d3417be537ab71fe97bffda3 suggests that the value in volume_ops is set from the global value?\n\nif it is the case that setting it globally doesn\u0027t actually get picked up, i feel that is certainly not made clear in any documentation i could see\n\n[1] http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/drivers/lvm.py#n46\n[2] http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/drivers/lvm.py#n131","accounts_in_message":[],"_revision_number":1},{"id":"ffeb260b9d0ae2e6173f92c4a33a617e4b9e907e","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-10-28 09:13:50.000000000","message":"Abandoned\n\nOh boy, if you ever got 5 min please do test the behavior. This is getting ridiculous :)","accounts_in_message":[],"_revision_number":1},{"id":"64027d21f51c68053122221447825253987abbd9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-10-31 02:37:44.000000000","message":"Patch Set 1:\n\nNot sure what else I can do but ask for clarification on a clearly poorly documented option.  I did not just make this up -- to my reading of the code the global value should be taken.  I am happy to be corrected, as always.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"056fa48ee351c1e21b3fdcac7c8764e5fb08555e","revisions":{"056fa48ee351c1e21b3fdcac7c8764e5fb08555e":{"kind":"REWORK","_number":1,"created":"2016-10-05 13:23:38.000000000","uploader":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"ref":"refs/changes/09/382409/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/09/382409/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/382409/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/382409/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/09/382409/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/09/382409/1"}}},"commit":{"parents":[{"commit":"563d3777823fa4ee113ac930c4066c3f8d5f8373","subject":"Merge \"Fix typo in documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/563d3777823fa4ee113ac930c4066c3f8d5f8373"}]}],"author":{"name":"Jordan Pittier","email":"jordan.pittier@scality.com","date":"2016-10-05 13:20:46.000000000","tz":120},"committer":{"name":"Jordan Pittier","email":"jordan.pittier@scality.com","date":"2016-10-05 13:23:35.000000000","tz":120},"subject":"cinder_backends/lvm: use VOLUME_CLEAR instead of SECURE_DELETE","message":"cinder_backends/lvm: use VOLUME_CLEAR instead of SECURE_DELETE\n\nAlthough SECURE_DELETE was correctly handled in lib/cinder, that\nconfig flag was just completely ignored by lib/cinder_backend/lvm.\nBut the `volume_clear` config option must be set on a per backend\nbasis, which means that without this patch CINDER_VOLUME_CLEAR\nhas no effect(ignored) for the LVM backend.\n\nChange-Id: I5e8f389cfc5fb0130f18f6eaf2f1d6045c3d46ef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/056fa48ee351c1e21b3fdcac7c8764e5fb08555e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/056fa48ee351c1e21b3fdcac7c8764e5fb08555e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}