)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f26b748cf8539daa4c5a5dae00e9fdf4ce890662","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a95cdbc_84e388a3","line":627,"updated":"2016-10-07 14:32:34.000000000","message":"Doesn\u0027t the image have to be signed when uploaded to glance?\n\nI\u0027m not really sure how the Tempest tests are passing, oh, because the variable is equating to \"\" so this condition doesn\u0027t pass.","commit_id":"a36e1c03ac5467a24855c951d2006af2b67b4dfa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c3c3be727add57ff3c19f61224a63761ec9403d","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a95cdbc_a47c04b6","line":627,"in_reply_to":"1a95cdbc_84e388a3","updated":"2016-10-07 14:34:52.000000000","message":"Looking at:\n\nhttp://docs.openstack.org/security-guide/instance-management/security-services-for-instances.html\n\nThere are going to need to be more changes in devstack than just this to make this stack work.","commit_id":"a36e1c03ac5467a24855c951d2006af2b67b4dfa"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ff1efa19cb1460199f46c664a067dc1adfd8e9de","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa6399be_1e8098f6","line":627,"in_reply_to":"1a95cdbc_a47c04b6","updated":"2016-10-14 09:49:10.000000000","message":"Also, for a simple change like this, there\u0027s no need to introduce a config flag, just use \u0027[[post-config|\\$NOVA_CONF]]\u0027 in your local.conf","commit_id":"a36e1c03ac5467a24855c951d2006af2b67b4dfa"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"1dd26512752776137accefd09422a22a0b3e6e3d","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa6399be_2038d13c","line":627,"in_reply_to":"fa6399be_1e8098f6","updated":"2016-10-14 12:25:27.000000000","message":"@Jordan: I need to update the commit message to express this more clearly, but this change is in support of a gate check which will test signature verification. That\u0027s why it needs to be enabled via an env variable instead of in local.conf","commit_id":"a36e1c03ac5467a24855c951d2006af2b67b4dfa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5b0d350f95196b3006c510aaea16f41e2e9d2ae0","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_9f951842","line":627,"updated":"2016-12-01 19:34:13.000000000","message":"Don\u0027t we also need to have signed images when doing this? I really thought there would be more to the devstack changes wrt making sure the image is signed when it\u0027s created in glance.","commit_id":"61dcf4b3c15c72c50fd80845ce1072c20b2e0351"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"805ffe328858a15c545d62db027b977711cad3b9","unresolved":false,"context_lines":[{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    if [ \"$VERIFY_GLANCE_SIGNATURES\" \u003d\u003d \"True\" ]; then"},{"line_number":627,"context_line":"        iniset $NOVA_CONF glance verify_glance_signatures \"True\""},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_3ff32475","line":627,"in_reply_to":"3a71b18c_9f951842","updated":"2016-12-01 19:41:41.000000000","message":"I\u0027m thinking of the steps outlined here:\n\nhttp://docs.openstack.org/ops-guide/ops-user-facing-operations.html#adding-signed-images","commit_id":"61dcf4b3c15c72c50fd80845ce1072c20b2e0351"}]}