)]}'
{"id":"openstack%2Fdevstack~38379","triplet_id":"openstack%2Fdevstack~master~Ib845d3e098fd3f45c8c26f5696af14cca1534e01","project":"openstack/devstack","branch":"master","topic":"service-available-tempest","hashtags":[],"change_id":"Ib845d3e098fd3f45c8c26f5696af14cca1534e01","subject":"Set service_available config options in tempest","status":"MERGED","created":"2013-07-23 21:29:58.000000000","updated":"2013-07-26 23:04:58.000000000","submitted":"2013-07-26 23:04:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4e05f67c10bd13c6f858df4753be18d39615c373","_number":38379,"virtual_id_number":38379,"owner":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-07-26 23:04:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"all":[{"value":0,"date":"2013-07-24 16:40:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-26 12:19:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":2,"date":"2013-07-26 16:09:37.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-07-26 11:05:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2013-07-26 11:01:16.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":1,"date":"2013-07-26 16:09:37.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"date":"2013-07-26 11:01:16.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-24 03:00:05.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2013-07-24 16:40:20.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-07-26 11:01:16.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-07-26 11:05:41.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2013-07-26 12:19:58.000000000","updated_by":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"reviewer":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"state":"REVIEWER"},{"updated":"2013-07-26 16:09:37.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-07-26 23:04:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1c9b5f8c8129fcbd7686df7db4eda51bf2df7d7d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 22:29:00.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/79/38379/1/check/gate-tempest-devstack-vm-full/34892 : SUCCESS in 57m 57s\n- http://logs.openstack.org/79/38379/1/check/gate-tempest-devstack-vm-cells-full/2371 : FAILURE in 14m 44s (non-voting)\n- http://logs.openstack.org/79/38379/1/check/gate-tempest-devstack-vm-testr-full/1214 : SUCCESS in 27m 51s (non-voting)\n- http://logs.openstack.org/79/38379/1/check/gate-tempest-devstack-vm-postgres-full/34582 : SUCCESS in 58m 57s\n- http://logs.openstack.org/79/38379/1/check/gate-tempest-devstack-vm-neutron/6772 : FAILURE in 19m 27s (non-voting)\n- http://logs.openstack.org/79/38379/1/check/gate-grenade-devstack-vm/20545 : SUCCESS in 22m 18s\n","accounts_in_message":[],"_revision_number":1},{"id":"1753fd134b3f65554bd77763faaf525dcddefe03","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-24 00:50:36.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nWhitespace cleanup then you\u0027re good to go.\n\nIt would be nice to not maintain that service list in the code but I don\u0027t have a suggestion on how else to do it.","accounts_in_message":[],"_revision_number":1},{"id":"454150679b306a89806d2a79c100668b64eb11e0","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-07-24 03:00:05.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nsee inline, I think we need to address usage of \"swift\"","accounts_in_message":[],"_revision_number":1},{"id":"64c0e823f3363c258a62a957f4ada94fd968d516","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-07-24 04:57:01.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b1c89801ea7607c3a2a7ec9bb72ef86bdee9ffcf","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2013-07-24 14:05:05.000000000","message":"Patch Set 1: (1 inline comment)\n\n@Ian and Chmouel:\nUsing swift works fine. (You can look at the console output from the jenkins run if you don\u0027t believe me) If you look at the definition of is_service_enabled() it will return true if any service is enabled that starts with \"s-\".","accounts_in_message":[],"_revision_number":1},{"id":"f30a349ab4714465fd247e22844f10641465c6f9","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2013-07-24 14:05:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4d7eab957e7b35dccbd38150937b8015b85bb0eb","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-07-24 14:05:19.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":2},{"id":"d244e3cf53d65271e7aa80e7611ca365fdb09d8c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-24 15:03:55.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/79/38379/2/check/gate-tempest-devstack-vm-full/35120 : SUCCESS in 58m 37s\n- http://logs.openstack.org/79/38379/2/check/gate-tempest-devstack-vm-cells-full/2570 : FAILURE in 15m 12s (non-voting)\n- http://logs.openstack.org/79/38379/2/check/gate-tempest-devstack-vm-testr-full/1408 : FAILURE in 31m 58s (non-voting)\n- http://logs.openstack.org/79/38379/2/check/gate-tempest-devstack-vm-postgres-full/34810 : SUCCESS in 48m 28s\n- http://logs.openstack.org/79/38379/2/check/gate-tempest-devstack-vm-neutron/7028 : SUCCESS in 19m 44s (non-voting)\n- http://logs.openstack.org/79/38379/2/check/gate-grenade-devstack-vm/20755 : SUCCESS in 22m 47s\n","accounts_in_message":[],"_revision_number":2},{"id":"4a89a752240c08e5ad76e3bb91a950e746c35daf","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-24 15:26:10.000000000","message":"Patch Set 2:\n\n@Matthew, I think the concern is that using \u0027swift\u0027 (or any of the other project names there) implies true if _any_ of that project\u0027s services are enabled, thus they will be \u0027enabled\u0027 in multi-node devstack on compute nodes or swift-only nodes or whatever.  This is rare and I suspect that the Tempest use-case is to only run on the \u0027master\u0027 node in that configuration.","accounts_in_message":[],"_revision_number":2},{"id":"594152cb3a5dc21b3a7f7fb6656364c2218a702d","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-07-24 16:40:20.000000000","message":"Patch Set 2:\n\n+1 to @Dean\u0027s comment.","accounts_in_message":[],"_revision_number":2},{"id":"fc82cf85cc058888bce6c7069748c859c080762b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-26 11:01:16.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nthis code is only run if you enabled tempest on that same node. So I think that if tempest is enabled, and any swift service is turned on, then swift is enabled. If no swift services are turned on, then swift is disabled in tempest. That seems sensible to me.","accounts_in_message":[],"_revision_number":2},{"id":"c3755040845391c5f9086d8a2bbf485dc0e4f44e","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-07-26 11:05:41.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"1b5de994360a1b989cb34a1004c065a85bb369b0","author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"date":"2013-07-26 12:19:58.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b5ebd75408e9ac91f70a00fcc7212241700ecb5a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-26 16:09:37.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"62d13186839741264d2cc1b13909cdb937c94e80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 16:14:19.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"302a9c969a18d154c676a7f0c2db76b3d8af39a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 23:04:57.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/79/38379/2/gate/gate-tempest-devstack-vm-full/36171 : SUCCESS in 51m 56s\n- http://logs.openstack.org/79/38379/2/gate/gate-tempest-devstack-vm-postgres-full/35853 : SUCCESS in 50m 58s\n- http://logs.openstack.org/79/38379/2/gate/gate-tempest-devstack-vm-neutron/8203 : SUCCESS in 23m 11s (non-voting)\n- http://logs.openstack.org/79/38379/2/gate/gate-grenade-devstack-vm/21697 : SUCCESS in 23m 22s\n","accounts_in_message":[],"_revision_number":2},{"id":"3f7c5183e35ba9968bc74a31819e657286946e6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-26 23:04:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b56d81d5954a55aab92de31ae69a45e1dffa64ef","revisions":{"dc6bc8804af0fa51f4db2e75ab49750b07b70f67":{"kind":"REWORK","_number":1,"created":"2013-07-23 21:29:58.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/79/38379/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/79/38379/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/79/38379/1"}}},"commit":{"parents":[{"commit":"c373cf8b89a6ad5d97027964db5f42e98b568b7d","subject":"Update neutron_available config option.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c373cf8b89a6ad5d97027964db5f42e98b568b7d"}]}],"author":{"name":"Matthew Treinish","email":"treinish@linux.vnet.ibm.com","date":"2013-07-23 21:25:39.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"treinish@linux.vnet.ibm.com","date":"2013-07-23 21:27:42.000000000","tz":-240},"subject":"Set service_available config options in tempest","message":"Set service_available config options in tempest\n\nThis commit loops over the list of services that tempest has config\noptions for in the service_available group and checks if the service\nis enabled. Devstack will then set whether or not the service is\nconfigured in tempest.conf.\n\nChange-Id: Ib845d3e098fd3f45c8c26f5696af14cca1534e01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dc6bc8804af0fa51f4db2e75ab49750b07b70f67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/dc6bc8804af0fa51f4db2e75ab49750b07b70f67"}]},"branch":"refs/heads/master"},"b56d81d5954a55aab92de31ae69a45e1dffa64ef":{"kind":"REWORK","_number":2,"created":"2013-07-24 14:05:13.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/79/38379/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/79/38379/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/79/38379/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/79/38379/2"}}},"commit":{"parents":[{"commit":"c373cf8b89a6ad5d97027964db5f42e98b568b7d","subject":"Update neutron_available config option.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/c373cf8b89a6ad5d97027964db5f42e98b568b7d"}]}],"author":{"name":"Matthew Treinish","email":"treinish@linux.vnet.ibm.com","date":"2013-07-23 21:25:39.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"treinish@linux.vnet.ibm.com","date":"2013-07-24 14:03:45.000000000","tz":-240},"subject":"Set service_available config options in tempest","message":"Set service_available config options in tempest\n\nThis commit loops over the list of services that tempest has config\noptions for in the service_available group and checks if the service\nis enabled. Devstack will then set whether or not the service is\nconfigured in tempest.conf.\n\nChange-Id: Ib845d3e098fd3f45c8c26f5696af14cca1534e01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b56d81d5954a55aab92de31ae69a45e1dffa64ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b56d81d5954a55aab92de31ae69a45e1dffa64ef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}