)]}'
{"lib/nova":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"66f0e32538d55c40e770e68811d402d1a6b53586","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        # **$LIBVIRT_GROUP** group."},{"line_number":831,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $LIBVIRT_GROUP"},{"line_number":832,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027lxd\u0027 ]]; then"},{"line_number":833,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $LXD_GROUP"},{"line_number":834,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027fake\u0027 ]]; then"},{"line_number":835,"context_line":"        local i"},{"line_number":836,"context_line":"        for i in `seq 1 $NUMBER_FAKE_NOVA_COMPUTE`; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa6399be_3a9de465","line":833,"updated":"2016-10-12 00:32:12.000000000","message":"this is how we\u0027ve added it before -- and presumably you\u0027re going to have to set something like DEVSTACK_GATE_VIRT_DRIVER in devstack-gate to get any CI on this path.\n\nI certainly get that it\u0027s a bit of a layering violation to have stuff in plugins and be switching on it here, but here we are ...\n\nSo basically I think this should be put in as a separate VIRT_DRIVER case, like lxd does.\n\n(otherwise, clean both up so they are consistent ...)","commit_id":"26111f560dcba11f7e4e77d21e9678a62e2f5404"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0f5194e14c51fb0c96256a6978150f3e94db622f","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        # **$LIBVIRT_GROUP** group."},{"line_number":831,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $LIBVIRT_GROUP"},{"line_number":832,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027lxd\u0027 ]]; then"},{"line_number":833,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $LXD_GROUP"},{"line_number":834,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027fake\u0027 ]]; then"},{"line_number":835,"context_line":"        local i"},{"line_number":836,"context_line":"        for i in `seq 1 $NUMBER_FAKE_NOVA_COMPUTE`; do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa6399be_3c8a20c0","line":833,"in_reply_to":"fa6399be_3a9de465","updated":"2016-10-12 16:02:20.000000000","message":"Thanks for the suggestion. I tried to clean both up and please let me know if you see anything wrong in this approach.","commit_id":"26111f560dcba11f7e4e77d21e9678a62e2f5404"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e53fa7d5ae2ae656a843da11f6d9c14404a0dee8","unresolved":false,"context_lines":[{"line_number":837,"context_line":"    fi"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":840,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $group"},{"line_number":841,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027fake\u0027 ]]; then"},{"line_number":842,"context_line":"        local i"},{"line_number":843,"context_line":"        for i in `seq 1 $NUMBER_FAKE_NOVA_COMPUTE`; do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_83b34097","line":840,"updated":"2016-10-16 23:44:20.000000000","message":"is this not exactly the same as the else branch now?\n\ni.e. only if it\u0027s \"fake\" are we doing something different\n\nbut more to the point, the prior code keeps a mapping between XXX_DRIVER and XXX_GROUP (i.e. you only set LXD_GROUP when VIRT_DRIVER\u003d\u003d\u0027lxd\u0027)\n\nwhy do we want to allow arbitrary groups that are not releated to the driver?","commit_id":"9bdeef5121b2d8bc339f7c326fbdb882726b3857"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"57758d11c4c94413adafee279efbaf9ba7aaf9b4","unresolved":false,"context_lines":[{"line_number":837,"context_line":"    fi"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":840,"context_line":"        run_process n-cpu \"$NOVA_BIN_DIR/nova-compute --config-file $compute_cell_conf\" $group"},{"line_number":841,"context_line":"    elif [[ \"$VIRT_DRIVER\" \u003d \u0027fake\u0027 ]]; then"},{"line_number":842,"context_line":"        local i"},{"line_number":843,"context_line":"        for i in `seq 1 $NUMBER_FAKE_NOVA_COMPUTE`; do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_78941a8a","line":840,"in_reply_to":"fa6399be_83b34097","updated":"2016-10-17 01:56:34.000000000","message":"I wanted to allow arbitrary group-virdriver pair because it allows me to rename the driver without submitting another patch to devstack. However, this is a minor issue so I revised the patch as you suggested.","commit_id":"9bdeef5121b2d8bc339f7c326fbdb882726b3857"}]}