)]}'
{"id":"openstack%2Fdevstack~38505","triplet_id":"openstack%2Fdevstack~master~Ic604437fde2e057faced40a310ab282f3eb27726","project":"openstack/devstack","branch":"master","topic":"remove-netaddr","hashtags":[],"change_id":"Ic604437fde2e057faced40a310ab282f3eb27726","subject":"Remove python-netaddr requirement","status":"MERGED","created":"2013-07-24 17:28:21.000000000","updated":"2013-07-25 11:10:40.000000000","submitted":"2013-07-25 11:10:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"58725335cdc4d3d458a65f2f0e146a9b7a137267","_number":38505,"virtual_id_number":38505,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-07-25 11:10:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-25 06:27:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"date":"2013-07-25 02:35:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"date":"2013-07-25 04:49:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-07-25 00:37:58.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2013-07-25 10:22:31.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"date":"2013-07-25 04:49:28.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2013-07-25 10:22:31.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-25 00:37:58.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2013-07-25 02:35:49.000000000","updated_by":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"reviewer":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"state":"REVIEWER"},{"updated":"2013-07-25 06:27:25.000000000","updated_by":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"reviewer":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"state":"REVIEWER"},{"updated":"2013-07-25 10:22:31.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-07-25 11:10:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f1d3f7447b36d6b748a7b1a38ba6c43c822725b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-24 18:23:36.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/05/38505/1/check/gate-tempest-devstack-vm-full/35199 : SUCCESS in 51m 25s\n- http://logs.openstack.org/05/38505/1/check/gate-tempest-devstack-vm-cells-full/2631 : FAILURE in 20m 18s (non-voting)\n- http://logs.openstack.org/05/38505/1/check/gate-tempest-devstack-vm-testr-full/1464 : FAILURE in 37m 02s (non-voting)\n- http://logs.openstack.org/05/38505/1/check/gate-tempest-devstack-vm-postgres-full/34887 : SUCCESS in 55m 09s\n- http://logs.openstack.org/05/38505/1/check/gate-tempest-devstack-vm-neutron/7120 : SUCCESS in 22m 43s (non-voting)\n- http://logs.openstack.org/05/38505/1/check/gate-grenade-devstack-vm/20825 : SUCCESS in 29m 45s\n","accounts_in_message":[],"_revision_number":1},{"id":"7900d07a753b417ef89d725449761eb6d08bb89d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-07-25 00:37:58.000000000","message":"Patch Set 1:\n\nThis seems like a very complicated way to replace that existing call?\n\nWhy not just xor the shifted out network components; something like [1]?\n\n[1] http://pastebin.com/qKcbKzKa","accounts_in_message":[],"_revision_number":1},{"id":"fd17e48ecf9df51ae4c85b2dd8b41e30c7689334","author":{"_account_id":6473,"name":"Sunil Thaha","email":"sthaha@redhat.com","username":"sthaha"},"date":"2013-07-25 02:35:49.000000000","message":"Patch Set 1: (1 inline comment)\n\nI like Ian\u0027s approach to solving this but could be improved a bit like: http://pastebin.com/7eRD8uEf","accounts_in_message":[],"_revision_number":1},{"id":"7cbf5e0ce4041fe5aa534bac5e5c8661bc9e2d5a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-25 04:49:28.000000000","message":"Patch Set 1:\n\nIan, I pulled some well-tested functions that I\u0027ve used before in a previous life\u0027s project.","accounts_in_message":[],"_revision_number":1},{"id":"bd4c18705fe778462c0bdedc9824c6aa9ac191ce","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2013-07-25 06:27:25.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a257249ef8c9b2b2d376d48a1a411a773f2ec236","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-25 10:22:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"31f5633f215a8b142ef62f2abf60a0fa01cdc6a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-25 10:22:32.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e67f05a3bb047b69a8a3e27baa6ec5721f891a67","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-07-25 10:27:38.000000000","message":"Patch Set 1:\n\n@Dean I don\u0027t feel strongly, but it does seem to make something simple look a lot harder than it is.\n\nI agree getting rid of that import message is helpful.  Probably everyone running devstack for the first time has chased it down to realise it\u0027s harmless","accounts_in_message":[],"_revision_number":1},{"id":"a894225cdf3a534802d7316232313adffa738ce4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-25 11:10:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"6771c646788d129b7750fbd6559160d1917eb19b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-25 11:10:40.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/05/38505/1/gate/gate-tempest-devstack-vm-full/35444 : SUCCESS in 46m 44s\n- http://logs.openstack.org/05/38505/1/gate/gate-tempest-devstack-vm-postgres-full/35132 : SUCCESS in 48m 02s\n- http://logs.openstack.org/05/38505/1/gate/gate-tempest-devstack-vm-neutron/7410 : SUCCESS in 19m 10s (non-voting)\n- http://logs.openstack.org/05/38505/1/gate/gate-grenade-devstack-vm/21045 : SUCCESS in 27m 19s\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d4f69b21f530059be8d3a7001ebbd1ce53aa7926","revisions":{"d4f69b21f530059be8d3a7001ebbd1ce53aa7926":{"kind":"REWORK","_number":1,"created":"2013-07-24 17:28:21.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/05/38505/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/05/38505/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/05/38505/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/05/38505/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/05/38505/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/05/38505/1"}}},"commit":{"parents":[{"commit":"89b58846b5604cdf976074a68004840cc6865bdb","subject":"Merge \"Create an endpoint for nova api v3.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/89b58846b5604cdf976074a68004840cc6865bdb"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-24 17:24:43.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-24 17:25:35.000000000","tz":-300},"subject":"Remove python-netaddr requirement","message":"Remove python-netaddr requirement\n\nRemove python-netaddr as a DevStack (stack.sh) requirement,\nthis does not change any individual project requirements.\n\nSpecifically it replaces address_in_net() and adds cidr2netmask()\nand maskip() functions.\n\nChange-Id: Ic604437fde2e057faced40a310ab282f3eb27726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d4f69b21f530059be8d3a7001ebbd1ce53aa7926"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d4f69b21f530059be8d3a7001ebbd1ce53aa7926"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}