)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da61d6c4631fef1b7a7db7c864769cd69816a30c","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    fi"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    # ``run_process`` checks ``is_service_enabled``, it is not needed here"},{"line_number":864,"context_line":"    run_process n-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $compute_cell_conf\""},{"line_number":865,"context_line":"    run_process n-cell-region \"$NOVA_BIN_DIR/nova-cells --config-file $api_cell_conf\""},{"line_number":866,"context_line":"    run_process n-cell-child \"$NOVA_BIN_DIR/nova-cells --config-file $compute_cell_conf\""},{"line_number":867,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa6399be_0c2f6a88","side":"PARENT","line":864,"updated":"2016-10-15 14:48:05.000000000","message":"grenade fails because this was removed, so I guess grenade will need to be updated to explicitly start conductor (and nova-net) and then do the rest here.","commit_id":"88172b8763bd48dc782a28671312b91c1e34dd14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17fa89aa3a272040e84784b19eeb3761c8b2c432","unresolved":false,"context_lines":[{"line_number":861,"context_line":"    fi"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    # ``run_process`` checks ``is_service_enabled``, it is not needed here"},{"line_number":864,"context_line":"    run_process n-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $compute_cell_conf\""},{"line_number":865,"context_line":"    run_process n-cell-region \"$NOVA_BIN_DIR/nova-cells --config-file $api_cell_conf\""},{"line_number":866,"context_line":"    run_process n-cell-child \"$NOVA_BIN_DIR/nova-cells --config-file $compute_cell_conf\""},{"line_number":867,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa6399be_cc94928c","side":"PARENT","line":864,"in_reply_to":"fa6399be_0c2f6a88","updated":"2016-10-15 15:09:44.000000000","message":"It doesn\u0027t look like run_process is idempotent though, so I\u0027m not sure how I can chain the changes together because I basically need:\n\n  1. devstack change to add the start_nova_process function\n  2. grenade change to use start_nova_process to start n-cond and n-net - the problem is grenade will still call start_nova will which try to start n-cond and n-net again.\n  3. devstack change that depends on the grenade change and also starts n-cond/n-net separately","commit_id":"88172b8763bd48dc782a28671312b91c1e34dd14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"94c46530c3996bfea6207ee165f026c1b0ee2b8d","unresolved":false,"context_lines":[{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    # Check to see if the process is already running"},{"line_number":820,"context_line":"    if is_running $binary; then"},{"line_number":821,"context_line":"        echo \"$service is already running\""},{"line_number":822,"context_line":"        return"},{"line_number":823,"context_line":"    fi"},{"line_number":824,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa6399be_4c316259","line":821,"updated":"2016-10-15 16:47:02.000000000","message":"Cool this is working:\n\nhttp://logs.openstack.org/55/386855/6/check/gate-tempest-dsvm-full-ubuntu-xenial/38a75a5/logs/devstacklog.txt.gz#_2016-10-15_16_21_32_536","commit_id":"d3e7534f9d361f6ef0bbdb007b078d09b4bdbcf4"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"8ed391bbb36fb60bccd601cdcc12c86fdf6e3c11","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    local binary\u003d$2"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    # Check to see if the process is already running"},{"line_number":820,"context_line":"    if is_running $binary; then"},{"line_number":821,"context_line":"        echo \"$service is already running\""},{"line_number":822,"context_line":"        return"},{"line_number":823,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fa6399be_4bd13e22","line":820,"updated":"2016-10-17 03:05:10.000000000","message":"It seems is_running is not used anymore at other places. This function is to grep the binary name from the output of \"ps auxw\". It\u0027s possible to be misled when other CMDs contain the same string in the command line. If you\u0027d like to use this function, suggest change is_running by making it more accurate: e.g. use something like \"pgrep $binary\".","commit_id":"f7911c5004e3d0743cb72fdca89fd80f03093df7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2b3eab8307809b2b941829dfc35b05376ca8ff3","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    local binary\u003d$2"},{"line_number":818,"context_line":""},{"line_number":819,"context_line":"    # Check to see if the process is already running"},{"line_number":820,"context_line":"    if is_running $binary; then"},{"line_number":821,"context_line":"        echo \"$service is already running\""},{"line_number":822,"context_line":"        return"},{"line_number":823,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fa6399be_af6e3894","line":820,"in_reply_to":"fa6399be_4bd13e22","updated":"2016-10-18 00:06:46.000000000","message":"Yeah, I\u0027ll try pgrep.","commit_id":"f7911c5004e3d0743cb72fdca89fd80f03093df7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92b37066ddac270151a4c715f43ea3276da7b351","unresolved":false,"context_lines":[{"line_number":842,"context_line":"# nova-network process, inluding screen."},{"line_number":843,"context_line":"function start_nova_network {"},{"line_number":844,"context_line":"    if is_service_enabled n-net; then"},{"line_number":845,"context_line":"        enable_kernel_bridge_firewall"},{"line_number":846,"context_line":"        start_nova_process n-net nova-network"},{"line_number":847,"context_line":"    fi"},{"line_number":848,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"fa6399be_873f85d5","line":845,"updated":"2016-10-18 13:03:41.000000000","message":"I\u0027m not sure if this is idempotent.","commit_id":"b6a7480ba7777c470d27ed5ad3278b85b2f26b5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2dc1e3e58627535bac16998903b79d9ac97afa8b","unresolved":false,"context_lines":[{"line_number":903,"context_line":"    # NOTE(mriedem): n-cond and n-net might already be running so we start"},{"line_number":904,"context_line":"    # those using the idempotent start_nova_process function."},{"line_number":905,"context_line":"    start_nova_process n-cond nova-conductor"},{"line_number":906,"context_line":"    run_process n-cell-region \"$NOVA_BIN_DIR/nova-cells --config-file $api_cell_conf\""},{"line_number":907,"context_line":"    run_process n-cell-child \"$NOVA_BIN_DIR/nova-cells --config-file $compute_cell_conf\""},{"line_number":908,"context_line":"    run_process n-crt \"$NOVA_BIN_DIR/nova-cert --config-file $api_cell_conf\""},{"line_number":909,"context_line":"    start_nova_network"},{"line_number":910,"context_line":"    run_process n-sch \"$NOVA_BIN_DIR/nova-scheduler --config-file $compute_cell_conf\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ba5da102_3b625cae","line":907,"range":{"start_line":906,"start_character":4,"end_line":907,"end_character":88},"updated":"2016-11-05 16:58:46.000000000","message":"Hmm, we probably need to start cells first...before nova-net.","commit_id":"34df63f1b554d1eee7863853592ea866cfa2306b"}],"stack.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"625e058f1c76c230ab2956202ba40203e4668299","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"# Launch the nova-api and wait for it to answer before continuing"},{"line_number":1239,"context_line":"if is_service_enabled n-api; then"},{"line_number":1240,"context_line":"    echo_summary \"Starting Nova API\""},{"line_number":1241,"context_line":"    start_nova_api"},{"line_number":1242,"context_line":"fi"},{"line_number":1243,"context_line":""},{"line_number":1244,"context_line":"if is_service_enabled neutron-api; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa6399be_6abc4ebb","line":1241,"updated":"2016-10-15 01:51:37.000000000","message":"nova-api is started here","commit_id":"cac3c32daa2db71876c29c4592c86deaf92bbb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"625e058f1c76c230ab2956202ba40203e4668299","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":1253,"context_line":"        NM_CONF\u003d${NOVA_CELLS_CONF}"},{"line_number":1254,"context_line":"    fi"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"    # Create a small network"},{"line_number":1257,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""},{"line_number":1258,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa6399be_aab2e6e2","line":1255,"updated":"2016-10-15 01:51:37.000000000","message":"Can we restrict this to start just nova-net? Probably also need n-cond...","commit_id":"cac3c32daa2db71876c29c4592c86deaf92bbb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc73f7e491a3a283fa1e408875e529783a315e47","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"    fi"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"    # Create a small network"},{"line_number":1257,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    # Create some floating ips"},{"line_number":1260,"context_line":"    $NOVA_BIN_DIR/nova-manage --config-file $NM_CONF floating create $FLOATING_RANGE --pool\u003d$PUBLIC_NETWORK_NAME"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa6399be_ca7f1a13","line":1257,"updated":"2016-10-15 01:47:30.000000000","message":"Crap, nova-network isn\u0027t running yet when this API call is made:\n\nhttp://logs.openstack.org/55/386855/1/check/gate-tempest-dsvm-full-ubuntu-xenial/099fd9b/logs/screen-n-api.txt.gz#_2016-10-15_00_13_43_937","commit_id":"cac3c32daa2db71876c29c4592c86deaf92bbb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"625e058f1c76c230ab2956202ba40203e4668299","unresolved":false,"context_lines":[{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"if is_service_enabled nova; then"},{"line_number":1273,"context_line":"    echo_summary \"Starting Nova\""},{"line_number":1274,"context_line":"    start_nova"},{"line_number":1275,"context_line":"    create_flavors"},{"line_number":1276,"context_line":"fi"},{"line_number":1277,"context_line":"if is_service_enabled placement; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa6399be_8aafe27b","line":1274,"updated":"2016-10-15 01:51:37.000000000","message":"This starts the other nova services, including nova-net.","commit_id":"cac3c32daa2db71876c29c4592c86deaf92bbb3c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"782a7ea53a9855f4abfcdb514a9827513d0eefe2","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"    fi"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"    echo_summary \"Starting nova-conductor and nova-network\""},{"line_number":1257,"context_line":"    start_nova_cond_and_net"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"    # Create a small network"},{"line_number":1260,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa6399be_3698ff1b","line":1257,"updated":"2016-10-15 12:47:53.000000000","message":"Ah this breaks neutron because we don\u0027t start n-cond in the neutron jobs now.","commit_id":"1361549f34549ff277ec02074d06f0ac71c649ab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac704c184148097fae22d3f3ca215a6e20db5cc1","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"    echo_summary \"Starting Neutron\""},{"line_number":1255,"context_line":"    start_neutron_service_and_check"},{"line_number":1256,"context_line":"elif is_service_enabled $DATABASE_BACKENDS \u0026\u0026 is_service_enabled n-net; then"},{"line_number":1257,"context_line":"    NM_CONF\u003d${NOVA_CONF}"},{"line_number":1258,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":1259,"context_line":"        NM_CONF\u003d${NOVA_CELLS_CONF}"},{"line_number":1260,"context_line":"    fi"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    echo_summary \"Starting nova-network\""},{"line_number":1263,"context_line":"    start_nova_process n-net nova-network"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa6399be_8c5a9af0","line":1260,"range":{"start_line":1257,"start_character":4,"end_line":1260,"end_character":6},"updated":"2016-10-15 15:28:57.000000000","message":"These are no longer used so we can remove them.","commit_id":"7fc4815c4f6914530af2d5bc3b5aa8bbc5530911"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d586a712595977fbd6d44aeff98620c6479188c","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"    start_nova_process n-net nova-network"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    echo \"Waiting for nova-network to be ready...\""},{"line_number":1262,"context_line":"    test_with_retry \"nova network-list\" \"Failed to start nova-network\""},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"    # Create a small network"},{"line_number":1265,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"fa6399be_a77649d6","line":1262,"updated":"2016-10-18 13:01:24.000000000","message":"It looks like when this runs n-api isn\u0027t taking the request:\n\nhttp://logs.openstack.org/55/386855/8/check/gate-tempest-dsvm-full-ubuntu-xenial/a455d90/logs/devstacklog.txt.gz#_2016-10-18_01_26_31_495\n\nhttp://logs.openstack.org/55/386855/8/check/gate-tempest-dsvm-full-ubuntu-xenial/a455d90/logs/screen-n-api.txt.gz#_2016-10-18_01_26_36_897\n\nAnd the n-net service isn\u0027t even going until about 12 seconds after we started it:\n\nhttp://logs.openstack.org/55/386855/8/check/gate-tempest-dsvm-full-ubuntu-xenial/a455d90/logs/screen-n-net.txt.gz#_2016-10-18_01_26_43_762\n\nSo I\u0027ll increase the timeout.","commit_id":"5f875f717cac942cb56c4906a7ecfe3ff9911276"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"33ceab081e84e4cf36247a9d5878af0a465258bb","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"    start_nova_network"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    echo \"Waiting for nova-network to be ready...\""},{"line_number":1262,"context_line":"    test_with_retry \"nova network-list\" \"Failed to start nova-network\" 30 1"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"    # Create a small network"},{"line_number":1265,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"ba5da102_cc770f9e","line":1262,"updated":"2016-11-04 08:36:25.000000000","message":"I think you need something other than \u0027nova network-list\u0027 here since that only triggers a db call in n-api to get the list of networks without ever talking to n-net.","commit_id":"b6a7480ba7777c470d27ed5ad3278b85b2f26b5d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d358fe542aa9896c65d448631c0a7ef1fb9c13de","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"    start_nova_network"},{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    echo \"Waiting for nova-network to be ready...\""},{"line_number":1262,"context_line":"    test_with_retry \"nova network-list\" \"Failed to start nova-network\" 30 1"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"    # Create a small network"},{"line_number":1265,"context_line":"    nova network-create --fixed-range-v4 $FIXED_RANGE \"$PRIVATE_NETWORK_NAME\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"ba5da102_a9f709f4","line":1262,"in_reply_to":"ba5da102_cc770f9e","updated":"2016-11-05 13:12:33.000000000","message":"Good point. Listing DNS domains should do the trick, so I\u0027ll switch to nova dns-domains.","commit_id":"b6a7480ba7777c470d27ed5ad3278b85b2f26b5d"}]}