)]}'
{"id":"openstack%2Fdevstack~39100","triplet_id":"openstack%2Fdevstack~master~Iff1bb557d2ec2caecebf9f93afdfaec275e97671","project":"openstack/devstack","branch":"master","topic":"bug/1206154","hashtags":[],"change_id":"Iff1bb557d2ec2caecebf9f93afdfaec275e97671","subject":"Keep dependencies when replacing packages","status":"ABANDONED","created":"2013-07-29 15:26:54.000000000","updated":"2013-08-03 18:55:09.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"29282196053be8e69167f0a80834c01531f4003f","_number":39100,"virtual_id_number":39100,"owner":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-07-29 16:40:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-07-30 15:41:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2013-08-01 06:12:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":-1,"date":"2013-07-30 00:23:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"date":"2013-07-30 06:13:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-07-30 15:41:40.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"date":"2013-07-30 00:23:03.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-29 16:40:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-07-30 00:23:03.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-07-30 15:41:40.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-08-01 06:12:15.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"}],"messages":[{"id":"8bce9f6565ccba7f84a38e3ed62291d260ce8f63","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-29 16:40:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/00/39100/1/check/gate-tempest-devstack-vm-full/37004 : SUCCESS in 1h 01m 09s\n- http://logs.openstack.org/00/39100/1/check/gate-tempest-devstack-vm-cells-full/3749 : FAILURE in 36m 26s (non-voting)\n- http://logs.openstack.org/00/39100/1/check/gate-tempest-devstack-vm-testr-full/2569 : SUCCESS in 46m 00s (non-voting)\n- http://logs.openstack.org/00/39100/1/check/gate-tempest-devstack-vm-postgres-full/36681 : SUCCESS in 1h 13m 43s\n- http://logs.openstack.org/00/39100/1/check/gate-tempest-devstack-vm-neutron/9064 : FAILURE in 34m 15s (non-voting)\n- http://logs.openstack.org/00/39100/1/check/gate-grenade-devstack-vm/22418 : SUCCESS in 42m 14s\n","accounts_in_message":[],"_revision_number":1},{"id":"85c315f7400f2e0a0a6b3226520861e606298999","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-07-30 00:23:03.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nIt\u0027s also not clear to me that you want to leave the package repo in a broken state like this, as lots of other tools will break later.","accounts_in_message":[],"_revision_number":1},{"id":"0dd45ed11f8412146e9d8d9e8ea6e161993d2132","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-07-30 06:13:50.000000000","message":"Patch Set 1:\n\nWould you pref a fix be to remove the uninstall and leave it with the package manager thinking that they are installed - even if they have the wrong version because pip install will replace them?\n\nRemoving these packages - specifically python-lxml - breaks xenserver-core because yum forcibly removes that too.\n\nClearly it\u0027s only luck that I saw this, and removing these packages at all could cause any number of \u0027breakages\u0027 on the users system by rermoving packages that are expected to be kept without them knowing.","accounts_in_message":[],"_revision_number":1},{"id":"ba0d58ab3db11ce246590bb3efe389ea8cbf3762","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-30 15:41:40.000000000","message":"Patch Set 1:\n\nSigh.  RHEL Python config bites again.\n\nHow do you handle this in a production installation?  We already require EPEL and RDO for a RHEL installation, can you find appropriate packages in either of those repos?\n\nThe idea of upgrading a library underneath something else doesn\u0027t sit well with me.  Doesn\u0027t that also affect vendor supportability requirements?","accounts_in_message":[],"_revision_number":1},{"id":"40e1fc9100a5d2bcec383e923b064760765dd573","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-07-31 12:48:21.000000000","message":"Patch Set 1:\n\nI agree - I guess that production installs are fine because they just use the distro\u0027s packages and don\u0027t need to track lxml or crypto more closely like we do in devstack for gating.\n\nEPEL doesn\u0027t appear to have a newer version of python-lxml (so if the cinder/nova requirements really are for \u003e\u003d2.3 then the 2.2 isn\u0027t high enough) - but I assumed that the primary reason we\u0027re removing it is so we can rely on updating the requirements.txt files ourselves and automatically updating?","accounts_in_message":[],"_revision_number":1},{"id":"2cb5a18bc660742b9f38f6cd5703d288294e6c09","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-07-31 12:51:39.000000000","message":"Patch Set 1:\n\nhttp://repos.fedorapeople.org/repos/openstack/openstack-trunk/ is where I looked for the EPEL/RDO RPMs btw - so it seems as though RDO uses an older version of python-lxml than we \"require\"!","accounts_in_message":[],"_revision_number":1},{"id":"77db42b95d1217bba0d04454236a9e7f3a854085","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-08-01 06:12:15.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI\u0027m not sure this is a good idea; it leaves the package manager in a bit of a weird state.\n\nDo you require the removed packages?  The bug doesn\u0027t explain what the problem is.","accounts_in_message":[],"_revision_number":1},{"id":"480e3ca8ff2e0666a638287138ba1e7f486807f4","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-01 08:54:26.000000000","message":"Patch Set 1:\n\nWe\u0027ve agreed that this probably isn\u0027t the right fix - but I was leaving this open to get more input on the right way.\n\nI know that removing python-lxml forceably removes Xen - but this is a generic issue and devstack shouldn\u0027t be removing packages and potentially breaking someone\u0027s system by also removing the dependencies.","accounts_in_message":[],"_revision_number":1},{"id":"492d2436c34ed4d1b2bff98b0e84697ee1adb873","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-08-01 09:52:16.000000000","message":"Patch Set 1:\n\nThe issue for removing them is (as hopefully explained in the comments) that pip-python on RHEL wants to install any \"aftermarket\" packages right over the top of the existing ones, rather than putting them in /usr/local etc.  Otherwise you could just pip install libxml and the rpm version would be ignored by python.\n\nThe idea of an isolation method isolation method like virtualenv or --user (although [1] makes this hard) seems complex.\n\nCan we have a devstack-rpm repo where we keep some more modern versions around?  Apart from the maintenance version, that seems like the most straight forward solution?\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d961546","accounts_in_message":[],"_revision_number":1},{"id":"133d941eab99fff3a2e24a69af5a5ab56a378cc9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-08-02 05:48:00.000000000","message":"Patch Set 1:\n\n\u003e I know that removing python-lxml forceably removes Xen\n\nWill [1] satisfy this?  By having a dummy python-lxml package installed xen should remain happy; presumably backwards compatibility is such that it will work fine with the version installed from pip.\n\n[1] https://review.openstack.org/#/c/39862/","accounts_in_message":[],"_revision_number":1},{"id":"fdc8549e2b9f756685daaaa5886a88e3e1a02d74","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-03 18:55:09.000000000","message":"Patch Set 1: Abandoned\n\nAgreed with Ian - I think that his patch is significantly safer, so would prefer to see that move forward rather than this one.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9d66adbff6caa2fa44600018a229743b7b64e646","revisions":{"9d66adbff6caa2fa44600018a229743b7b64e646":{"kind":"REWORK","_number":1,"created":"2013-07-29 15:26:54.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/00/39100/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/00/39100/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/39100/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/39100/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/39100/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/00/39100/1"}}},"commit":{"parents":[{"commit":"3f95a3fec8eaed32c88b61e757e2094709ec1b44","subject":"Merge \"xenapi: Setup and Rotate text console logs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3f95a3fec8eaed32c88b61e757e2094709ec1b44"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-07-29 15:22:46.000000000","tz":60},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-07-29 15:26:44.000000000","tz":60},"subject":"Keep dependencies when replacing packages","message":"Keep dependencies when replacing packages\n\nThese packages are being replaced with the equivalent from pip\nso dependencies need not be erased.\n\nFixes bug 1206154\n\nChange-Id: Iff1bb557d2ec2caecebf9f93afdfaec275e97671\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9d66adbff6caa2fa44600018a229743b7b64e646"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9d66adbff6caa2fa44600018a229743b7b64e646"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
