)]}'
{"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"82d51a2b700e874c29bcfdc99401bbef2b0439bb","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        available_flavors\u003d$(nova flavor-list)"},{"line_number":194,"context_line":"        if  [[ -z \"$DEFAULT_INSTANCE_TYPE\" ]]; then"},{"line_number":195,"context_line":"            if [[ ! ( $available_flavors \u003d~ \u0027m1.nano\u0027 ) ]]; then"},{"line_number":196,"context_line":"                openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id 42 --ram 64 --disk 0 --vcpus 1 m1.nano"},{"line_number":197,"context_line":"            fi"},{"line_number":198,"context_line":"            flavor_ref\u003d42"},{"line_number":199,"context_line":"            if [[ ! ( $available_flavors \u003d~ \u0027m1.micro\u0027 ) ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba5da102_eb5c167f","line":196,"updated":"2016-11-02 11:11:13.000000000","message":"The assumption that REGION_NAME is defined seems to be new here and should probably be added to the list at the top. On the other hand, I\u0027m not sure why this is needed at all, when the novaclient command seemed to work without it.\n\nNit: \"--disk 0 --vcpus 1\" is the default and could be omitted.","commit_id":"e33c25cd549c3c45d3cd0bade8aa8337155ab92a"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8c56264670f4657e37239f09516c3abe1ae31258","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        available_flavors\u003d$(nova flavor-list)"},{"line_number":194,"context_line":"        if  [[ -z \"$DEFAULT_INSTANCE_TYPE\" ]]; then"},{"line_number":195,"context_line":"            if [[ ! ( $available_flavors \u003d~ \u0027m1.nano\u0027 ) ]]; then"},{"line_number":196,"context_line":"                openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id 42 --ram 64 --disk 0 --vcpus 1 m1.nano"},{"line_number":197,"context_line":"            fi"},{"line_number":198,"context_line":"            flavor_ref\u003d42"},{"line_number":199,"context_line":"            if [[ ! ( $available_flavors \u003d~ \u0027m1.micro\u0027 ) ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba5da102_0e431843","line":196,"in_reply_to":"ba5da102_eb5c167f","updated":"2016-11-02 11:14:57.000000000","message":"REGION_NAME is present in lib/nova, so I did the same here. Maybe it\u0027s not needed, I don\u0027t know. I\u0027ll wait for the tests to pass, then respin without REGION_NAME to see.\n\n\u003e Nit: \"--disk 0 --vcpus 1\" is the default and could be omitted.\n\nI didn\u0027t know that. I don\u0027t expect anyone to know that, so I\u0027d rather we be explicit (redundant ?) here.","commit_id":"e33c25cd549c3c45d3cd0bade8aa8337155ab92a"}]}