)]}'
{"lib/nova":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b0ce333d7bec23e04e0a32913b19fe181741cab0","unresolved":false,"context_lines":[{"line_number":543,"context_line":"            iniset $NOVA_CONF vnc vencrypt_ca_certs \"/etc/pki/nova-novnc/ca-cert.pem\""},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"            sudo mkdir -p /etc/pki/nova-novnc"},{"line_number":546,"context_line":"            deploy_int_CA /etc/pki/nova-novnc/ca-cert.pem"},{"line_number":547,"context_line":"            deploy_int_cert /etc/pki/nova-novnc/client-cert.pem /etc/pki/nova-novnc/client-key.pem"},{"line_number":548,"context_line":"        fi"},{"line_number":549,"context_line":"    else"},{"line_number":550,"context_line":"        iniset $NOVA_CONF vnc enabled false"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3fa0c359_d3c06f7f","line":547,"range":{"start_line":546,"start_character":12,"end_line":547,"end_character":98},"updated":"2018-02-19 21:56:15.000000000","message":"Is there a particular reason we need to copy the keys around here? Couldn\u0027t we just set the config options above to be out of $INT_CA_DIR?","commit_id":"e9870eb18d19dbb807d4d312cf4aead23c6f8f40"}],"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24e7c77ea8d6da60c9ff663f94975500b0b6c986","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":121,"context_line":"\tif is_service_enabled n-novnc ; then"},{"line_number":122,"context_line":"\t    echo \"vnc_tls \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":123,"context_line":"\t    echo \"vnc_tls_x509_verify \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t    sudo mkdir -p /etc/pki/libvirt-vnc"},{"line_number":126,"context_line":"\t    sudo chown qemu.qemu /etc/pki/libvirt-vnc"},{"line_number":127,"context_line":"\t    deploy_int_CA /etc/pki/libvirt-vnc/ca-cert.pem"},{"line_number":128,"context_line":"\t    deploy_int_cert /etc/pki/libvirt-vnc/server-cert.pem /etc/pki/libvirt-vnc/server-key.pem"},{"line_number":129,"context_line":"\tfi"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Service needs to be started on redhat/fedora -- do a restart for"},{"line_number":133,"context_line":"    # sanity after fiddling the config."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a629dbe_8f01d73a","line":130,"range":{"start_line":121,"start_character":0,"end_line":130,"end_character":2},"updated":"2016-11-10 15:09:26.000000000","message":"whitespace issues here (probably tabs)","commit_id":"bc4329e4ddf15e5f7288bf725fcb93cc0d0bbc10"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"258b19ec124a86abc79b571f5c2f56bb76d911e8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":121,"context_line":"\tif is_service_enabled n-novnc ; then"},{"line_number":122,"context_line":"\t    echo \"vnc_tls \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":123,"context_line":"\t    echo \"vnc_tls_x509_verify \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\t    sudo mkdir -p /etc/pki/libvirt-vnc"},{"line_number":126,"context_line":"\t    sudo chown qemu.qemu /etc/pki/libvirt-vnc"},{"line_number":127,"context_line":"\t    deploy_int_CA /etc/pki/libvirt-vnc/ca-cert.pem"},{"line_number":128,"context_line":"\t    deploy_int_cert /etc/pki/libvirt-vnc/server-cert.pem /etc/pki/libvirt-vnc/server-key.pem"},{"line_number":129,"context_line":"\tfi"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Service needs to be started on redhat/fedora -- do a restart for"},{"line_number":133,"context_line":"    # sanity after fiddling the config."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a629dbe_0f1f876c","line":130,"range":{"start_line":121,"start_character":0,"end_line":130,"end_character":2},"in_reply_to":"9a629dbe_8f01d73a","updated":"2016-11-10 15:11:24.000000000","message":"Yes, fixed in v3","commit_id":"bc4329e4ddf15e5f7288bf725fcb93cc0d0bbc10"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b6e7487777214672cda6e49c519290cae238a46","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":121,"context_line":"        if is_service_enabled n-novnc ; then"},{"line_number":122,"context_line":"            echo \"vnc_tls \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":123,"context_line":"            echo \"vnc_tls_x509_verify \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":124,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_0f514736","line":121,"updated":"2016-11-10 15:13:30.000000000","message":"nit: for my own benefit it would be nice if there was some documentation inline with the changes made here.","commit_id":"740a9703259ded02ceb7cb978960ce32317001f8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1ad121f0e72105c50dbaa6989552216a013b2d62","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":121,"context_line":"        if is_service_enabled n-novnc ; then"},{"line_number":122,"context_line":"            echo \"vnc_tls \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":123,"context_line":"            echo \"vnc_tls_x509_verify \u003d 1\" | sudo tee -a $QEMU_CONF"},{"line_number":124,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_0ad7754b","line":121,"in_reply_to":"9a629dbe_0f514736","updated":"2016-11-10 15:15:24.000000000","message":"I\u0027ve a change up that describes the setup required in openstack-manuals admin-guide:\n\n  https://review.openstack.org/#/c/395729/9\n\nwhat\u0027s done in devstack here is covered there.","commit_id":"740a9703259ded02ceb7cb978960ce32317001f8"}],"stack.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24e7c77ea8d6da60c9ff663f94975500b0b6c986","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    install_os_brick"},{"line_number":810,"context_line":"fi"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"# Setup TLS certs"},{"line_number":813,"context_line":"if is_service_enabled tls-proxy || [ \"$USE_SSL\" \u003d\u003d \"True\" ] || \\"},{"line_number":814,"context_line":"   is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":815,"context_line":"    configure_CA"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a629dbe_245632ce","line":812,"updated":"2016-11-10 15:09:26.000000000","message":"Why did this need to be moved up here? The only change is the additional check for is_nova_console_proxy_compute_tls_enabled.","commit_id":"bc4329e4ddf15e5f7288bf725fcb93cc0d0bbc10"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"258b19ec124a86abc79b571f5c2f56bb76d911e8","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    install_os_brick"},{"line_number":810,"context_line":"fi"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"# Setup TLS certs"},{"line_number":813,"context_line":"if is_service_enabled tls-proxy || [ \"$USE_SSL\" \u003d\u003d \"True\" ] || \\"},{"line_number":814,"context_line":"   is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":815,"context_line":"    configure_CA"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a629dbe_0f3867ee","line":812,"in_reply_to":"9a629dbe_245632ce","updated":"2016-11-10 15:11:24.000000000","message":"The nova_configure step requires that the certificates exist, so it can configure them with libvirt.  The previous location was after the call to nova_configure though.\n\nSo I\u0027ve moved cert creation before the config of services, so that if any services rely on certs existing, they\u0027ll be ok.","commit_id":"bc4329e4ddf15e5f7288bf725fcb93cc0d0bbc10"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1f45f6e54420c0a5bccd8d1e276fea85f4d303ab","unresolved":false,"context_lines":[{"line_number":816,"context_line":"    init_CA"},{"line_number":817,"context_line":"    init_cert"},{"line_number":818,"context_line":"    # Add name to ``/etc/hosts``."},{"line_number":819,"context_line":"    # Don\u0027t be naive and add to existing line!"},{"line_number":820,"context_line":"fi"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"# Install middleware"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a629dbe_0cb4a3cf","line":819,"updated":"2016-11-14 01:09:29.000000000","message":"? weird comment (i know it was there before you got here)","commit_id":"740a9703259ded02ceb7cb978960ce32317001f8"}]}