)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ce530e22173e7a101ef50bb8fec9167b8e6e9f75","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"        # of localrc causes errors."},{"line_number":1774,"context_line":"        return"},{"line_number":1775,"context_line":"    fi"},{"line_number":1776,"context_line":"    DEVSTACK_PLUGINS+\u003d\",$name\""},{"line_number":1777,"context_line":"    GITREPO[$name]\u003d$url"},{"line_number":1778,"context_line":"    GITDIR[$name]\u003d$DEST/$name"},{"line_number":1779,"context_line":"    GITBRANCH[$name]\u003d$branch"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_ace73745","line":1776,"updated":"2016-11-14 00:32:11.000000000","message":"hmm, in other places i\u0027m pretty sure we\u0027ve done \n\n  +\u003d \",$foo,\" \n\nto simplify the matching above.  might be worth standardising on that","commit_id":"923626a25bc49398d80ace7654584525399fb94e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"647c1c6ac1cb934e1615d7e6bfce20b9082aaa7a","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"        # of localrc causes errors."},{"line_number":1774,"context_line":"        return"},{"line_number":1775,"context_line":"    fi"},{"line_number":1776,"context_line":"    DEVSTACK_PLUGINS+\u003d\",$name\""},{"line_number":1777,"context_line":"    GITREPO[$name]\u003d$url"},{"line_number":1778,"context_line":"    GITDIR[$name]\u003d$DEST/$name"},{"line_number":1779,"context_line":"    GITBRANCH[$name]\u003d$branch"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_e8501b61","line":1776,"in_reply_to":"9a629dbe_2f578fcb","updated":"2016-11-14 16:44:09.000000000","message":"Ah that makes sense and makes it a bit cleaner. Thanks.","commit_id":"923626a25bc49398d80ace7654584525399fb94e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0d1b9038b24849b699e98e8a9dd2392769e83a6f","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"        # of localrc causes errors."},{"line_number":1774,"context_line":"        return"},{"line_number":1775,"context_line":"    fi"},{"line_number":1776,"context_line":"    DEVSTACK_PLUGINS+\u003d\",$name\""},{"line_number":1777,"context_line":"    GITREPO[$name]\u003d$url"},{"line_number":1778,"context_line":"    GITDIR[$name]\u003d$DEST/$name"},{"line_number":1779,"context_line":"    GITBRANCH[$name]\u003d$branch"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_2f578fcb","line":1776,"in_reply_to":"9a629dbe_ac2ad72d","updated":"2016-11-14 09:42:33.000000000","message":"ahh, no the trick I think i\u0027m thinking of is \n\n  if [[ ,${DISABLED_SERVICES}, \u003d~ ,${service}, ]];\n\nput commas everywhere so it always matches.  i\u0027d like to see it like that just for consistency","commit_id":"923626a25bc49398d80ace7654584525399fb94e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"ca5fd678fd465b7660b3f49f0c3413cc61f1cff9","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"        # of localrc causes errors."},{"line_number":1774,"context_line":"        return"},{"line_number":1775,"context_line":"    fi"},{"line_number":1776,"context_line":"    DEVSTACK_PLUGINS+\u003d\",$name\""},{"line_number":1777,"context_line":"    GITREPO[$name]\u003d$url"},{"line_number":1778,"context_line":"    GITDIR[$name]\u003d$DEST/$name"},{"line_number":1779,"context_line":"    GITBRANCH[$name]\u003d$branch"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a629dbe_ac2ad72d","line":1776,"in_reply_to":"9a629dbe_ace73745","updated":"2016-11-14 00:46:43.000000000","message":"I couldn\u0027t find any usage of that in function-common or function in my quick search through the code.\n\nAlso checked with:\n $ git grep \u0027\\+\u003d.*,.*,\u0027\n\nWithout any matches to the suggestion.","commit_id":"923626a25bc49398d80ace7654584525399fb94e"}]}