)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34812902970752f4bf49d4a8b5167e297c9b721f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-16 05:26:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Derive IP ranges from new ADDRS_SAFE_TO_USE vars"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The switch to using subnetpools caused quite a bit of confusion"},{"line_number":10,"context_line":"because it didn\u0027t respect the value of FIXED_RANGE. This caused"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_e9c53a8e","line":7,"updated":"2016-11-16 15:44:30.000000000","message":"My only nit is with the name(s), RANGE_SAFE_TO_USE might have matched better, but I have already used my bucket of blue paint today...","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"}],"doc/source/networking.rst":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1de366cb448f4bdcc5fb765e8751d9151c0d3a09","unresolved":false,"context_lines":[{"line_number":104,"context_line":"The private networks addresses are controlled by the ``IPV4_ADDRS_SAFE_TO_USE``"},{"line_number":105,"context_line":"and the ``IPV6_ADDRS_SAFE_TO_USE`` variables. This allows users to specify one"},{"line_number":106,"context_line":"single variable of safe internal IPs to use that will be referenced whether or"},{"line_number":107,"context_line":"not subnetpools are in use."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For IPv4, ``FIXED_RANGE`` and ``SUBNETPOOL_PREFIX_V4`` will just default to"},{"line_number":110,"context_line":"the value of ``IPV4_ADDRS_SAFE_TO_USE`` directly."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_c1083f30","line":107,"updated":"2016-11-17 00:06:38.000000000","message":"Well the way devstack is configured it goes one way or the other (FIXED_RANGE gets used or SUBNETPOOL_PREFIX gets used). But in a normal neutron deployment, you can have networks that use the subnetpools and networks that use legacy \"bring your own address\" subnetting. I\u0027m not sure how much of that nuance we really want to dig into in the devstack guide here.","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"833cd9dea7849bbf125c27e09de41e49c00ecb94","unresolved":false,"context_lines":[{"line_number":104,"context_line":"The private networks addresses are controlled by the ``IPV4_ADDRS_SAFE_TO_USE``"},{"line_number":105,"context_line":"and the ``IPV6_ADDRS_SAFE_TO_USE`` variables. This allows users to specify one"},{"line_number":106,"context_line":"single variable of safe internal IPs to use that will be referenced whether or"},{"line_number":107,"context_line":"not subnetpools are in use."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"For IPv4, ``FIXED_RANGE`` and ``SUBNETPOOL_PREFIX_V4`` will just default to"},{"line_number":110,"context_line":"the value of ``IPV4_ADDRS_SAFE_TO_USE`` directly."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_06bb2d0f","line":107,"updated":"2016-11-16 23:30:42.000000000","message":"so i believe this to be the first instance of the word \"subnetpools\" or discussion of the topic in the whole documentation.\n\nexcept for where we added the \"False\" option with no further explanation in Ic89ceca76afda67da5545111972c3348011f294f\n\nAIUI, and my area of expertise is not in the network setup here, FIXED_RANGE and subnetpools are really mutually exclusive.  i.e. if you\u0027ve got subnetpools you don\u0027t just go and choose a subnet willy-nilly, you ask nicely for one.","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"}],"stackrc":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"053d7e43fe1b6e87ca9148cf59c8627619a6e12c","unresolved":false,"context_lines":[{"line_number":765,"context_line":"# Note that setting ``FIXED_RANGE`` may be necessary when running DevStack"},{"line_number":766,"context_line":"# in an OpenStack cloud that uses either of these address ranges internally."},{"line_number":767,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.0/24}"},{"line_number":768,"context_line":"IPV4_ADDRS_SAFE_TO_USE\u003d${IPV4_ADDRS_SAFE_TO_USE:-10.0.0.0/22}"},{"line_number":769,"context_line":"FIXED_RANGE\u003d${FIXED_RANGE:-$IPV4_ADDRS_SAFE_TO_USE}"},{"line_number":770,"context_line":"FIXED_NETWORK_SIZE\u003d${FIXED_NETWORK_SIZE:-256}"},{"line_number":771,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a77a97e_8a7850c6","line":768,"range":{"start_line":768,"start_character":49,"end_line":768,"end_character":61},"updated":"2016-11-16 08:39:51.000000000","message":"I think we need to avoid any prefix containing the gateway address used by the osic-cloud1 provider, ie. 10.0.0.1. A prefix such as 10.0.4.0/22 would avoid that.\n\n(See I5e4b99c6eb06837be7e1b5a9ed456f57ab6f9514)","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d8c34d75ea0ab68da0d8610d0b1ed8ed9468e29b","unresolved":false,"context_lines":[{"line_number":765,"context_line":"# Note that setting ``FIXED_RANGE`` may be necessary when running DevStack"},{"line_number":766,"context_line":"# in an OpenStack cloud that uses either of these address ranges internally."},{"line_number":767,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.0/24}"},{"line_number":768,"context_line":"IPV4_ADDRS_SAFE_TO_USE\u003d${IPV4_ADDRS_SAFE_TO_USE:-10.0.0.0/22}"},{"line_number":769,"context_line":"FIXED_RANGE\u003d${FIXED_RANGE:-$IPV4_ADDRS_SAFE_TO_USE}"},{"line_number":770,"context_line":"FIXED_NETWORK_SIZE\u003d${FIXED_NETWORK_SIZE:-256}"},{"line_number":771,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a77a97e_cc77c59d","line":768,"range":{"start_line":768,"start_character":49,"end_line":768,"end_character":61},"in_reply_to":"7a77a97e_8a7850c6","updated":"2016-11-16 08:44:42.000000000","message":"The issue is that infra only wants to set 1 var. They are currently setting FIXED_RANGE. \n\nThe reason it collided and you had to come up with a workaround is because the subnetpool behavior is derived from a completely different var than FIXED_RANGE (it\u0027s derived from SUBNETPOOL_PREFIX_V4).\n\nThe point of this change is to unify them under IPV4_ADDRS_SAFE_TO_USE. So devstack-gate will set this based on the addresses they know are safe, and that will affect both FIXED_RANGE and SUBNET_POOL_PREFIX_V4. Then if we add even more in the future, they should also be derived from this so people don\u0027t have to keep setting more vars indicating what is safe to use on their infrastructure.","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"89b69781ace83b65c02a9b057db9a8cfd13df674","unresolved":false,"context_lines":[{"line_number":765,"context_line":"# Note that setting ``FIXED_RANGE`` may be necessary when running DevStack"},{"line_number":766,"context_line":"# in an OpenStack cloud that uses either of these address ranges internally."},{"line_number":767,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.0/24}"},{"line_number":768,"context_line":"IPV4_ADDRS_SAFE_TO_USE\u003d${IPV4_ADDRS_SAFE_TO_USE:-10.0.0.0/22}"},{"line_number":769,"context_line":"FIXED_RANGE\u003d${FIXED_RANGE:-$IPV4_ADDRS_SAFE_TO_USE}"},{"line_number":770,"context_line":"FIXED_NETWORK_SIZE\u003d${FIXED_NETWORK_SIZE:-256}"},{"line_number":771,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a77a97e_52d7cebe","line":768,"range":{"start_line":768,"start_character":49,"end_line":768,"end_character":61},"in_reply_to":"7a77a97e_92e32633","updated":"2016-11-16 09:37:37.000000000","message":"Checkout the stackrc here for FIXED_RANGE: http://logs.openstack.org/12/398012/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4308d38/logs/localrc.txt.gz","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"220ce3eef6ce212e13189da4439dc125607273b2","unresolved":false,"context_lines":[{"line_number":765,"context_line":"# Note that setting ``FIXED_RANGE`` may be necessary when running DevStack"},{"line_number":766,"context_line":"# in an OpenStack cloud that uses either of these address ranges internally."},{"line_number":767,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.0/24}"},{"line_number":768,"context_line":"IPV4_ADDRS_SAFE_TO_USE\u003d${IPV4_ADDRS_SAFE_TO_USE:-10.0.0.0/22}"},{"line_number":769,"context_line":"FIXED_RANGE\u003d${FIXED_RANGE:-$IPV4_ADDRS_SAFE_TO_USE}"},{"line_number":770,"context_line":"FIXED_NETWORK_SIZE\u003d${FIXED_NETWORK_SIZE:-256}"},{"line_number":771,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a77a97e_ef3b93e9","line":768,"range":{"start_line":768,"start_character":49,"end_line":768,"end_character":61},"in_reply_to":"7a77a97e_cc77c59d","updated":"2016-11-16 09:22:17.000000000","message":"Yes, I think I got that. Fungi had been suggesting this possibility when we sorted out our gate issue.\n\nAre you suggesting that setting IPV4_ADDRS_SAFE_TO_USE to a prefix avoiding 10.0.0.1 should be done in an osic-cloud1 specific script or config, rather than in devstack\u0027s stackrc ?","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e3cf95eece6cf952867a8770436f72924fd95e","unresolved":false,"context_lines":[{"line_number":765,"context_line":"# Note that setting ``FIXED_RANGE`` may be necessary when running DevStack"},{"line_number":766,"context_line":"# in an OpenStack cloud that uses either of these address ranges internally."},{"line_number":767,"context_line":"FLOATING_RANGE\u003d${FLOATING_RANGE:-172.24.4.0/24}"},{"line_number":768,"context_line":"IPV4_ADDRS_SAFE_TO_USE\u003d${IPV4_ADDRS_SAFE_TO_USE:-10.0.0.0/22}"},{"line_number":769,"context_line":"FIXED_RANGE\u003d${FIXED_RANGE:-$IPV4_ADDRS_SAFE_TO_USE}"},{"line_number":770,"context_line":"FIXED_NETWORK_SIZE\u003d${FIXED_NETWORK_SIZE:-256}"},{"line_number":771,"context_line":"HOST_IP_IFACE\u003d${HOST_IP_IFACE:-}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a77a97e_92e32633","line":768,"range":{"start_line":768,"start_character":49,"end_line":768,"end_character":61},"in_reply_to":"7a77a97e_ef3b93e9","updated":"2016-11-16 09:27:00.000000000","message":"Yes, IIRC they already do this with FIXED_RANGE","commit_id":"4bfbc291eefd92d8b7885f36275b7ff541e067ab"}]}