)]}'
{"id":"openstack%2Fdevstack~400426","triplet_id":"openstack%2Fdevstack~master~I8c853c35c5b0b61925c27b461ad625266381f73b","project":"openstack/devstack","branch":"master","topic":"allowed_hosts","hashtags":[],"change_id":"I8c853c35c5b0b61925c27b461ad625266381f73b","subject":"Revert \"Always set ALLOWED_HOSTS for horizon\"","status":"MERGED","created":"2016-11-21 22:16:17.000000000","updated":"2016-11-22 15:43:52.000000000","submitted":"2016-11-22 12:18:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a26eacfe0836374e2a43f65dfe304596d2d84d66","_number":400426,"virtual_id_number":400426,"owner":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":2,"date":"2016-11-22 12:18:40.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},{"value":0,"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"all":[{"value":2,"date":"2016-11-21 22:29:40.000000000","_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-21 22:17:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},{"value":1,"date":"2016-11-22 05:30:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},{"value":2,"date":"2016-11-21 22:32:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2016-11-21 22:22:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},{"value":0,"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},{"value":1,"date":"2016-11-21 22:32:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},{"value":0,"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-21 22:17:03.000000000","updated_by":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"reviewer":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"state":"REVIEWER"},{"updated":"2016-11-21 22:22:14.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2016-11-21 22:29:40.000000000","updated_by":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"reviewer":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"state":"REVIEWER"},{"updated":"2016-11-21 22:32:33.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-11-22 05:30:55.000000000","updated_by":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"reviewer":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"state":"REVIEWER"},{"updated":"2016-11-22 12:18:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e44d224de7e00334a4943e934bda393423593787","author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"date":"2016-11-21 22:17:03.000000000","message":"Patch Set 1: Code-Review+1\n\nNeeded to unblock failing tempest tests in Horizon gate.","accounts_in_message":[],"_revision_number":1},{"id":"a8e4b7b51f6899759b4781ba01ee90c55ae32488","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2016-11-21 22:17:52.000000000","message":"Patch Set 1:\n\nThe change breaks horizon in the gate because localhost is used to test horizon. A more appropriate change given that devstack is a dev env, would be ALLOWED_HOSTS\u003d[\u0027*\u0027] which allows all. That\u0027s a bad idea for production, but then again so is devstack.","accounts_in_message":[],"_revision_number":1},{"id":"ab4d25e778cb1149844af2b2899b72a3d2bafaa4","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2016-11-21 22:22:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"301e8474d59ae0bad9dd22a0cd7b2e72e41d717b","author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"date":"2016-11-21 22:29:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6023ffefa4989544ee06eb1d8b3c90b0bce4e7c0","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-11-21 22:32:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"aaee6fe39f3b041871f7f70ce708b91f6b886f87","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2016-11-21 23:14:54.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/26/400426/1/check/tempest-dsvm-full-xenial/778dead/ : SUCCESS in 58m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9b9ab0abbad9abe8eeccc65f53d6da6cccdea61e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 00:09:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/88c4da0/ : SUCCESS in 48m 09s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/f35840b/ : SUCCESS in 35m 26s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-grenade-dsvm-ubuntu-xenial/d4f3fef/ : SUCCESS in 26m 45s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/26/400426/1/check/gate-devstack-docs-ubuntu-xenial/f23b0a3//doc/build/html/ : SUCCESS in 2m 15s\n- gate-devstack-bashate http://logs.openstack.org/26/400426/1/check/gate-devstack-bashate/5008888/ : SUCCESS in 1m 29s\n- gate-devstack-unit-tests http://logs.openstack.org/26/400426/1/check/gate-devstack-unit-tests/6a7a41f/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/26/400426/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/764dd50/ : SUCCESS in 26m 36s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-devstack-dsvm-updown-ubuntu-xenial/3ab3453/ : SUCCESS in 31m 18s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/26/400426/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/8af8392/ : SUCCESS in 47m 08s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/26/400426/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/f487bf9/ : SUCCESS in 21m 54s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial/732509d/ : SUCCESS in 51m 58s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/26/400426/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/4b02424/ : SUCCESS in 37m 12s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/26/400426/1/check/gate-tempest-dsvm-platform-centos7-nv/7fcfd98/ : SUCCESS in 1h 14m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"50a58b51a338629ec3f9595ff2970c5922dadb35","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 00:09:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1f234c32aef201391a7a2f4d67851dd58b94a160","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2016-11-22 00:40:19.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/26/400426/1/check/dsvm-tempest-neutron-network/4efd9d2 : SUCCESS in 2h 08m 37s","accounts_in_message":[],"_revision_number":1},{"id":"0e342ba535e07c539531eea827dd31c3819d100f","author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"date":"2016-11-22 05:30:55.000000000","message":"Patch Set 1: Code-Review+1\n\nAnd I was so happy to have contribution to devstack ;-).\n\nOk. Being serious, I see you already have a solution proposed to work with this, will you take this change and post another change? Or do you expect me to work on this ?","accounts_in_message":[],"_revision_number":1},{"id":"c0067a6e7308d874a5df14b52758fc82aa1cce3f","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2016-11-22 07:08:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/26/400426/1/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/614f069 : SUCCESS in 57m 21s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/26/400426/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/cc6a0ed : SUCCESS in 1h 10m 33s (non-voting)\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/26/400426/1/check/tempest-dsvm-full-nfv-xenial/36684be : SUCCESS in 2h 47m 15s","accounts_in_message":[],"_revision_number":1},{"id":"e7b13dd93adc13c9136058c32e37a4dcf3ce89c0","date":"2016-11-22 12:18:40.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"601a0bef9ac7601883c95d85aae7cce5b2a2cb6e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 12:18:40.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/26/400426/1/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/bc00b64/ : SUCCESS in 1h 11m 48s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/26/400426/1/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/63c7a2b/ : SUCCESS in 51m 04s\n- gate-grenade-dsvm-ubuntu-xenial http://logs.openstack.org/26/400426/1/gate/gate-grenade-dsvm-ubuntu-xenial/bf5e26a/ : SUCCESS in 41m 52s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/26/400426/1/gate/gate-devstack-docs-ubuntu-xenial/900ad9a//doc/build/html/ : SUCCESS in 2m 05s\n- gate-devstack-bashate http://logs.openstack.org/26/400426/1/gate/gate-devstack-bashate/2a704aa/ : SUCCESS in 1m 22s\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/26/400426/1/gate/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/015c6e7/ : SUCCESS in 38m 37s","accounts_in_message":[],"_revision_number":1},{"id":"3d669f566d2ec2714497f63a6832715122de63e2","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2016-11-22 15:43:52.000000000","message":"Patch Set 1:\n\nI\u0027ve re-proposed your original change with David\u0027s suggested edit as I0ab2b57e459dbfa3b01b3e9388bbcefac076a142, but will need to propose a straw-man change for openstack/horizon that has a Depends-On header for it in the commit message so we can confirm whether the previously-impacted functional job is still adversely affected.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2ccd1203423ea29cc7b8c462aa17e18981d32d60","revisions":{"2ccd1203423ea29cc7b8c462aa17e18981d32d60":{"kind":"REWORK","_number":1,"created":"2016-11-21 22:16:17.000000000","uploader":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"ref":"refs/changes/26/400426/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/26/400426/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/26/400426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/26/400426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/26/400426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/26/400426/1"}}},"commit":{"parents":[{"commit":"37f48f3c208de1031ef4589d15194c4079ad4a97","subject":"Always set ALLOWED_HOSTS for horizon","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/37f48f3c208de1031ef4589d15194c4079ad4a97"}]}],"author":{"name":"David Lyle","email":"dklyle0@gmail.com","date":"2016-11-21 22:16:17.000000000","tz":0},"committer":{"name":"David Lyle","email":"dklyle0@gmail.com","date":"2016-11-21 22:16:17.000000000","tz":0},"subject":"Revert \"Always set ALLOWED_HOSTS for horizon\"","message":"Revert \"Always set ALLOWED_HOSTS for horizon\"\n\nThis reverts commit 37f48f3c208de1031ef4589d15194c4079ad4a97.\n\nChange-Id: I8c853c35c5b0b61925c27b461ad625266381f73b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2ccd1203423ea29cc7b8c462aa17e18981d32d60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2ccd1203423ea29cc7b8c462aa17e18981d32d60"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}