)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9dcf4e8fd80dd1cb618a1c0e3436c8c821e52330","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-12-01 17:25:20 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder: really use zookeeper and not the zake fixture"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idca310c08e345db59840eb31434c6cb1f849fa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a71b18c_40a9588f","line":8,"updated":"2016-12-05 23:35:07.000000000","message":"a bit more description in the changelog never goes astray, especially when we\u0027re adding api type functions","commit_id":"91398adc8dff3f592c06e6e54f75120d287af734"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dd15a20c2f29d325ab7e360e29f42c33eceba4ca","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-12-01 17:25:20 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder: really use zookeeper and not the zake fixture"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idca310c08e345db59840eb31434c6cb1f849fa70"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a71b18c_8bb70839","line":8,"in_reply_to":"3a71b18c_40a9588f","updated":"2016-12-06 07:53:17.000000000","message":"Done","commit_id":"91398adc8dff3f592c06e6e54f75120d287af734"}],"inc/python":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"074a4333bc7270f711a9133bd5d0680dbf82ec67","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        die $LINENO \"Can\u0027t find package $package_without_extras in requirements\""},{"line_number":193,"context_line":"    fi"},{"line_number":194,"context_line":"    if [ \"$package\" !\u003d \"$package_without_extras\" ]; then"},{"line_number":195,"context_line":"        required_pkg\u003d$required_pkg$package_extras"},{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":"    echo $required_pkg"},{"line_number":198,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3a71b18c_3cfedc6b","line":195,"updated":"2016-12-01 16:19:15.000000000","message":"having the extras support is good. However for maintainability, I\u0027d rather have a dedicated pip_install_gr_extras that uses get_from_global_requirements, but handles the extras stripping / grafting in the higher level function.","commit_id":"3f67ac47664e26b86bcbbed3bddf25711bde9900"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9dcf4e8fd80dd1cb618a1c0e3436c8c821e52330","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    result\u003d$?"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Also install test requirements"},{"line_number":179,"context_line":"    local test_req\u003d\"${!#}/test-requirements.txt\""},{"line_number":180,"context_line":"    if [[ $result \u003d\u003d 0 ]] \u0026\u0026 [[ -e \"$test_req\" ]]; then"},{"line_number":181,"context_line":"        echo \"Installing test-requirements for $test_req\""},{"line_number":182,"context_line":"        $sudo_pip \\"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a71b18c_40b23807","line":179,"updated":"2016-12-05 23:35:07.000000000","message":"I think that this is just really broken in general for anything that isn\u0027t installed from a directory, but I don\u0027t think that this change makes it any better ... AFAICS it will be trying to install test-requirements from \"foo[extras]/test-requirements.txt\"\n\nso that seems like a regression.  unfortunately this seems like a hard thing to actually get right, maybe we have to parse the arguments :( ?","commit_id":"91398adc8dff3f592c06e6e54f75120d287af734"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"dd15a20c2f29d325ab7e360e29f42c33eceba4ca","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    result\u003d$?"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Also install test requirements"},{"line_number":179,"context_line":"    local test_req\u003d\"${!#}/test-requirements.txt\""},{"line_number":180,"context_line":"    if [[ $result \u003d\u003d 0 ]] \u0026\u0026 [[ -e \"$test_req\" ]]; then"},{"line_number":181,"context_line":"        echo \"Installing test-requirements for $test_req\""},{"line_number":182,"context_line":"        $sudo_pip \\"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a71b18c_90565328","line":179,"in_reply_to":"3a71b18c_40b23807","updated":"2016-12-06 07:53:17.000000000","message":"I agree, this code is already half broken. It installs the test-requirements of the last package instead of all packages passed to pip_install. The same issue is located L138 too.\n\nFor my special case (extra requirements), the code checks if package name is a directory and if the test-requriements.txt file exists so I think we are good.\n\nI have opened a bug to track you remark: https://bugs.launchpad.net/devstack/+bug/1647561\n\nAnd proposed a solution here: https://review.openstack.org/407377","commit_id":"91398adc8dff3f592c06e6e54f75120d287af734"}],"lib/cinder":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"436df1028576142d4a95a7e95ea7e43f3630e79c","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    if is_dlm_enabled; then"},{"line_number":475,"context_line":"        if [[ \"$(dlm_backend)\" \u003d\u003d \"zookeeper\" ]]; then"},{"line_number":476,"context_line":"            pip_install_gr tooz[zookeeper]"},{"line_number":477,"context_line":"            install_package zookeeperd"},{"line_number":478,"context_line":"        fi"},{"line_number":479,"context_line":"    fi"},{"line_number":480,"context_line":"    if [ \"$CINDER_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a71b18c_b02213b8","line":477,"updated":"2016-12-01 15:18:56.000000000","message":"I suspect that this would fail on centos:\nhttps://bugs.launchpad.net/devstack/+bug/1513855","commit_id":"8d8242cae817f4ad362a40d0ac09884357934962"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"66bfd7efa19de3fc1d248532d8feaee396a4f145","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    # Set the backend url according to the configured dlm backend"},{"line_number":378,"context_line":"    if is_dlm_enabled; then"},{"line_number":379,"context_line":"        if [[ \"$(dlm_backend)\" \u003d\u003d \"zookeeper\" ]]; then"},{"line_number":380,"context_line":"            iniset $CINDER_CONF coordination backend_url \"zookeeper://localhost:2181\""},{"line_number":381,"context_line":"        fi"},{"line_number":382,"context_line":"    fi"},{"line_number":383,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3a71b18c_d748615e","line":380,"updated":"2016-12-01 16:24:15.000000000","message":"localhost should probably be $SERVICE_HOST","commit_id":"82faf184c3f1d638d46b95fe238d68af55eaed80"}]}