)]}'
{"stack.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7632d4651359474753865a623805725bc1182750","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Give wider permissions to /opt/stack"},{"line_number":197,"context_line":"    chmod 0777 $DEST"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    echo \"Giving stack user passwordless sudo privileges\""},{"line_number":200,"context_line":"    # UEC images ``/etc/sudoers`` does not have a ``#includedir``, add one"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAQn%2F%2FF8I%3D","line":197,"updated":"2013-08-07 10:41:32.000000000","message":"why a chmod vs. a chown?","commit_id":"0892f60898fdbde3b4a5570cafed0ac6abed0067"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6c92cdf934d67e2da981eab87e6fd3d229287dc8","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Give wider permissions to /opt/stack"},{"line_number":197,"context_line":"    chmod 0777 $DEST"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    echo \"Giving stack user passwordless sudo privileges\""},{"line_number":200,"context_line":"    # UEC images ``/etc/sudoers`` does not have a ``#includedir``, add one"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAQn%2F%2FEnU%3D","line":197,"in_reply_to":"AAAAQn%2F%2FF8I%3D","updated":"2013-08-07 16:07:26.000000000","message":"Over time we\u0027ve started duplicating things with quick fixes like this.  Around line 236 we create $DEST and set up ownership.  Move this down there and use 755.","commit_id":"0892f60898fdbde3b4a5570cafed0ac6abed0067"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"c34f02550ae387d262e6767693cfffd9bbb85136","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Give wider permissions to /opt/stack"},{"line_number":197,"context_line":"    chmod 0777 $DEST"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    echo \"Giving stack user passwordless sudo privileges\""},{"line_number":200,"context_line":"    # UEC images ``/etc/sudoers`` does not have a ``#includedir``, add one"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAQn%2F%2FFZQ%3D","line":197,"in_reply_to":"AAAAQn%2F%2FF8I%3D","updated":"2013-08-07 16:15:48.000000000","message":"The problem is the permissions (see comment) rather than the owner (which isn\u0027t checked by devstack)\n\nI don\u0027t think we want it down with 236 - we don\u0027t want to open it up in all cases - just in this case where the directory is created by RHEL\u0027s useradd.\n\nFrom the commit that added check_path_perm_sanity:\n\"Even though stack.sh is taking over the host, changing permissions\nautomatically is not a nice idea. So we just warn when it looks like\nthis is happening.\"\n\nIf we\u0027re changing the perm in all cases, we should remove this function.","commit_id":"0892f60898fdbde3b4a5570cafed0ac6abed0067"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c266120b66cb68f178d25b7849c5932bd2646082","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # Give wider permissions to /opt/stack"},{"line_number":197,"context_line":"    chmod 0777 $DEST"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    echo \"Giving stack user passwordless sudo privileges\""},{"line_number":200,"context_line":"    # UEC images ``/etc/sudoers`` does not have a ``#includedir``, add one"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAQn%2F%2FEew%3D","line":197,"in_reply_to":"AAAAQn%2F%2FFZQ%3D","updated":"2013-08-07 22:55:07.000000000","message":"The end result no matter the route is that $DEST is mode 0755 and owned by $STACK_USER.\n\nBeing defensive at 236 addresses the case of root creating the stack user as well as making sure whatever happened to already be at $DEST works, which we don\u0027t do today.","commit_id":"0892f60898fdbde3b4a5570cafed0ac6abed0067"}]}