)]}'
{"id":"openstack%2Fdevstack~40583","triplet_id":"openstack%2Fdevstack~master~I908d993dbcd863b482030afcc04e5e7b9f4cffa1","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"I908d993dbcd863b482030afcc04e5e7b9f4cffa1","subject":"Force $DEST to have wider permissions","status":"MERGED","created":"2013-08-07 09:41:58.000000000","updated":"2013-08-13 02:08:04.000000000","submitted":"2013-08-13 02:08:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"af9da25e138a44622440edbf76b2cbf2857c8155","_number":40583,"virtual_id_number":40583,"owner":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-08-13 02:08:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-08-12 14:01:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2013-08-13 01:18:19.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-08-12 14:01:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-08-13 01:18:19.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-07 10:45:42.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2013-08-12 14:01:32.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-08-13 01:18:19.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-08-13 02:08:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ae8e22cae12cc4e807d7d8e1f5bd2e6e352a7850","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-07 10:24:59.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/83/40583/1/check/gate-tempest-devstack-vm-full/ffd2cb5 : SUCCESS in 42m 39s\n- http://logs.openstack.org/83/40583/1/check/gate-tempest-devstack-vm-cells-full/d37102d : FAILURE in 11m 46s (non-voting)\n- http://logs.openstack.org/83/40583/1/check/gate-tempest-devstack-vm-testr-full/c0b9f8c : FAILURE in 28m 55s (non-voting)\n- http://logs.openstack.org/83/40583/1/check/gate-tempest-devstack-vm-postgres-full/eb21181 : SUCCESS in 42m 54s\n- http://logs.openstack.org/83/40583/1/check/gate-tempest-devstack-vm-neutron/cd2a82b : SUCCESS in 17m 13s\n- http://logs.openstack.org/83/40583/1/check/gate-grenade-devstack-vm/53c777a : SUCCESS in 23m 49s\n","accounts_in_message":[],"_revision_number":1},{"id":"7632d4651359474753865a623805725bc1182750","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-08-07 10:41:32.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\ncan you explain the errors that pop up? 777 is always a warning sign for me, so I want to understand more.","accounts_in_message":[],"_revision_number":1},{"id":"bb691b0816e5ae7c03ef589ff92b4e346757d30b","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-07 10:45:31.000000000","message":"Patch Set 1:\n\nhttps://github.com/openstack-dev/devstack/blob/master/functions#L1501\n\nWe check that no element of the path has 0700 which is the default for RHEL - with devstack saying it\u0027s \"very likely to cause fatal issues\".\n\nI was hoping I could reference a bug description - but the change it was introduced in (Change-Id: I9cd70e7fe90638a2a5c3b8fd94756afacac7c7be) doesn\u0027t have a bug reference.","accounts_in_message":[],"_revision_number":1},{"id":"6c92cdf934d67e2da981eab87e6fd3d229287dc8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-07 16:07:26.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\nIIRC Ian added that 0700 check for RHEL, I don\u0027t recall exactly what he encountered that prompted it.","accounts_in_message":[],"_revision_number":1},{"id":"c34f02550ae387d262e6767693cfffd9bbb85136","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-07 16:15:48.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"3a01fdabcdc821fe03635159d154e0e41a78c789","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2013-08-07 22:41:07.000000000","message":"Patch Set 1:\n\nThe problem I was solving was people setting DESTDIR to their homedir (the top google hit for \"devstack tutorial\" or something like that does this, so people follow).  Then horizon was running out of /home but with insufficient permissions for apache to access the files","accounts_in_message":[],"_revision_number":1},{"id":"c266120b66cb68f178d25b7849c5932bd2646082","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-07 22:55:07.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"65e38556f09575b72c7e41ba0404439bf1ee7603","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-09 10:12:58.000000000","message":"Patch Set 1:\n\nIs the consensus that we should always chmod 755 (all elements of $DEST?) and possibly remove the check_path_perm_sanity function which would then be redundant?\n\nOr do you want to just set $DEST itself to 755 in all cases, and then still issue check_path_perm_sanity?","accounts_in_message":[],"_revision_number":1},{"id":"ad2b9a65d7dff91fff8ecf9604d370cb3320ce74","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-09 15:58:40.000000000","message":"Patch Set 1:\n\nBob, the latter.  The case for check_sanity... was when a directory _above_ $DEST was 0700, ie /home/dt is 0700 and DEST\u003d/home/dt/stack.","accounts_in_message":[],"_revision_number":1},{"id":"ae8dae4344520dfc964c7aa8c75dbebe43629de5","author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"date":"2013-08-10 13:51:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"02e930a9efdb2ec0c7a0711b35b9370757d702c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-10 14:33:13.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/83/40583/2/check/gate-tempest-devstack-vm-full/b628895 : SUCCESS in 39m 36s\n- http://logs.openstack.org/83/40583/2/check/gate-tempest-devstack-vm-cells-full/0861ae1 : FAILURE in 10m 12s (non-voting)\n- http://logs.openstack.org/83/40583/2/check/gate-tempest-devstack-vm-testr-full/9590baa : SUCCESS in 24m 05s (non-voting)\n- http://logs.openstack.org/83/40583/2/check/gate-tempest-devstack-vm-postgres-full/7991d05 : SUCCESS in 41m 13s\n- http://logs.openstack.org/83/40583/2/check/gate-tempest-devstack-vm-neutron/2639d63 : SUCCESS in 16m 34s\n- http://logs.openstack.org/83/40583/2/check/gate-grenade-devstack-vm/2bef27a : SUCCESS in 20m 30s\n","accounts_in_message":[],"_revision_number":2},{"id":"91e5fda62f098d11fefe5b4c79fa506fcfef0941","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-12 14:01:32.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"89100d91a983d4632052393fb59ba347acd4ea65","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-08-13 01:18:19.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"2ca80c80a7c8a10e2be72a83a3086b0e2ac6aa2a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-13 01:18:20.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ca172efcbf95af91be0506624d7dd3f92dc70be0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-13 02:08:04.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/83/40583/2/gate/gate-tempest-devstack-vm-full/e51dae2 : SUCCESS in 38m 52s\n- http://logs.openstack.org/83/40583/2/gate/gate-tempest-devstack-vm-postgres-full/c56d75f : SUCCESS in 49m 39s\n- http://logs.openstack.org/83/40583/2/gate/gate-tempest-devstack-vm-neutron/f3b6660 : SUCCESS in 16m 48s\n- http://logs.openstack.org/83/40583/2/gate/gate-grenade-devstack-vm/a3deafe : SUCCESS in 21m 06s\n","accounts_in_message":[],"_revision_number":2},{"id":"af9da25e138a44622440edbf76b2cbf2857c8155","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-13 02:08:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"376b6316608fe72bc4a0bd997e1c94f76b086588","revisions":{"0892f60898fdbde3b4a5570cafed0ac6abed0067":{"kind":"REWORK","_number":1,"created":"2013-08-07 09:41:58.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/83/40583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/83/40583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/83/40583/1"}}},"commit":{"parents":[{"commit":"314ae87a911b457590cd268a6d50872c957de343","subject":"Merge \"xenapi: Add qemu-utils as a cinder dependency\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/314ae87a911b457590cd268a6d50872c957de343"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-07-29 12:10:25.000000000","tz":60},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-08-07 09:41:49.000000000","tz":60},"subject":"/opt/stack should have wider permissions","message":"/opt/stack should have wider permissions\n\nIf we create the stack user, make sure his home directory\nhas wide enough permissions - otherwise stack.sh will\ncomplain that some things might error\n\nChange-Id: I908d993dbcd863b482030afcc04e5e7b9f4cffa1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0892f60898fdbde3b4a5570cafed0ac6abed0067"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0892f60898fdbde3b4a5570cafed0ac6abed0067"}]},"branch":"refs/heads/master"},"376b6316608fe72bc4a0bd997e1c94f76b086588":{"kind":"REWORK","_number":2,"created":"2013-08-10 13:51:54.000000000","uploader":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"ref":"refs/changes/83/40583/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/83/40583/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/83/40583/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/83/40583/2"}}},"commit":{"parents":[{"commit":"73930276bb7136c875e417622cd6db223d2d749c","subject":"Merge \"Show ip address before associating address\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/73930276bb7136c875e417622cd6db223d2d749c"}]}],"author":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-07-29 12:10:25.000000000","tz":60},"committer":{"name":"Bob Ball","email":"bob.ball@citrix.com","date":"2013-08-10 13:49:10.000000000","tz":60},"subject":"Force $DEST to have wider permissions","message":"Force $DEST to have wider permissions\n\nThis is particularly useful in the case where we create the\nhome directory above and the permissions are too strict.\n\nOther users, such as the apache user, need read/execute for this\ndirectory.\n\nChange-Id: I908d993dbcd863b482030afcc04e5e7b9f4cffa1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/376b6316608fe72bc4a0bd997e1c94f76b086588"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/376b6316608fe72bc4a0bd997e1c94f76b086588"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}