)]}'
{"inc/python":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e3c18e00c9d24537655d756a921e28e0063415e5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    time_start \"pip_install\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    local package_dir"},{"line_number":113,"context_line":"    if [[ $# -eq 1 ]]; then"},{"line_number":114,"context_line":"        # We perhaps install a package from a directory, so we set package_dir"},{"line_number":115,"context_line":"        # to install python3 version if required and the test-requirements.txt"},{"line_number":116,"context_line":"        local package_dir_guess\u003d${!#}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_a9535038","line":113,"updated":"2016-12-09 04:58:03.000000000","message":"urgh, this is really really ugly.\n\ni guess we want to maintain compat but clearly the logic is wrong here for multiple packages.\n\n1) could we just make this call only take one package?  that would greatly simplify things\n\n2) could we just loop through the arguments, run \"dirname\" on them, and if the dir \u003d\u003d /opt/stack then we know it\u0027s a git install, rather than a pypi, and to try looking for test-requirements.txt?","commit_id":"e164b8e1f4a83a85fde59983c7f6c193935e58d5"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6f9b4babf769c79fa17c7c01f47b330880e63d46","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    time_start \"pip_install\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    local package_dir"},{"line_number":113,"context_line":"    if [[ $# -eq 1 ]]; then"},{"line_number":114,"context_line":"        # We perhaps install a package from a directory, so we set package_dir"},{"line_number":115,"context_line":"        # to install python3 version if required and the test-requirements.txt"},{"line_number":116,"context_line":"        local package_dir_guess\u003d${!#}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_fad41dbe","line":113,"in_reply_to":"3a71b18c_03217c4d","updated":"2016-12-09 09:55:35.000000000","message":"I finally reverse my change and just update this part to not check $#\n\nbecause pip_install have so many things to supports...\n\npip_install -e /opt/stack/keystone\npip_install /opt/stack/keystone\npip_install tooz[zookeeper]\npip_install foobar barfoo other\n\nperhaps more..","commit_id":"e164b8e1f4a83a85fde59983c7f6c193935e58d5"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"83b20852fdab834a04c25127ca0987a204686cff","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    time_start \"pip_install\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    local package_dir"},{"line_number":113,"context_line":"    if [[ $# -eq 1 ]]; then"},{"line_number":114,"context_line":"        # We perhaps install a package from a directory, so we set package_dir"},{"line_number":115,"context_line":"        # to install python3 version if required and the test-requirements.txt"},{"line_number":116,"context_line":"        local package_dir_guess\u003d${!#}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_03217c4d","line":113,"in_reply_to":"3a71b18c_a9535038","updated":"2016-12-09 08:25:40.000000000","message":"about 1) do you mean like before but I just fix the extra issue ?\n\nabout 2) Looping through the arguments would work for the test-requriements.txt bug, but not for the python3 pip cmdline\n\nWhat is first package is python2 and second is python3.\nCurrently we install both for python2\n\nI will propose a new version that removes the \"optimization\" that installs all packages in one pip command.","commit_id":"e164b8e1f4a83a85fde59983c7f6c193935e58d5"}]}