)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e7fb1cff340d352bff9233796499fe10f5a07e9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint use-service-tokens"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Sarafraj Singh \u003csarafraj.singh@intel.com\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I2d7348c4a72af96c0ed2ef6c0ab75d16e9aec8fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba5201f7_c623e6bb","line":17,"updated":"2017-01-11 15:06:53.000000000","message":"You should have a dependency on the nova change that defines the new config options, so add this to the commit message:\n\nDepends-On: I51eb0a8937fa39a2e5dafb1ad915e7113ea61f72","commit_id":"ef984cccd14480c7131a5e38cfffaac55434c032"}],"lib/nova":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"51e2b7efb485fde8f570c904ff0818cdef68c85b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"USE_SERVICE_TOKEN\u003d$(trueorfalse False USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_9b8e7877","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":17},"updated":"2016-12-15 19:17:50.000000000","message":"Nit: should have NOVA in here I think, like NOVA_USE_SERVICE_TOKEN","commit_id":"449c227e5051ec1e5e40c21c16d7c7f62ca79437"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6f21d6f47a0380d4d70ee9f46d5364e562548e17","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"USE_SERVICE_TOKEN\u003d$(trueorfalse False USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_f10b0dd4","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":17},"in_reply_to":"1a6eadb0_9b8e7877","updated":"2016-12-15 20:17:59.000000000","message":"Done","commit_id":"449c227e5051ec1e5e40c21c16d7c7f62ca79437"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"51e2b7efb485fde8f570c904ff0818cdef68c85b","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    if [ \"$USE_SERVICE_TOKEN\" \u003d\u003d \"True\" ]; then"},{"line_number":632,"context_line":"        init_nova_service_user"},{"line_number":633,"context_line":"}"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"function init_nova_service_user {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_1bf18801","line":632,"updated":"2016-12-15 19:17:50.000000000","message":"yeah, thats the kind of thing I was expecting.","commit_id":"449c227e5051ec1e5e40c21c16d7c7f62ca79437"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"51e2b7efb485fde8f570c904ff0818cdef68c85b","unresolved":false,"context_lines":[{"line_number":637,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":638,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_AUTH_PORT/v3\""},{"line_number":639,"context_line":"    iniset $NOVA_CONF service_user username nova"},{"line_number":640,"context_line":"    iniset $NOVA_CONF service_user password \"$SERVICE_PASSWORD\""},{"line_number":641,"context_line":"    iniset $NOVA_CONF service_user user_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":642,"context_line":"    iniset $NOVA_CONF service_user project_name \"$SERVICE_PROJECT_NAME\""},{"line_number":643,"context_line":"    iniset $NOVA_CONF service_user project_domain_name \"$SERVICE_DOMAIN_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_3bcd64b7","line":640,"range":{"start_line":640,"start_character":46,"end_line":640,"end_character":62},"updated":"2016-12-15 19:17:50.000000000","message":"Where are these defined btw, is that already a thing.","commit_id":"449c227e5051ec1e5e40c21c16d7c7f62ca79437"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6f21d6f47a0380d4d70ee9f46d5364e562548e17","unresolved":false,"context_lines":[{"line_number":637,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":638,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_AUTH_PORT/v3\""},{"line_number":639,"context_line":"    iniset $NOVA_CONF service_user username nova"},{"line_number":640,"context_line":"    iniset $NOVA_CONF service_user password \"$SERVICE_PASSWORD\""},{"line_number":641,"context_line":"    iniset $NOVA_CONF service_user user_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":642,"context_line":"    iniset $NOVA_CONF service_user project_name \"$SERVICE_PROJECT_NAME\""},{"line_number":643,"context_line":"    iniset $NOVA_CONF service_user project_domain_name \"$SERVICE_DOMAIN_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_9101f9b1","line":640,"range":{"start_line":640,"start_character":46,"end_line":640,"end_character":62},"in_reply_to":"1a6eadb0_3bcd64b7","updated":"2016-12-15 20:17:59.000000000","message":"I think these are coming from devstack cfg file.","commit_id":"449c227e5051ec1e5e40c21c16d7c7f62ca79437"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"699f9817a2326fe90354d95cb640986bf7fbb18e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# Other Nova configurations"},{"line_number":165,"context_line":"# ----------------------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da4df55a_3c49e5b7","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":21},"updated":"2016-12-28 21:13:38.000000000","message":"NOVA_USE_SERVICE_TOKEN?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"51fecd19618239d5f787ce6271f6441e2ba6dcdb","unresolved":false,"context_lines":[{"line_number":164,"context_line":"# Other Nova configurations"},{"line_number":165,"context_line":"# ----------------------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_8f44911b","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":21},"in_reply_to":"da4df55a_3c49e5b7","updated":"2017-01-04 20:03:51.000000000","message":"Done","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"4913410be11f3f0c5254b4beff04377c96790d4a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_18c83755","line":170,"range":{"start_line":170,"start_character":43,"end_line":170,"end_character":65},"updated":"2017-01-02 23:20:30.000000000","message":"any reason to make this configurable? Why not just turn it on?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f06b271798b75d4e1126cbd484d93d257a4e1f2a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_5336dd52","line":170,"range":{"start_line":170,"start_character":43,"end_line":170,"end_character":65},"in_reply_to":"ba5201f7_18c83755","updated":"2017-01-04 16:03:39.000000000","message":"Basically this is a common pattern for testing these things. Leave it off by default while we get the tests in place to prove it works OK, and performs OK. Once its on by default, we can deprecate the configuration option and revert this change.","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"51fecd19618239d5f787ce6271f6441e2ba6dcdb","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_af4dd53f","line":170,"range":{"start_line":170,"start_character":43,"end_line":170,"end_character":65},"in_reply_to":"ba5201f7_5336dd52","updated":"2017-01-04 20:03:51.000000000","message":"+1","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"4913410be11f3f0c5254b4beff04377c96790d4a","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # NOTE(jamielennox): Nova doesn\u0027t need the admin role here, however neutron uses"},{"line_number":404,"context_line":"        # this service user when notifying nova of changes and that requires the admin role."},{"line_number":405,"context_line":"        create_service_user \"nova\" \"admin\""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        local nova_api_url"},{"line_number":408,"context_line":"        if [[ \"$NOVA_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_d8b5cfcd","line":405,"updated":"2017-01-02 23:20:30.000000000","message":"This service user.","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"699f9817a2326fe90354d95cb640986bf7fbb18e","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    if [[ \"$NOVA_USE_SERVICE_TOKEN\" \u003d\u003d \"True\" ]]; then"},{"line_number":632,"context_line":"        init_nova_service_user"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da4df55a_fcd91df4","line":631,"range":{"start_line":631,"start_character":7,"end_line":631,"end_character":9},"updated":"2016-12-28 21:13:38.000000000","message":"Single [ here, like with NOVA_ALLOW_MOVE_TO_SAME_HOST?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"51fecd19618239d5f787ce6271f6441e2ba6dcdb","unresolved":false,"context_lines":[{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    iniset $NOVA_CONF DEFAULT dhcpbridge_flagfile \"$NOVA_CONF_DIR/nova-dhcpbridge.conf\""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    if [[ \"$NOVA_USE_SERVICE_TOKEN\" \u003d\u003d \"True\" ]]; then"},{"line_number":632,"context_line":"        init_nova_service_user"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_cf4a1926","line":631,"range":{"start_line":631,"start_character":7,"end_line":631,"end_character":9},"in_reply_to":"da4df55a_fcd91df4","updated":"2017-01-04 20:03:51.000000000","message":"Done","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"4913410be11f3f0c5254b4beff04377c96790d4a","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    if [[ \"$NOVA_USE_SERVICE_TOKEN\" \u003d\u003d \"True\" ]]; then"},{"line_number":632,"context_line":"        init_nova_service_user"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":"}"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"function init_nova_service_user {"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_f8ca934e","line":633,"range":{"start_line":633,"start_character":0,"end_line":633,"end_character":4},"updated":"2017-01-02 23:20:30.000000000","message":"nova already has a service user (noted above). Why another?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a0cb67d551284aec98bbb14915d3f57459d5dbe2","unresolved":false,"context_lines":[{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    if [[ \"$NOVA_USE_SERVICE_TOKEN\" \u003d\u003d \"True\" ]]; then"},{"line_number":632,"context_line":"        init_nova_service_user"},{"line_number":633,"context_line":"    fi"},{"line_number":634,"context_line":"}"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"function init_nova_service_user {"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_b369c927","line":633,"range":{"start_line":633,"start_character":0,"end_line":633,"end_character":4},"in_reply_to":"ba5201f7_f8ca934e","updated":"2017-01-04 16:07:22.000000000","message":"This doesn\u0027t create a user, this is reusing the user created on ln405.\n\nNow the name is confusing I guess. Maybe rename init_nova_service_user to init_nova_service_user_conf?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f660211cc8b428cf66308baa4829e7a8ba0d087","unresolved":false,"context_lines":[{"line_number":636,"context_line":"function init_nova_service_user {"},{"line_number":637,"context_line":"    iniset $NOVA_CONF service_user send_service_user_token True"},{"line_number":638,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":639,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_AUTH_PORT/v3\""},{"line_number":640,"context_line":"    iniset $NOVA_CONF service_user username nova"},{"line_number":641,"context_line":"    iniset $NOVA_CONF service_user password \"$SERVICE_PASSWORD\""},{"line_number":642,"context_line":"    iniset $NOVA_CONF service_user user_domain_name \"$SERVICE_DOMAIN_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da4df55a_dcfb7977","line":639,"range":{"start_line":639,"start_character":117,"end_line":639,"end_character":119},"updated":"2016-12-28 20:52:44.000000000","message":"Doesn\u0027t this depend on how devstack is configured for keystone? Or is keystone v3 required and guaranteed to always be configured/enabled since keystone v2 is deprecated?","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"51fecd19618239d5f787ce6271f6441e2ba6dcdb","unresolved":false,"context_lines":[{"line_number":636,"context_line":"function init_nova_service_user {"},{"line_number":637,"context_line":"    iniset $NOVA_CONF service_user send_service_user_token True"},{"line_number":638,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":639,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_AUTH_PORT/v3\""},{"line_number":640,"context_line":"    iniset $NOVA_CONF service_user username nova"},{"line_number":641,"context_line":"    iniset $NOVA_CONF service_user password \"$SERVICE_PASSWORD\""},{"line_number":642,"context_line":"    iniset $NOVA_CONF service_user user_domain_name \"$SERVICE_DOMAIN_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_0f5181d8","line":639,"range":{"start_line":639,"start_character":117,"end_line":639,"end_character":119},"in_reply_to":"da4df55a_dcfb7977","updated":"2017-01-04 20:03:51.000000000","message":"Done","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"4913410be11f3f0c5254b4beff04377c96790d4a","unresolved":false,"context_lines":[{"line_number":636,"context_line":"function init_nova_service_user {"},{"line_number":637,"context_line":"    iniset $NOVA_CONF service_user send_service_user_token True"},{"line_number":638,"context_line":"    iniset $NOVA_CONF service_user auth_type password"},{"line_number":639,"context_line":"    iniset $NOVA_CONF service_user auth_url \"$KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_AUTH_PORT/v3\""},{"line_number":640,"context_line":"    iniset $NOVA_CONF service_user username nova"},{"line_number":641,"context_line":"    iniset $NOVA_CONF service_user password \"$SERVICE_PASSWORD\""},{"line_number":642,"context_line":"    iniset $NOVA_CONF service_user user_domain_name \"$SERVICE_DOMAIN_NAME\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ba5201f7_78b6a3dd","line":639,"range":{"start_line":639,"start_character":117,"end_line":639,"end_character":119},"in_reply_to":"da4df55a_dcfb7977","updated":"2017-01-02 23:20:30.000000000","message":"yea, when using auth_type\u003dpassword you don\u0027t need to specify a version on the URL","commit_id":"779b1325852e0ed5df799c75c88e1b3ac77d0ed1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12436179bba63194f401925325f20a70c43f0fb4","unresolved":false,"context_lines":[{"line_number":165,"context_line":"# ----------------------------"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# ``NOVA_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"ba5201f7_fc54ddc6","line":168,"range":{"start_line":168,"start_character":50,"end_line":168,"end_character":55},"updated":"2017-01-12 02:01:07.000000000","message":"nit: just \"APIs\"","commit_id":"14e16e42f95cd02aaee1db0d5357027ea81a50e2"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e03311e9e996650e4f408c3b57b7b3bbab5e4829","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``NOVA_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_51e8e37c","line":170,"range":{"start_line":170,"start_character":25,"end_line":170,"end_character":36},"updated":"2017-02-20 15:59:02.000000000","message":"Why default off?","commit_id":"14e16e42f95cd02aaee1db0d5357027ea81a50e2"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"30e141932d7dbdef586a1afeec18704a68c89d8c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# ``NOVA_USE_SERVICE_TOKEN`` is a mode where service token is passed along with"},{"line_number":168,"context_line":"# user token while communicating to external RESP API\u0027s like Neutron, Cinder"},{"line_number":169,"context_line":"# and Glance."},{"line_number":170,"context_line":"NOVA_USE_SERVICE_TOKEN\u003d$(trueorfalse False NOVA_USE_SERVICE_TOKEN)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Functions"},{"line_number":173,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_31c1afe5","line":170,"range":{"start_line":170,"start_character":25,"end_line":170,"end_character":36},"in_reply_to":"da36d5c6_51e8e37c","updated":"2017-02-20 16:00:05.000000000","message":"just saw i made the same comment on an earlier review and it was discussed, so nevermind.","commit_id":"14e16e42f95cd02aaee1db0d5357027ea81a50e2"}]}