)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d937622bb75da12c10e2524c6842d176e49b1141","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"stack.sh doesn\u0027t support shared nova instance path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduces parameter SHARED_INSTANCE_DIR."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Nova\u0027s instances directory may be a shared directory (ie nfs), in"},{"line_number":12,"context_line":"these cases, we do not want to clean out the directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_36832a9a","line":9,"updated":"2017-02-22 03:34:46.000000000","message":"This is grammatically incorrect as well as being incomplete.  Please describe what SHARED_INSTANCE_DIR can be set to, and what the behaviour will be with the various settings.","commit_id":"de2b25a0c12ce975540376e0b968f57a75b68e9e"}],"lib/nova":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d937622bb75da12c10e2524c6842d176e49b1141","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    else"},{"line_number":227,"context_line":"        # do not delete $NOVA_INSTANCES_PATH"},{"line_number":228,"context_line":"        find $NOVA_STATE_PATH |grep -v \"^$NOVA_INSTANCES_PATH\"| while read i; do"},{"line_number":229,"context_line":"            if test \"${NOVA_INSTANCES_PATH##$i}\" \u003d \"${NOVA_INSTANCES_PATH}\"; then"},{"line_number":230,"context_line":"                sudo rm -rf $i"},{"line_number":231,"context_line":"            fi"},{"line_number":232,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da36d5c6_36088a2c","line":229,"updated":"2017-02-22 03:34:46.000000000","message":"The existing convention in this file seems to be to use square brackets instead of \"test\".","commit_id":"de2b25a0c12ce975540376e0b968f57a75b68e9e"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6ff8c8c9fcdd234fe809fbbac6e82bce996b6891","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        sudo rm -rf $NOVA_STATE_PATH"},{"line_number":226,"context_line":"    else"},{"line_number":227,"context_line":"        # do not delete $NOVA_INSTANCES_PATH"},{"line_number":228,"context_line":"        find $NOVA_STATE_PATH |grep -v \"^$NOVA_INSTANCES_PATH\"| while read i; do"},{"line_number":229,"context_line":"            if [ \"${NOVA_INSTANCES_PATH##$i}\" \u003d\u003d \"${NOVA_INSTANCES_PATH}\" ]; then"},{"line_number":230,"context_line":"                sudo rm -rf $i"},{"line_number":231,"context_line":"            fi"},{"line_number":232,"context_line":"        done"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da36d5c6_62e4d7e0","line":231,"range":{"start_line":228,"start_character":8,"end_line":231,"end_character":14},"updated":"2017-02-22 20:51:38.000000000","message":"this could maybe use a more extensive comment.  what are the relationships between NOVA_STATE_PATH and NOVA_INSTANCES_PATH that you need to deal with?","commit_id":"7c883d6aab13b74bf855f8484d26da35db6d49e7"},{"author":{"_account_id":23122,"name":"Amy Fong","email":"amy.fong@windriver.com","username":"afong"},"change_message_id":"1574cd5f3dc954932a7262f5704f40dc2fa1beec","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        sudo rm -rf $NOVA_STATE_PATH"},{"line_number":226,"context_line":"    else"},{"line_number":227,"context_line":"        # do not delete $NOVA_INSTANCES_PATH"},{"line_number":228,"context_line":"        find $NOVA_STATE_PATH |grep -v \"^$NOVA_INSTANCES_PATH\"| while read i; do"},{"line_number":229,"context_line":"            if [ \"${NOVA_INSTANCES_PATH##$i}\" \u003d\u003d \"${NOVA_INSTANCES_PATH}\" ]; then"},{"line_number":230,"context_line":"                sudo rm -rf $i"},{"line_number":231,"context_line":"            fi"},{"line_number":232,"context_line":"        done"},{"line_number":233,"context_line":"    fi"},{"line_number":234,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da36d5c6_876ab4ec","line":231,"range":{"start_line":228,"start_character":8,"end_line":231,"end_character":14},"in_reply_to":"da36d5c6_62e4d7e0","updated":"2017-02-23 02:21:58.000000000","message":"Done","commit_id":"7c883d6aab13b74bf855f8484d26da35db6d49e7"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"22dab41a0b54340db45b696f9f61643490129b86","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    else"},{"line_number":227,"context_line":"        # do not delete $NOVA_INSTANCES_PATH (or subdir) - grepping out $NOVA_INSTANCES_PATH"},{"line_number":228,"context_line":"        find $NOVA_STATE_PATH |grep -v \"^$NOVA_INSTANCES_PATH\"| while read i; do"},{"line_number":229,"context_line":"            # make sure we\u0027re not deleting parent directories of $NOVA_INSTANCES_PATH"},{"line_number":230,"context_line":"            if [ \"${NOVA_INSTANCES_PATH##$i}\" \u003d \"${NOVA_INSTANCES_PATH}\" ]; then"},{"line_number":231,"context_line":"                sudo rm -rf $i"},{"line_number":232,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da36d5c6_645da846","line":229,"updated":"2017-02-23 15:51:23.000000000","message":"It seems that the code is instead deleting subdirectories of NOVA_INSTANCES_PATH.  Are there possibly paths under NOVA_STATE_PATH that are not parent directories of NOVA_INSTANCES_PATH?\n\n(Also, is NOVA_INSTANCES_PATH guaranteed to end with a forward slash?  if not, do we run the risk of the following test failing due to an extra forward slash?)","commit_id":"9de482f532431188a8daca4d2e71cf1baa04b4e5"},{"author":{"_account_id":23122,"name":"Amy Fong","email":"amy.fong@windriver.com","username":"afong"},"change_message_id":"98c13e91a10fe87a419a196e41d7d7347534b953","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    else"},{"line_number":227,"context_line":"        # do not delete $NOVA_INSTANCES_PATH (or subdir) - grepping out $NOVA_INSTANCES_PATH"},{"line_number":228,"context_line":"        find $NOVA_STATE_PATH |grep -v \"^$NOVA_INSTANCES_PATH\"| while read i; do"},{"line_number":229,"context_line":"            # make sure we\u0027re not deleting parent directories of $NOVA_INSTANCES_PATH"},{"line_number":230,"context_line":"            if [ \"${NOVA_INSTANCES_PATH##$i}\" \u003d \"${NOVA_INSTANCES_PATH}\" ]; then"},{"line_number":231,"context_line":"                sudo rm -rf $i"},{"line_number":232,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da36d5c6_cf4bcd85","line":229,"in_reply_to":"da36d5c6_645da846","updated":"2017-02-23 16:07:52.000000000","message":"The grep -v should be removing the subdirectories of NOVA_INSTANCES_PATH.\n\nYes - on the paths under NOVA_STATE_PATHS not being parent directories of NOVA_INSTANCES_PATH\n\nIt would probably be a good idea to cleanup NOVA_STATE_PATH and NOVA_INSTANCES_PATH before hand (ie canonize)","commit_id":"9de482f532431188a8daca4d2e71cf1baa04b4e5"}]}