)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f4344aa32f8f6591e1d8e68c30abc7f43133cabb","unresolved":false,"context_lines":[{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage cell_v2 discover_hosts --cell_uuid $cell_uuid"},{"line_number":955,"context_line":"        nova-manage db sync"},{"line_number":956,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba5201f7_32fa0176","line":953,"range":{"start_line":953,"start_character":8,"end_line":953,"end_character":17},"updated":"2017-01-05 17:26:18.000000000","message":"We should check to see that this is set before using it, because map_cell_and_hosts is failing but we\u0027re still calling discover_hosts.\n\nPlus, as noted, it looks like we need to do this call with the nova-cells.conf.","commit_id":"f613da8966d6e128e44009bc3c7acc9fcb8a1502"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8b2d347a5a777de33ab9802d652f7447045286d","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --config-file $NOVA_CELLS_CONF  --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage db sync"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5201f7_120fbd88","line":951,"range":{"start_line":951,"start_character":39,"end_line":951,"end_character":46},"updated":"2017-01-05 17:27:56.000000000","message":"Why do we not care if map_cell0 fails?","commit_id":"9d1962524eec2cedbcc1ec91d88082de8af18050"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4940bfac626edf780e2dbead32ac5f8cbf764e2a","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":949,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --config-file $NOVA_CELLS_CONF  --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage db sync"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5201f7_123eddd9","line":951,"range":{"start_line":951,"start_character":39,"end_line":951,"end_character":46},"in_reply_to":"ba5201f7_120fbd88","updated":"2017-01-05 17:32:37.000000000","message":"We do, but right now it always returns 1. Remember this (unmerged patch) and the revelation about map_cell0 in it?\n\nhttps://review.openstack.org/#/c/409890/1/nova/cmd/manage.py","commit_id":"9d1962524eec2cedbcc1ec91d88082de8af18050"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8b2d347a5a777de33ab9802d652f7447045286d","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        nova-manage cell_v2 simple_cell_setup --transport-url $(get_transport_url)"},{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --config-file $NOVA_CELLS_CONF  --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage db sync"},{"line_number":955,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5201f7_b261913b","line":952,"updated":"2017-01-05 17:27:56.000000000","message":"nit: would be nice to use \\ to break this line up.","commit_id":"9d1962524eec2cedbcc1ec91d88082de8af18050"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b8b2d347a5a777de33ab9802d652f7447045286d","unresolved":false,"context_lines":[{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --config-file $NOVA_CELLS_CONF  --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage db sync"},{"line_number":955,"context_line":"    fi"},{"line_number":956,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5201f7_526ce534","line":953,"range":{"start_line":953,"start_character":8,"end_line":953,"end_character":60},"updated":"2017-01-05 17:27:56.000000000","message":"This is no longer used.","commit_id":"9d1962524eec2cedbcc1ec91d88082de8af18050"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4940bfac626edf780e2dbead32ac5f8cbf764e2a","unresolved":false,"context_lines":[{"line_number":950,"context_line":"    else"},{"line_number":951,"context_line":"        (nova-manage cell_v2 map_cell0 || true)"},{"line_number":952,"context_line":"        nova-manage cell_v2 map_cell_and_hosts --transport-url $(get_transport_url) --name \u0027cell1\u0027 --config-file $NOVA_CELLS_CONF  --verbose | tee /tmp/nova-cell-setup.log"},{"line_number":953,"context_line":"        cell_uuid\u003d$(cat /tmp/nova-cell-setup.log | tail -n1)"},{"line_number":954,"context_line":"        nova-manage db sync"},{"line_number":955,"context_line":"    fi"},{"line_number":956,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ba5201f7_922acd8e","line":953,"range":{"start_line":953,"start_character":8,"end_line":953,"end_character":60},"in_reply_to":"ba5201f7_526ce534","updated":"2017-01-05 17:32:37.000000000","message":"Yep, thanks","commit_id":"9d1962524eec2cedbcc1ec91d88082de8af18050"}]}