)]}'
{"id":"openstack%2Fdevstack~420906","triplet_id":"openstack%2Fdevstack~master~Id0fb170294d127f923b4bde487eed0e0755a0f71","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"Id0fb170294d127f923b4bde487eed0e0755a0f71","subject":"Revert \"lib/tempest: allow tweaking volume-feature-enabled/manage_snapshot\"","status":"ABANDONED","created":"2017-01-16 18:42:51.000000000","updated":"2017-01-18 19:31:43.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23f529ea5a71bd990c5af966dd73b63d870f8033","_number":420906,"virtual_id_number":420906,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-01-16 21:06:14.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2017-01-16 20:46:36.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},{"value":1,"date":"2017-01-16 20:41:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-01-16 20:48:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"date":"2017-01-16 22:40:22.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},{"date":"2017-01-17 05:23:17.000000000","_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":1,"date":"2017-01-16 18:45:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2017-01-16 19:02:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},{"value":1,"date":"2017-01-17 18:05:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2017-01-16 19:06:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2017-01-16 19:12:49.000000000","_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-16 18:45:20.000000000","updated_by":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"reviewer":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"state":"REVIEWER"},{"updated":"2017-01-16 19:02:39.000000000","updated_by":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"reviewer":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"state":"REVIEWER"},{"updated":"2017-01-16 19:06:49.000000000","updated_by":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"reviewer":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"state":"REVIEWER"},{"updated":"2017-01-16 19:12:49.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2017-01-16 20:41:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-16 20:46:36.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-01-16 20:48:34.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-01-16 22:40:22.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-01-17 05:23:17.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2017-01-17 18:05:56.000000000","updated_by":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"reviewer":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"state":"REVIEWER"}],"messages":[{"id":"65feea571ab8a7463367497254c09bc6c57c97b4","author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"date":"2017-01-16 18:45:20.000000000","message":"Patch Set 1: Code-Review+1\n\nKaminario CI was also failing.","accounts_in_message":[],"_revision_number":1},{"id":"0ab05727047b258c4be57ac3a01ab26c0b73a653","author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"date":"2017-01-16 19:02:39.000000000","message":"Patch Set 1: Code-Review+1\n\nWe are facing CI issues without this patch","accounts_in_message":[],"_revision_number":1},{"id":"40a56f056fbde8ea7ae3a25888ba2471209d4ab7","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-01-16 19:06:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0ac94014d971ebf4a64e3d8aa329045c77f55bcf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-16 20:41:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/a2ad723/ : SUCCESS in 1h 00m 04s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/06/420906/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/f0ff400/ : SUCCESS in 33m 22s\n- gate-devstack-docs-ubuntu-xenial http://docs-draft.openstack.org/06/420906/1/check/gate-devstack-docs-ubuntu-xenial/bc1d008//doc/build/html/ : SUCCESS in 1m 26s\n- gate-devstack-bashate http://logs.openstack.org/06/420906/1/check/gate-devstack-bashate/0c7acd5/ : SUCCESS in 1m 26s\n- gate-devstack-unit-tests http://logs.openstack.org/06/420906/1/check/gate-devstack-unit-tests/02cf425/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/4e8eeb3/ : SUCCESS in 27m 08s (non-voting)\n- gate-devstack-dsvm-updown-ubuntu-xenial http://logs.openstack.org/06/420906/1/check/gate-devstack-dsvm-updown-ubuntu-xenial/555cbad/ : SUCCESS in 29m 57s\n- gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-devstack-dsvm-py35-updown-ubuntu-xenial-nv/bb8f087/ : SUCCESS in 26m 33s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/af8213d/ : SUCCESS in 55m 04s (non-voting)\n- gate-swift-dsvm-functional-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-swift-dsvm-functional-ubuntu-xenial-nv/0dd0963/ : SUCCESS in 33m 07s (non-voting)\n- gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/7522156/ : SUCCESS in 1h 03m 24s (non-voting)\n- gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/353ca40/ : SUCCESS in 1h 07m 07s (non-voting)\n- gate-grenade-dsvm-neutron-multinode-ubuntu-xenial http://logs.openstack.org/06/420906/1/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/225b35b/ : SUCCESS in 37m 09s\n- gate-tempest-dsvm-platform-ubuntu-trusty http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-platform-ubuntu-trusty/ad591d8/ : SUCCESS in 1h 29m 35s\n- gate-tempest-dsvm-platform-centos7-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-platform-centos7-nv/9cfb80e/ : FAILURE in 1h 09m 02s (non-voting)\n- gate-tempest-dsvm-platform-fedora24-nv http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-platform-fedora24-nv/30e0eb6/ : FAILURE in 1h 48m 42s (non-voting)\n- gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial http://logs.openstack.org/06/420906/1/check/gate-tempest-dsvm-neutron-linuxbridge-ubuntu-xenial/eedf4a5/ : SUCCESS in 55m 24s","accounts_in_message":[],"_revision_number":1},{"id":"cb7eeedbe8ec62b87b282cc8fd0d137aaf948fab","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2017-01-16 20:46:36.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/06/420906/1/check/dsvm-tempest-neutron-network/2d05d30 : SUCCESS in 1h 48m 00s","accounts_in_message":[],"_revision_number":1},{"id":"67977384b1e1b90940c3232945adf691b4012b71","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2017-01-16 20:48:34.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/06/420906/1/check/tempest-dsvm-full-xenial/89a5495/ : SUCCESS in 1h 05m 55s","accounts_in_message":[],"_revision_number":1},{"id":"7872cdd96d1be2fac27a82bca20668dbdc0d6ff5","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2017-01-16 20:51:53.000000000","message":"Patch Set 1:\n\nApoorva, nikesh you can\u0027t seriously say that this patch causes issue for your CI given that you just have to set a boolean value to False to skip the tests. \n\n@Patrick, I am sure the Tempest test is not perfect but I\u0027ll happy to quickly merge any improvement. In the mean time, the current test successfully test the Cinder API for manage/unmanage snaps and successfully test the LVM driver for the same feature.\n\nI am no going to -1, but I don\u0027t understand how 3rd party CI maintainers could be serious if they can\"t set a boolean flag to False in their systems.","accounts_in_message":[],"_revision_number":1},{"id":"833193bf277d61183b68672fb7ebcbf11819ddb6","author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"date":"2017-01-16 21:01:54.000000000","message":"Patch Set 1:\n\nJordan,\n\nI have following in my local.conf\nTEMPEST_MANAGE_SNAPSHOT\u003dFalse\n\nbut it\u0027s getting overriden as true in tempest.conf http://openstack-ci.tintri.com/tintri/refs-changes-34-412534-11/logs/tempest.conf\n\nAm I doing anything wrong here?","accounts_in_message":[],"_revision_number":1},{"id":"eb5faaac28f7d7691c4ea683963e9db6abc88556","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-01-16 21:06:14.000000000","message":"Patch Set 1:\n\nJordan, I think the issue is more that the test itself is flawed and maybe we should go back to the patch I put up to revert it completely.\n\nAs is, this is only a test for the LVM driver. So it should either be updated to only run if the backend is LVM, or it should be removed and we should just stick to a functional test in cinder.\n\nThere are actual deployments that use LVM, but in probably the majority of the cases, if someone were to run this to validate their cloud, they are going to get incorrect and confusing results.\n\nGranted, if using devstack it is easy to set a flag, but this is just yet another non-obvious detail that most will not know until they hit a failure and waste time (both theirs and others by needing to ask around to find out the answer) to know they need to change the default config to add a flag.\n\nIt does not make sense to me to have a default that works for one at the expense of many, rather than having something that is good for many with just one needing to change.","accounts_in_message":[],"_revision_number":1},{"id":"aa01c316f93a067a13e91bebd63035a72a0b37d5","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-01-16 22:15:47.000000000","message":"Patch Set 1:\n\nThanks Sean, to add some more context around *why* that test is rubbing the cinder team wrong (since our explanations are not seeming to stick)... looking over here https://github.com/openstack/tempest/blob/3125625e0f7904f138e1ed0c5a9e5321c68f686c/tempest/api/volume/admin/v2/test_snapshot_manage.py#L60-L63 that \"snapshot_ref\" and in turn \"ref\" that is passed in to the Cinder API are 100% guesswork based on knowledge of how LVM implements its volume/snapshot naming and manage snapshot driver method.... it will almost never work for other backends, and there is no requirement for other backends to work the same way when supporting the manage/unmanage functionality.\n\nAs an analogy,  Its like having a tempest test that predicts and validates xml the libvirt driver might generate and then expecting it should work on hyper-v and xenserver too because they all support the same nova apis to boot vm\u0027s.","accounts_in_message":[],"_revision_number":1},{"id":"c82b4ab7235a3fd3aca014a4fca659cd67b543e8","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2017-01-16 22:40:22.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline). To recheck leave a comment with \u0027intel-nfv-ci recheck\u0027. For more info go to https://wiki.openstack.org/wiki/ThirdPartySystems/Intel_NFV_CI.\n\n- tempest-dsvm-full-nfv-xenial http://intel-openstack-ci-logs.ovh/2017-01-16/420906/1/check/tempest-dsvm-full-nfv-xenial/b1a8623 : FAILURE in 1h 22m 56s\n- tempest-dsvm-ovsdpdk-nfv-networking-centos http://intel-openstack-ci-logs.ovh/2017-01-16/420906/1/check/tempest-dsvm-ovsdpdk-nfv-networking-centos/0f180c0 : SUCCESS in 1h 19m 03s (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://intel-openstack-ci-logs.ovh/2017-01-16/420906/1/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/5fc1b8c : SUCCESS in 1h 43m 26s","accounts_in_message":[],"_revision_number":1},{"id":"b1e835123e085c2f1d93ac90b012dbf3f6bd6577","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2017-01-17 05:23:17.000000000","message":"Patch Set 1:\n\n@Apoorva - flag you need to set false is TEMPEST_VOLUME_MANAGE_SNAPSHOT sme way like done in https://review.openstack.org/#/c/421073/\n\n@Sean, Patrick - I agree that we can improve the tests and currently it is too specific to lvm or any other cases. \nIf CI can just set tests flag to False, then it will work and leave tests running for LVM at least along with improvement in tests.\n\nCinder team help to improve that tests is very much appreciated. \n\nI am not blocking this revert but i agree with Jordan here. I\u0027d like CI or anywhere manage snapshot is not available, can make this test skip.","accounts_in_message":[],"_revision_number":1},{"id":"9cc3257ccb9f3999f6a2fa44c904f2a8a0cabdb9","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-01-17 13:23:08.000000000","message":"Patch Set 1:\n\n\"anywhere manage snapshot is not available\"\n\nThe point seems to keep being missed here. This test is only correct for the LVM backend. This feature is supported by other drivers, but by the nature of the operation, it is different for each backend.","accounts_in_message":[],"_revision_number":1},{"id":"2fa16b110e4af6e48ae81d1809c89f276daacb57","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-01-17 17:41:22.000000000","message":"Patch Set 1:\n\nok so... if folks dont want to revert it, lets just only turn it on for LVM https://review.openstack.org/#/c/420169/ ??","accounts_in_message":[],"_revision_number":1},{"id":"1cbf13c70fe21fa9c4104af3f698da8c4d165928","author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"date":"2017-01-17 18:05:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0d4e8c1db042b1fb62b0f4b217bb3d7d2f6211b1","author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"date":"2017-01-18 06:04:12.000000000","message":"Patch Set 1:\n\nI changed CI job like this and now tests are passing\n\n          [[post-extra|\\$TEMPEST_CONFIG]]\n          [volume-feature-enabled]\n          manage_snapshot\u003dFalse\n\n    cat \u003c\u003cEOF \u003e\u003e$BASE/new/devstack/localrc\nTEMPEST_VOLUME_MANAGE_SNAPSHOT\u003dFalse\nEOF","accounts_in_message":[],"_revision_number":1},{"id":"23f529ea5a71bd990c5af966dd73b63d870f8033","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-01-18 19:31:43.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a6c731e67d107d974ce5bb118666cf2ca48602d8","revisions":{"a6c731e67d107d974ce5bb118666cf2ca48602d8":{"kind":"REWORK","_number":1,"created":"2017-01-16 18:42:51.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/06/420906/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/06/420906/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/420906/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/420906/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/06/420906/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/06/420906/1"}}},"commit":{"parents":[{"commit":"afac732d5d9b03da7abbd61f814c2f0d1a9039da","subject":"lib/tempest: allow tweaking volume-feature-enabled/manage_snapshot","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/afac732d5d9b03da7abbd61f814c2f0d1a9039da"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2017-01-16 18:42:51.000000000","tz":0},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2017-01-16 18:42:51.000000000","tz":0},"subject":"Revert \"lib/tempest: allow tweaking volume-feature-enabled/manage_snapshot\"","message":"Revert \"lib/tempest: allow tweaking volume-feature-enabled/manage_snapshot\"\n\nAs mentioned several other places, this is not something\nthat should be enabled by default. The input to this\nfunctionality is backend specific. The issue is not that\n\"only a few Cinder backends support\" it, but that the test\nis flawed in assuming everything doing manage/unmanage\nwill take the same values to identify the volume or\nsnapshot to be managed.\n\nThis is causing many third party CI failures and should\nbe reverted back to defaulting to false.\n\nThis reverts commit afac732d5d9b03da7abbd61f814c2f0d1a9039da.\n\nChange-Id: Id0fb170294d127f923b4bde487eed0e0755a0f71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a6c731e67d107d974ce5bb118666cf2ca48602d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a6c731e67d107d974ce5bb118666cf2ca48602d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}