)]}'
{"functions":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9ae4ad9a25ab35102329da0e5015cb30e781f939","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    # XenServer-raw-ovf-format images are provided as .raw.tgz"},{"line_number":1253,"context_line":"    # and should not be decompressed prior to loading"},{"line_number":1254,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.raw.tgz\u0027 ]]; then"},{"line_number":1255,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1256,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.raw.tgz}\""},{"line_number":1257,"context_line":"        glance \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARn%2F%2F9e0%3D","line":1254,"updated":"2013-08-19 17:15:08.000000000","message":"I have a concern here that this may have false positive matches.  .raw.tgz is a pretty generic suffix and had a prior handler below.  Is there anything else to verify we\u0027re dealing with an ovf file?  I\u0027d think there is something as you are trying to handle a very specific file type.","commit_id":"03684ea9de5581efb85eae52027966d8959e8aba"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c189b15d0e9e3e59e86f0a720e6b4144263a25d4","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    # XenServer-raw-ovf-format images are provided as .raw.tgz"},{"line_number":1253,"context_line":"    # and should not be decompressed prior to loading"},{"line_number":1254,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.raw.tgz\u0027 ]]; then"},{"line_number":1255,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1256,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.raw.tgz}\""},{"line_number":1257,"context_line":"        glance \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARn%2F%2FzSc%3D","line":1254,"in_reply_to":"AAAARn%2F%2F638%3D","updated":"2013-08-21 19:42:48.000000000","message":"I know the combinations of container-format and real-world use is not well documented, my real issue was just that we already had a handler for *.tgz and *.raw.tgz seems really generic and obvious that it is a raw image inside a gzipped tar file.  Or that\u0027s how I would read it.\n\nThat said, the existing handler does assume *.tgz has image, kernel and ramdisk files in it so this may not be a bad move.  That only leaves the ovf container-format and the vm_mode property setting to resolve, i.e. I don\u0027t think generic *.raw.tgz files should have those.  Is there some way you might pick that up, like out of the filename?","commit_id":"03684ea9de5581efb85eae52027966d8959e8aba"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"1f3bfe30c90eefb13876249dd7171a0413bbaa5b","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    # XenServer-raw-ovf-format images are provided as .raw.tgz"},{"line_number":1253,"context_line":"    # and should not be decompressed prior to loading"},{"line_number":1254,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.raw.tgz\u0027 ]]; then"},{"line_number":1255,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1256,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.raw.tgz}\""},{"line_number":1257,"context_line":"        glance \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARn%2F%2F638%3D","line":1254,"in_reply_to":"AAAARn%2F%2F9e0%3D","updated":"2013-08-20 08:24:55.000000000","message":"To be honest, this is not strictly an ovf. I used ovf, because the XenServer images are using ovf as a container format in glance to refer to the same structure (vhd chain inside a tar.gz) (to be honest, this new thing is just a tar.gz with one file in it, so we would better say, that the container format is .tgz).\n\nLet me look at glance, and see, if any other container format could be used. If that\u0027s the case, we might want to use --disk-format\u003draw --container-format\u003dtgz.\n\nRegarding to the image extension, I think we could pick anything. What about:\n\n  .rawdisk.tgz","commit_id":"03684ea9de5581efb85eae52027966d8959e8aba"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"47f293352f4502afed6175013dc3f15290910e25","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    # XenServer-raw-ovf-format images are provided as .raw.tgz"},{"line_number":1253,"context_line":"    # and should not be decompressed prior to loading"},{"line_number":1254,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.raw.tgz\u0027 ]]; then"},{"line_number":1255,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1256,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.raw.tgz}\""},{"line_number":1257,"context_line":"        glance \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASX%2F%2F7j4%3D","line":1254,"in_reply_to":"AAAARn%2F%2Fv0I%3D","updated":"2013-08-23 15:36:39.000000000","message":"That\u0027s nice and specific! ;)\n\nEven just *.xen-ovf.tgz would be good enough for setting the properties.  I think raw is a safe default, which is why raw by itself shouldn\u0027t assume anything else.","commit_id":"03684ea9de5581efb85eae52027966d8959e8aba"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"eb7506c1d88fbee99442d83d4ba0ba54a41f86f8","unresolved":false,"context_lines":[{"line_number":1251,"context_line":""},{"line_number":1252,"context_line":"    # XenServer-raw-ovf-format images are provided as .raw.tgz"},{"line_number":1253,"context_line":"    # and should not be decompressed prior to loading"},{"line_number":1254,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.raw.tgz\u0027 ]]; then"},{"line_number":1255,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1256,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.raw.tgz}\""},{"line_number":1257,"context_line":"        glance \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAARn%2F%2Fv0I%3D","line":1254,"in_reply_to":"AAAARn%2F%2FzSc%3D","updated":"2013-08-22 11:24:03.000000000","message":"What do you think about:\n\n if [[ \"$image_url\" \u003d~ \u0027.xen-raw-ovf.tgz\u0027 ]];","commit_id":"03684ea9de5581efb85eae52027966d8959e8aba"}]}
