)]}'
{"id":"openstack%2Fdevstack~42402","triplet_id":"openstack%2Fdevstack~master~I441209167e86ceb179e4bc9d1528285b8560ff5b","project":"openstack/devstack","branch":"master","topic":"complete","hashtags":[],"change_id":"I441209167e86ceb179e4bc9d1528285b8560ff5b","subject":"Defining a bash completion function","status":"ABANDONED","created":"2013-08-16 19:27:19.000000000","updated":"2013-08-22 02:46:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f90f8aa445e653c9867c81788c57f5f698d7f071","_number":42402,"virtual_id_number":42402,"owner":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2013-08-20 07:47:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2013-08-21 17:54:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-08-20 19:06:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":1,"date":"2013-08-20 14:39:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"value":1,"date":"2013-08-20 13:10:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2013-08-21 17:54:58.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-08-20 06:27:37.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-20 07:47:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-08-20 13:10:59.000000000","updated_by":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"reviewer":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"state":"REVIEWER"},{"updated":"2013-08-20 14:39:42.000000000","updated_by":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"reviewer":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"state":"REVIEWER"},{"updated":"2013-08-21 17:54:58.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"d16541866aaff6c10006427b091a51e6322da29d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-16 20:14:56.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/02/42402/1/check/gate-tempest-devstack-vm-full/7f58f42 : SUCCESS in 47m 24s\n- http://logs.openstack.org/02/42402/1/check/gate-tempest-devstack-vm-cells-full/9596c15 : FAILURE in 13m 45s (non-voting)\n- http://logs.openstack.org/02/42402/1/check/gate-tempest-devstack-vm-testr-full/21b0ce0 : FAILURE in 25m 44s (non-voting)\n- http://logs.openstack.org/02/42402/1/check/gate-tempest-devstack-vm-postgres-full/25f674d : SUCCESS in 47m 31s\n- http://logs.openstack.org/02/42402/1/check/gate-tempest-devstack-vm-neutron/df172de : SUCCESS in 18m 24s\n- http://logs.openstack.org/02/42402/1/check/gate-grenade-devstack-vm/8f323f6 : SUCCESS in 22m 22s\n","accounts_in_message":[],"_revision_number":1},{"id":"520ae60f56e777e94ba20f8468b41b1737e75ceb","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2013-08-16 22:17:13.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ce9840fc38508c5a67fa39be70022439544df45f","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-08-20 06:27:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"40bc7b174f3a2d1ab4af69fbde0e6f1a539977f5","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-08-20 06:27:50.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"17b06fa6a769902dd118a77c4aeea9ed9ab9e455","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-20 07:47:40.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/02/42402/2/check/gate-tempest-devstack-vm-full/7515d15 : SUCCESS in 1h 04m 47s\n- gate-tempest-devstack-vm-cells-full http://logs.openstack.org/02/42402/2/check/gate-tempest-devstack-vm-cells-full/52aa6a9 : FAILURE in 33m 49s (non-voting)\n- gate-tempest-devstack-vm-testr-full http://logs.openstack.org/02/42402/2/check/gate-tempest-devstack-vm-testr-full/28b4fd2 : SUCCESS in 45m 12s (non-voting)\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/02/42402/2/check/gate-tempest-devstack-vm-postgres-full/bce906f : SUCCESS in 1h 04m 05s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/02/42402/2/check/gate-tempest-devstack-vm-neutron/b48f0fc : SUCCESS in 38m 15s\n- gate-grenade-devstack-vm http://logs.openstack.org/02/42402/2/check/gate-grenade-devstack-vm/fb0c77c : SUCCESS in 1h 19m 45s\n","accounts_in_message":[],"_revision_number":2},{"id":"facb0bbbbf79d54f53d6fad1cd2f94ea53cb6b79","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2013-08-20 13:10:59.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"936b561417fb0b6aecc4c315e69dc6029885609f","author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"date":"2013-08-20 14:39:42.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nmaybe the following:\n\n sudo mkdir -p /etc/bash_completion.d\n\ncould be wrapped in some \u0027if\u0027 statement to make it look more elegant but it won\u0027t add any benefit so I\u0027m leaving the comment here for others to decide but +1 the change","accounts_in_message":[],"_revision_number":2},{"id":"26749d2555ae5c8b360308f6d93b4ee541451cda","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-08-20 19:06:17.000000000","message":"Patch Set 2:\n\nguilio: I think it similar to the apologize vs. asking permission issue/question.\nThe \u0027mkdir -p\u0027 handles this question inside, without an outside helper.","accounts_in_message":[],"_revision_number":2},{"id":"7606bb5009812b5bef16c75509dabfdfef99671a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-21 17:54:58.000000000","message":"Patch Set 2: Do not merge\n\nHow about we just use install(1) for this?\n\n install -d -m 0755 -o $STACK_USER source_file ... target_dir","accounts_in_message":[],"_revision_number":2},{"id":"f0695f1aebde476c824d65cfaae7f750e3cc672a","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-08-21 17:56:24.000000000","message":"Patch Set 2:\n\nok","accounts_in_message":[],"_revision_number":2},{"id":"1b9bec6e39ccc77db3383b13d77f1fc6e2f1d72c","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-08-21 17:57:18.000000000","message":"Patch Set 2: Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"46bd7045d61fe959743512c4540acc01693d1f74","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-08-21 22:30:42.000000000","message":"Patch Set 2:\n\n@Attila I don\u0027t think you need to abandon this, Dean was making a suggestion for the implementation. I believe this could be a useful feature to have.","accounts_in_message":[],"_revision_number":2},{"id":"e400fdd9e1db6e25aba637594dac432d5158823a","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-08-22 02:46:52.000000000","message":"Patch Set 2:\n\nI have two change set, I will update it in the 2th patchset.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"581a8308d92d94fb7f104122d91c78aa2e384234","revisions":{"3b26c7204d812f9602f5f8598635fa6889b5f2d8":{"kind":"REWORK","_number":1,"created":"2013-08-16 19:27:19.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/02/42402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/02/42402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/02/42402/1"}}},"commit":{"parents":[{"commit":"415360b23157caac28899fe0e02f47f0e4532ca2","subject":"Merge \"Colorize heat engine log\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/415360b23157caac28899fe0e02f47f0e4532ca2"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-08-16 19:25:11.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-08-16 19:25:11.000000000","tz":120},"subject":"Defining a bash completion function","message":"Defining a bash completion function\n\nThe https://review.openstack.org/#/c/41928/4 change requires a new function,\nmerged first in order to pass on the grenade job.\n\nChange-Id: I441209167e86ceb179e4bc9d1528285b8560ff5b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3b26c7204d812f9602f5f8598635fa6889b5f2d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3b26c7204d812f9602f5f8598635fa6889b5f2d8"}]},"branch":"refs/heads/master"},"581a8308d92d94fb7f104122d91c78aa2e384234":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2013-08-20 06:27:37.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/02/42402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/02/42402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/02/42402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/02/42402/2"}}},"commit":{"parents":[{"commit":"68044c0245e0d39cecbc8602a8059bd7c33b7693","subject":"Merge \"Redirect dpkg -l stderr to /dev/null\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/68044c0245e0d39cecbc8602a8059bd7c33b7693"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-08-16 19:25:11.000000000","tz":120},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-08-20 06:24:56.000000000","tz":120},"subject":"Defining a bash completion function","message":"Defining a bash completion function\n\nThe https://review.openstack.org/#/c/41928 change requires a new function,\nmerged first in order to pass on the grenade job.\n\nChange-Id: I441209167e86ceb179e4bc9d1528285b8560ff5b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/581a8308d92d94fb7f104122d91c78aa2e384234"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/581a8308d92d94fb7f104122d91c78aa2e384234"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}