)]}'
{"lib/neutron_plugins/services/l3":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d4070adece18dfb9d73ab950865b0de8bb8b237b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -z $SUBNETPOOL_V4_ID ]; then"},{"line_number":188,"context_line":"                fixed_range_v4\u003d$FIXED_RANGE"},{"line_number":189,"context_line":"            fi"},{"line_number":190,"context_line":"            SUBNET_ID\u003d$(openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" subnet create \\"},{"line_number":191,"context_line":"                        --project $project_id --ip-version 4 \\"},{"line_number":192,"context_line":"                        ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} \\"},{"line_number":193,"context_line":"                        $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf8cb3f7_2eba97dd","line":190,"range":{"start_line":190,"start_character":87,"end_line":190,"end_character":101},"updated":"2017-12-28 12:00:53.000000000","message":"I think it is better to wrap lines before \u0027subnet create\u0027","commit_id":"e44ebaaf00f3b7c7f1cc46181bdc79d3ceeed37e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d4070adece18dfb9d73ab950865b0de8bb8b237b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                        --project $project_id --ip-version 4 \\"},{"line_number":192,"context_line":"                        ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} \\"},{"line_number":193,"context_line":"                        $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY \\"},{"line_number":194,"context_line":"                        ${SUBNETPOOL_V4_ID:+--subnet-pool $SUBNETPOOL_V4_ID} --network $NET_ID \\"},{"line_number":195,"context_line":"                        ${fixed_range_v4:+--subnet-range $fixed_range_v4} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":196,"context_line":"            die_if_not_set $LINENO SUBNET_ID \"Failure creating SUBNET_ID for $PROVIDER_SUBNET_NAME $project_id\""},{"line_number":197,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f91af0f_34dc8645","line":194,"range":{"start_line":194,"start_character":77,"end_line":194,"end_character":94},"updated":"2017-12-28 12:00:53.000000000","message":"I don\u0027t think it is a good idea to mix optional arguments and required arguments. How about moving --network $NET_ID just after --ip-version 4 ?","commit_id":"e44ebaaf00f3b7c7f1cc46181bdc79d3ceeed37e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d4070adece18dfb9d73ab950865b0de8bb8b237b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} \\"},{"line_number":193,"context_line":"                        $PROVIDER_SUBNET_NAME --gateway $NETWORK_GATEWAY \\"},{"line_number":194,"context_line":"                        ${SUBNETPOOL_V4_ID:+--subnet-pool $SUBNETPOOL_V4_ID} --network $NET_ID \\"},{"line_number":195,"context_line":"                        ${fixed_range_v4:+--subnet-range $fixed_range_v4} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":196,"context_line":"            die_if_not_set $LINENO SUBNET_ID \"Failure creating SUBNET_ID for $PROVIDER_SUBNET_NAME $project_id\""},{"line_number":197,"context_line":"        fi"},{"line_number":198,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f91af0f_542caa46","line":195,"range":{"start_line":195,"start_character":74,"end_line":195,"end_character":101},"updated":"2017-12-28 12:00:53.000000000","message":"openstack command supports several output format.\n\n openstack subnet create ..... --format value -c id\n\ndisplay the ID of the newly created subnet, so \"| grep \u0027 id \u0027 | get_field 2\" will be unnecessary.","commit_id":"e44ebaaf00f3b7c7f1cc46181bdc79d3ceeed37e"}]}