)]}'
{"lib/tempest":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"ee12161870bb45b66c1a47ab58c8291addcf730e","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled shelve False"},{"line_number":521,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled snapshot False"},{"line_number":522,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":523,"context_line":"        elif [ ! is_service_enabled n-cell -a \\"},{"line_number":524,"context_line":"                \"$CINDER_ENABLED_BACKENDS\" !\u003d *\"ceph\"* ]; then"},{"line_number":525,"context_line":"            # cells v1 and the ceph cinder volume backend do not support "},{"line_number":526,"context_line":"            # swapping volumes, only enable if both are disabled."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a430d35_79680088","line":523,"updated":"2017-02-07 15:37:13.000000000","message":"Could you please use the double [ form and/or \u0026\u0026 or || ? What does \"-a\" mean ? Most of us know \u0026\u0026.","commit_id":"3e21e904106472e99d4e89be12ec8a250156dba4"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9fe362b8219ad51b94da8ed18cb01026ba3f7d8b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled shelve False"},{"line_number":521,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled snapshot False"},{"line_number":522,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":523,"context_line":"        elif [ ! is_service_enabled n-cell -a \\"},{"line_number":524,"context_line":"                \"$CINDER_ENABLED_BACKENDS\" !\u003d *\"ceph\"* ]; then"},{"line_number":525,"context_line":"            # cells v1 and the ceph cinder volume backend do not support "},{"line_number":526,"context_line":"            # swapping volumes, only enable if both are disabled."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a430d35_4580b78b","line":523,"in_reply_to":"1a430d35_2caf18e3","updated":"2017-02-07 16:48:56.000000000","message":"Maybe it\u0027s a matter of coding style but I found this more readable:\n\nelif ! is_service_enabled n-cell \\\n  \u0026\u0026 [[ \"$CINDER_ENABLED_BACKENDS\" !\u003d *\"ceph\"* ]; then\n\nAlso, imo we prefer (based on usage count) [[ to [ in DevStack and [[ is less error prone.\n\nAny, let\u0027s see what other think.","commit_id":"3e21e904106472e99d4e89be12ec8a250156dba4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"643edd79b1d73d76d033acaf6b3091a206948c60","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled shelve False"},{"line_number":521,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled snapshot False"},{"line_number":522,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":523,"context_line":"        elif [ ! is_service_enabled n-cell -a \\"},{"line_number":524,"context_line":"                \"$CINDER_ENABLED_BACKENDS\" !\u003d *\"ceph\"* ]; then"},{"line_number":525,"context_line":"            # cells v1 and the ceph cinder volume backend do not support "},{"line_number":526,"context_line":"            # swapping volumes, only enable if both are disabled."}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a430d35_2caf18e3","line":523,"in_reply_to":"1a430d35_79680088","updated":"2017-02-07 15:47:20.000000000","message":"Sure, AFAIK [ EXPR1 -a EXPR2 ] is the same as [ EXPR1 ] \u0026\u0026 [ EXPR2 ] [1]. -o is also being used above on L491 and L495 instead of ||. Happy to remove if you still think this is confusing.\n\n[1] http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_07_01.html - Table 7-2. Combining expressions","commit_id":"3e21e904106472e99d4e89be12ec8a250156dba4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"479fcec02aefa1acdfdd0ee82dc207eb24021843","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled snapshot False"},{"line_number":518,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled suspend False"},{"line_number":519,"context_line":"        elif ! is_service_enabled n-cell \u0026\u0026 \\"},{"line_number":520,"context_line":"                [[ \"$CINDER_ENABLED_BACKENDS\" !\u003d *\"ceph\"* ]]; then"},{"line_number":521,"context_line":"            # cells v1 and the ceph cinder volume backend do not support "},{"line_number":522,"context_line":"            # swapping volumes, only enable if both are disabled."},{"line_number":523,"context_line":"            iniset $TEMPEST_CONFIG compute-feature-enabled swap_volume True"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa31d9ce_db515364","line":520,"updated":"2017-02-10 14:58:34.000000000","message":"Kind of a shame we have to check this in here. I was thinking we could handle this in the devstack-plugin-ceph repo, but I\u0027m not sure how to do that since we don\u0027t have a variable for setting the tempest.conf variable below. If we did, we could have controlled that from the ceph plugin repo.","commit_id":"690f341571b71efedc1329c4dceb8373d6a023b6"}]}