)]}'
{"functions":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"edd2cc2e084406052d51177cc6c728f79f986a8f","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    # Return early while being inside a container"},{"line_number":673,"context_line":"    if grep -q lxc /proc/1/cgroup; then"},{"line_number":674,"context_line":"        return"},{"line_number":675,"context_line":"    fi"},{"line_number":676,"context_line":"    sudo modprobe bridge"},{"line_number":677,"context_line":"    # For newer kernels (3.18+), those sysctl settings are split into a separate"},{"line_number":678,"context_line":"    # kernel module (br_netfilter). Load it too, if present."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da36d5c6_51258859","line":675,"updated":"2017-02-25 14:42:49.000000000","message":"instead of one offing this here, it feels like if we are going to do this we need to be setting a more general running_in_container function and put the logic higher up about never running this.","commit_id":"4ef41277c6783c5a62320c6104381e2d6815b3f5"},{"author":{"_account_id":17599,"name":"Denis Buliga","email":"dbuliga@cloudbasesolutions.com","username":"dbuliga"},"change_message_id":"bc7f5238fca7a0048520fd004339fc4acf27d7af","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    # Return early while being inside a container"},{"line_number":673,"context_line":"    if grep -q lxc /proc/1/cgroup; then"},{"line_number":674,"context_line":"        return"},{"line_number":675,"context_line":"    fi"},{"line_number":676,"context_line":"    sudo modprobe bridge"},{"line_number":677,"context_line":"    # For newer kernels (3.18+), those sysctl settings are split into a separate"},{"line_number":678,"context_line":"    # kernel module (br_netfilter). Load it too, if present."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da36d5c6_6070e272","line":675,"in_reply_to":"da36d5c6_51258859","updated":"2017-02-27 08:33:21.000000000","message":"Done","commit_id":"4ef41277c6783c5a62320c6104381e2d6815b3f5"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"85742af0a7a2ccbb00748d48ed624154d2e63b4f","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    fi"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    return 1"},{"line_number":674,"context_line":"}"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"# enable_kernel_bridge_firewall - Enable kernel support for bridge firewalling"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba2be162_ad1ebb5c","line":674,"updated":"2017-03-02 22:29:57.000000000","message":"i think this can be simplified to just\n\n function running_in_container {\n    grep -q lxc /proc/1/cgroup;\n }\n\nalthough, i\u0027m just going by stackoverflow here ... maybe checking for \"container\" env var is more reliable and works more consistently?  (apparently docker now uses \"docker\" in there?)\n\nI don\u0027t think i\u0027d mind if this was just \"in_container\" to save a bit of line length","commit_id":"0bf75a471ecce8c05718644e7e070b4d5a8657d6"}],"lib/neutron_plugins/ovs_base":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a4ec5cb984ca13fc83832c8e550b2c390f63355","unresolved":false,"context_lines":[{"line_number":88,"context_line":"function _neutron_ovs_base_configure_firewall_driver {"},{"line_number":89,"context_line":"    if [[ \"$Q_USE_SECGROUP\" \u003d\u003d \"True\" ]]; then"},{"line_number":90,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver iptables_hybrid"},{"line_number":91,"context_line":"        if ! grep -q lxc /proc/1/cgroup; then"},{"line_number":92,"context_line":"            enable_kernel_bridge_firewall"},{"line_number":93,"context_line":"        fi"},{"line_number":94,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a430d35_fb425b3d","line":91,"updated":"2017-02-06 15:14:07.000000000","message":"instead of doing it in every place the function is used, can we move it into the function itself?","commit_id":"8985ca311627f0888b6302ef27aefa180b282183"},{"author":{"_account_id":17599,"name":"Denis Buliga","email":"dbuliga@cloudbasesolutions.com","username":"dbuliga"},"change_message_id":"803b0fbd8abcd547d0da6f69d37eceb9b85de928","unresolved":false,"context_lines":[{"line_number":88,"context_line":"function _neutron_ovs_base_configure_firewall_driver {"},{"line_number":89,"context_line":"    if [[ \"$Q_USE_SECGROUP\" \u003d\u003d \"True\" ]]; then"},{"line_number":90,"context_line":"        iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver iptables_hybrid"},{"line_number":91,"context_line":"        if ! grep -q lxc /proc/1/cgroup; then"},{"line_number":92,"context_line":"            enable_kernel_bridge_firewall"},{"line_number":93,"context_line":"        fi"},{"line_number":94,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a430d35_361f9a60","line":91,"in_reply_to":"1a430d35_fb425b3d","updated":"2017-02-06 15:30:55.000000000","message":"Done","commit_id":"8985ca311627f0888b6302ef27aefa180b282183"}]}