)]}'
{"id":"openstack%2Fdevstack~43212","triplet_id":"openstack%2Fdevstack~master~I56d267eafa06c52c3867e3396483f5fde3ee5570","project":"openstack/devstack","branch":"master","topic":"bp/dhcp-multi-node","hashtags":[],"change_id":"I56d267eafa06c52c3867e3396483f5fde3ee5570","subject":"Add support for setting Neutron DHCP agent options.","status":"MERGED","created":"2013-08-22 00:03:58.000000000","updated":"2013-08-27 16:07:52.000000000","submitted":"2013-08-27 16:07:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"012f33b97f7c9936ccc3e15dba35fdcbafb7edf8","_number":43212,"virtual_id_number":43212,"owner":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-08-27 16:07:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":1,"date":"2013-08-23 09:07:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":2,"date":"2013-08-26 20:43:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":1,"date":"2013-08-27 15:19:32.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-22 03:34:14.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2013-08-23 09:07:02.000000000","updated_by":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"reviewer":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"state":"REVIEWER"},{"updated":"2013-08-27 15:19:32.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-08-27 16:07:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"61cf31d84bef89fcde419416a91bc6c23534bfd5","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-08-22 03:38:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nRather than continuing to add individual config parameters into devstack for Neutron, I\u0027d prefer we do what we did for the Neutron server and agents by adding something like this in the DHCP config file setup function here:\n\n# Define extra \"DEFAULT\" configuration options when q-dhcp is configured by\n# defining the array ``Q_DHCP_EXTRA_DEFAULT_OPTS``.\n# For Example: ``Q_DHCP_EXTRA_DEFAULT_OPTS\u003d(foo\u003dtrue bar\u003d2)``\nfor I in \"${Q_DHCP_EXTRA_DEFAULT_OPTS[@]}\"; do\n    # Replace the first \u0027\u003d\u0027 with \u0027 \u0027 for iniset syntax\n    iniset $Q_DHCP_CONF_FILE DEFAULT ${I/\u003d/ }\ndone\n\nAnd then in your localrc you would set this up as:\n\nQ_DHCP_EXTRA_DEFAULT_OPTS\u003d(enable_multihost\u003dTrue)\n\nIn this way, when the next DHCP option is needed, we no longer need a devstack patch.","accounts_in_message":[],"_revision_number":1},{"id":"dd126dfe43c6b869f2ca7c26873914d4ce05f8e6","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-08-22 15:36:50.000000000","message":"Patch Set 1:\n\nNachi, I should note that I gave the review based on advice I received from sdague on a review where I was trying to expose VXLAN vs. GRE configuration into devstack [1]. He was pretty clear he wanted new devstack patches to expose the ability to configure options set in localrc rather than expose each individual option in devstack itself. Just wanted to clarify here.\n\n[1] https://review.openstack.org/#/c/30315/","accounts_in_message":[],"_revision_number":1},{"id":"4281cb6519397958b019961022a332740adf698d","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-08-22 17:05:39.000000000","message":"Patch Set 1:\n\nIndeed, It\u0027s very nice suggestion!\n\nI\u0027ll use your script","accounts_in_message":[],"_revision_number":1},{"id":"5cff04c78a019fc433d92be33433c124491ab23b","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-08-22 17:16:50.000000000","message":"Patch Set 1:\n\nJust FYI, I tested devstack with the change I suggested here with Yong\u0027s patch, and it works great!","accounts_in_message":[],"_revision_number":1},{"id":"046b0ebe2fb74aa1bd61222f21e61aa3379a1519","author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"date":"2013-08-22 17:20:31.000000000","message":"Patch Set 1:\n\nHi Kyle\n\nif you have already fix, could you send it here?\nIf you use same change-id, your new patch will overwrite this","accounts_in_message":[],"_revision_number":1},{"id":"3e4a2139b373287515ab5fdb1677f5c000d8c219","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-08-22 17:23:07.000000000","message":"Patch Set 1:\n\nYes, will do that now.","accounts_in_message":[],"_revision_number":1},{"id":"329db4568b71cb8aeb0f6744ee05a0f93166e28b","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2013-08-22 17:26:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6b372c15d7eceff5fe6322e17a195cad92b619fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-22 18:53:42.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/12/43212/2/check/gate-tempest-devstack-vm-full/ebb79aa : SUCCESS in 59m 20s\n- gate-tempest-devstack-vm-cells-full http://logs.openstack.org/12/43212/2/check/gate-tempest-devstack-vm-cells-full/e18f30a : FAILURE in 30m 36s (non-voting)\n- gate-tempest-devstack-vm-testr-full http://logs.openstack.org/12/43212/2/check/gate-tempest-devstack-vm-testr-full/8ab6821 : SUCCESS in 48m 11s (non-voting)\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/12/43212/2/check/gate-tempest-devstack-vm-postgres-full/f82ca44 : SUCCESS in 1h 05m 20s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/12/43212/2/check/gate-tempest-devstack-vm-neutron/4cc94c9 : SUCCESS in 36m 59s\n- gate-grenade-devstack-vm http://logs.openstack.org/12/43212/2/check/gate-grenade-devstack-vm/8d6d26f : SUCCESS in 1h 06m 34s\n","accounts_in_message":[],"_revision_number":2},{"id":"fb58d494e387dada2b192a471e050f67f1c6e83a","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-08-23 09:07:02.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nI have tested it, it works","accounts_in_message":[],"_revision_number":2},{"id":"aee952ce102ec0e2fd722253be8f2759d39eefeb","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-26 20:43:20.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6ef67d9198cb36d6f677f5d2fbc9674b93d11054","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-08-27 15:19:32.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"e368ebda39db2565279fe0afbfa9575ff49ec815","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 15:19:34.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c5d793eb061e4ba5f2882eabe0b56bd161e32f71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 16:07:52.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"bbf1ff66c4532b9a2e3a300170ac691fffb888b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 16:07:52.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-tempest-devstack-vm-full http://logs.openstack.org/12/43212/2/gate/gate-tempest-devstack-vm-full/5ad4660 : SUCCESS in 23m 43s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/12/43212/2/gate/gate-tempest-devstack-vm-postgres-full/90da7bc : SUCCESS in 24m 11s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/12/43212/2/gate/gate-tempest-devstack-vm-neutron/66c646d : SUCCESS in 17m 05s\n- gate-grenade-devstack-vm http://logs.openstack.org/12/43212/2/gate/gate-grenade-devstack-vm/baf4407 : SUCCESS in 22m 36s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"73b21910123704ac64ca3d2ba7f50e90e248d7ea","revisions":{"53643e68b8b3e7c82921bc3b4b34930a8231c0ee":{"kind":"REWORK","_number":1,"created":"2013-08-22 00:03:58.000000000","uploader":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"ref":"refs/changes/12/43212/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/43212/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/43212/1"}}},"commit":{"parents":[{"commit":"68044c0245e0d39cecbc8602a8059bd7c33b7693","subject":"Merge \"Redirect dpkg -l stderr to /dev/null\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/68044c0245e0d39cecbc8602a8059bd7c33b7693"}]}],"author":{"name":"Nachi Ueno","email":"nachi@ntti3.com","date":"2013-08-21 23:45:35.000000000","tz":-420},"committer":{"name":"Nachi Ueno","email":"nachi@ntti3.com","date":"2013-08-21 23:45:35.000000000","tz":-420},"subject":"Support neturon multi-host","message":"Support neturon multi-host\n\nThis is WIP code beucase\nmulti-host support is under review in the neutron\n\nChange-Id: I56d267eafa06c52c3867e3396483f5fde3ee5570\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/53643e68b8b3e7c82921bc3b4b34930a8231c0ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/53643e68b8b3e7c82921bc3b4b34930a8231c0ee"}]},"branch":"refs/heads/master"},"73b21910123704ac64ca3d2ba7f50e90e248d7ea":{"kind":"REWORK","_number":2,"created":"2013-08-22 17:26:55.000000000","uploader":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"ref":"refs/changes/12/43212/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/12/43212/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/12/43212/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/12/43212/2"}}},"commit":{"parents":[{"commit":"9ed021665415c4d58871278d1c89e6c16e008fb5","subject":"Merge \".conf suffix for the horizon config on Fedora\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9ed021665415c4d58871278d1c89e6c16e008fb5"}]}],"author":{"name":"Kyle Mestery","email":"kmestery@cisco.com","date":"2013-08-22 11:25:21.000000000","tz":0},"committer":{"name":"Kyle Mestery","email":"kmestery@cisco.com","date":"2013-08-22 11:26:30.000000000","tz":0},"subject":"Add support for setting Neutron DHCP agent options.","message":"Add support for setting Neutron DHCP agent options.\n\nThis patch adds support for setting arbitrary Neutron DHCP agent options.\nAn example of using it would be to add this to your localrc:\n\n    Q_DHCP_EXTRA_DEFAULT_OPTS\u003d(enable_multihost\u003dTrue)\n\nChange-Id: I56d267eafa06c52c3867e3396483f5fde3ee5570\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/73b21910123704ac64ca3d2ba7f50e90e248d7ea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/73b21910123704ac64ca3d2ba7f50e90e248d7ea"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}