)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67ebb55ac53f408a8c67e2d126effada9024813a","unresolved":false,"context_lines":[{"line_number":637,"context_line":"            conf\u003d$(cellsv2_conf $i)"},{"line_number":638,"context_line":"            vhost\u003d\"nova_cell${i}\""},{"line_number":639,"context_line":"            iniset $conf database connection `database_connection_url nova_cell${i}`"},{"line_number":640,"context_line":"            iniset $conf conductor workers \"$API_WORKERS\""},{"line_number":641,"context_line":"            iniset $conf DEFAULT debug \"$ENABLE_DEBUG_LOG_LEVEL\""},{"line_number":642,"context_line":"            rpc_backend_add_vhost $vhost"},{"line_number":643,"context_line":"            iniset_rpc_backend nova $conf DEFAULT $vhost"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_06d002c9","line":640,"range":{"start_line":640,"start_character":44,"end_line":640,"end_character":56},"updated":"2017-02-27 22:07:24.000000000","message":"Drop this to 1 if NOVA_NUM_CELLS is \u003e1?","commit_id":"3ada1225e34005640f27994736ca523da95d8b84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67ebb55ac53f408a8c67e2d126effada9024813a","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    iniset $NOVA_CONF service_user auth_strategy keystone"},{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_46011a39","line":660,"updated":"2017-02-27 22:07:24.000000000","message":"nit: Document the input parameter.","commit_id":"3ada1225e34005640f27994736ca523da95d8b84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67ebb55ac53f408a8c67e2d126effada9024813a","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    local confbase"},{"line_number":664,"context_line":"    cell\u003d\"$1\""},{"line_number":665,"context_line":"    confdir\u003d$(dirname $NOVA_CONF)"},{"line_number":666,"context_line":"    confbase\u003d$(basename $NOVA_CONF .conf)"},{"line_number":667,"context_line":"    echo \"${confdir}/${confbase}_cell${cell}.conf\""},{"line_number":668,"context_line":"}"},{"line_number":669,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_06e722ad","line":666,"range":{"start_line":666,"start_character":34,"end_line":666,"end_character":35},"updated":"2017-02-27 22:07:24.000000000","message":"Is this space supposed to be here?","commit_id":"3ada1225e34005640f27994736ca523da95d8b84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67ebb55ac53f408a8c67e2d126effada9024813a","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CELLS_CONF cell create --name\u003dregion --cell_type\u003dparent --username\u003d$RABBIT_USERID --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003d/ --woffset\u003d0 --wscale\u003d1"},{"line_number":693,"context_line":"        $NOVA_BIN_DIR/nova-manage cell create --name\u003dchild --cell_type\u003dchild --username\u003d$RABBIT_USERID --hostname\u003d$RABBIT_HOST --port\u003d5672 --password\u003d$RABBIT_PASSWORD --virtual_host\u003dchild_cell --woffset\u003d0 --wscale\u003d1"},{"line_number":694,"context_line":"    else"},{"line_number":695,"context_line":"\t# CellsV2"},{"line_number":696,"context_line":"        if is_service_enabled n-cpu; then"},{"line_number":697,"context_line":"            # FIXME: this should be only the things that we need for n-cpu"},{"line_number":698,"context_line":"            cp $NOVA_CONF $NOVA_CPU_CONF"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_66fe1e3a","line":695,"updated":"2017-02-27 22:07:24.000000000","message":"tab whitespace","commit_id":"3ada1225e34005640f27994736ca523da95d8b84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67ebb55ac53f408a8c67e2d126effada9024813a","unresolved":false,"context_lines":[{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"    if ! is_service_enabled n-cell; then"},{"line_number":1020,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":1021,"context_line":"            nova-manage --config-file $NOVA_CONF --config-file $(cellsv2_conf $i) cell_v2 map_cell_and_hosts"},{"line_number":1022,"context_line":"        done"},{"line_number":1023,"context_line":"    else"},{"line_number":1024,"context_line":"        nova-manage --config-file $NOVA_CELLS_CONF  --verbose cell_v2 map_cell_and_hosts \\"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da36d5c6_e6668e28","line":1021,"updated":"2017-02-27 22:07:24.000000000","message":"Is this going to get confused about which transport URL to use when we\u0027re passing in multiple config files?","commit_id":"3ada1225e34005640f27994736ca523da95d8b84"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"NOVA_CELLS_DB\u003d${NOVA_CELLS_DB:-nova_cell}"},{"line_number":59,"context_line":"NOVA_API_DB\u003d${NOVA_API_DB:-nova_api}"},{"line_number":60,"context_line":"NOVA_NUM_CELLS\u003d${NOVA_NUM_CELLS:-1}"},{"line_number":61,"context_line":"NOVA_CPU_CELL\u003d${NOVA_CPU_CELL:-1}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"NOVA_API_PASTE_INI\u003d${NOVA_API_PASTE_INI:-$NOVA_CONF_DIR/api-paste.ini}"},{"line_number":64,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_bd729810","line":61,"updated":"2017-04-05 16:35:21.000000000","message":"we should probably document these a bit more, just put a comment ahead of each one about what it will mean, and when you would expect people to change the default.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":485,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":486,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"},{"line_number":487,"context_line":"        iniset $NOVA_CONF database connection `database_connection_url nova_cell0`"},{"line_number":488,"context_line":"        iniset $NOVA_CONF api_database connection `database_connection_url nova_api`"},{"line_number":489,"context_line":"    fi"},{"line_number":490,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_9d9474ea","line":487,"updated":"2017-04-05 16:35:21.000000000","message":"so there is no longer a nova db? It\u0027s always called cell0 now? Is that going to be super weird for people in the wild when other tools have different naming then us?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":484,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":485,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":486,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"},{"line_number":487,"context_line":"        iniset $NOVA_CONF database connection `database_connection_url nova_cell0`"},{"line_number":488,"context_line":"        iniset $NOVA_CONF api_database connection `database_connection_url nova_api`"},{"line_number":489,"context_line":"    fi"},{"line_number":490,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_5b5b942d","line":487,"in_reply_to":"bff0334d_9d9474ea","updated":"2017-04-05 16:48:47.000000000","message":"Well, no, right now we have a nova_cell0 and a nova. The latter is our one and only cell database right now, and is what needs to be split into cell1 and cell2 if we have more than one real cell. We could leave one of them as just \"nova\" but it will only have half the data in it and be more confusing than not I think.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            rpc_backend_add_vhost $vhost"},{"line_number":643,"context_line":"            iniset_rpc_backend nova $conf DEFAULT $vhost"},{"line_number":644,"context_line":"        done"},{"line_number":645,"context_line":"    fi"},{"line_number":646,"context_line":"}"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"function init_nova_service_user_conf {"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_fd7260e3","line":645,"updated":"2017-04-05 16:35:21.000000000","message":"ack","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    iniset $NOVA_CONF service_user auth_strategy keystone"},{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_7d2c1099","line":660,"range":{"start_line":660,"start_character":9,"end_line":660,"end_character":21},"updated":"2017-04-05 16:35:21.000000000","message":"we should probably call this conductor_conf, given that it\u0027s really which config file a conductor will use.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    iniset $NOVA_CONF service_user auth_strategy keystone"},{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_bb75009b","line":660,"range":{"start_line":660,"start_character":9,"end_line":660,"end_character":21},"in_reply_to":"bff0334d_7d2c1099","updated":"2017-04-05 16:48:47.000000000","message":"Yeah, it didn\u0027t start out that way, but makes sense.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"},{"line_number":664,"context_line":"    cell\u003d\"$1\""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_3da9e8de","line":661,"updated":"2017-04-05 16:35:21.000000000","message":"Is there a reason this isn\u0027t just:\n\nlocal cell\u003d\"$1\"\necho \"$NOVA_CONF_DIR/nova_cell${cell}.conf\"\n\n?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e29c6f1cb0c27a0cbbeaf58645c29915085dbbbd","unresolved":false,"context_lines":[{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"},{"line_number":664,"context_line":"    cell\u003d\"$1\""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_0cf5d4cb","line":661,"in_reply_to":"bff0334d_3bdc5073","updated":"2017-04-05 18:00:51.000000000","message":"yeh, lets be simple.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":658,"context_line":"}"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"function cellsv2_conf {"},{"line_number":661,"context_line":"    local cell"},{"line_number":662,"context_line":"    local confdir"},{"line_number":663,"context_line":"    local confbase"},{"line_number":664,"context_line":"    cell\u003d\"$1\""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_3bdc5073","line":661,"in_reply_to":"bff0334d_3da9e8de","updated":"2017-04-05 16:48:47.000000000","message":"I was trying to cellify whatever you had NOVA_CONF set to. So if you set it to myfoobar.conf it would generate myfoobar_cell1.conf. But, if you\u0027re happy with the simpler option I\u0027m surely glad to do that :)","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":747,"context_line":"            recreate_database nova_cell${i}"},{"line_number":748,"context_line":"            $NOVA_BIN_DIR/nova-manage --config-file $(cellsv2_conf $i) db sync"},{"line_number":749,"context_line":"        done"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        if is_service_enabled n-cell; then"},{"line_number":752,"context_line":"            recreate_database $NOVA_CELLS_DB"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_dd7f9ca9","line":749,"updated":"2017-04-05 16:35:21.000000000","message":"ack","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        # create the cell1 cell for the main nova db where the hosts live"},{"line_number":760,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":761,"context_line":"            nova-manage --config-file $NOVA_CONF --config-file $(cellsv2_conf $i) cell_v2 create_cell --name \"cell$i\""},{"line_number":762,"context_line":"        done"},{"line_number":763,"context_line":"    fi"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    create_nova_cache_dir"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_1d5f4442","line":762,"updated":"2017-04-05 16:35:21.000000000","message":"ack","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# start_nova_compute() - Start the compute process"},{"line_number":872,"context_line":"function start_nova_compute {"},{"line_number":873,"context_line":"    local nomulticellflag\u003d\"$1\""},{"line_number":874,"context_line":"    # Hack to set the path for rootwrap"},{"line_number":875,"context_line":"    local old_path\u003d$PATH"},{"line_number":876,"context_line":"    export PATH\u003d$NOVA_BIN_DIR:$PATH"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_0038fbd0","line":873,"updated":"2017-04-05 16:35:21.000000000","message":"so, this ends up being sucky because we split the cpu config off?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"# start_nova_compute() - Start the compute process"},{"line_number":872,"context_line":"function start_nova_compute {"},{"line_number":873,"context_line":"    local nomulticellflag\u003d\"$1\""},{"line_number":874,"context_line":"    # Hack to set the path for rootwrap"},{"line_number":875,"context_line":"    local old_path\u003d$PATH"},{"line_number":876,"context_line":"    export PATH\u003d$NOVA_BIN_DIR:$PATH"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_7b0e58e6","line":873,"in_reply_to":"bff0334d_0038fbd0","updated":"2017-04-05 16:48:47.000000000","message":"Yeah, so this is so I can tell this function not to do this from the grenade side. As we discussed, I\u0027ve got grenade not changing the topology during the upgrade, so I just added this to signal that arrangement to this function.\n\nIs that cool? If so, I\u0027ll had a big comment above explaining it. If not, what to do?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        # FIXME(danms): Should this be configurable?"},{"line_number":893,"context_line":"        iniset $NOVA_CPU_CONF workarounds disable_group_policy_check_upcall True"},{"line_number":894,"context_line":"    fi"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_60dc6746","line":893,"updated":"2017-04-05 16:35:21.000000000","message":"ok, I think there is a sequence violation here, which maybe is part of why this gets gorpy.\n\nWe really shouldn\u0027t be manipulating config files in start_* functions. That should happen in configure_nova. Once the inisets get moved around to there, maybe this gets clearer?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        # FIXME(danms): Should this be configurable?"},{"line_number":893,"context_line":"        iniset $NOVA_CPU_CONF workarounds disable_group_policy_check_upcall True"},{"line_number":894,"context_line":"    fi"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_dbc5645d","line":893,"in_reply_to":"bff0334d_60dc6746","updated":"2017-04-05 16:48:47.000000000","message":"yeah, the reason I do this here is because of when the compute config gets created/copied. The problem comes in because we do things a little different in cellsv1 and the mainline. I can try to put this somewhere better without refactoring all of that.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e29c6f1cb0c27a0cbbeaf58645c29915085dbbbd","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        # FIXME(danms): Should this be configurable?"},{"line_number":893,"context_line":"        iniset $NOVA_CPU_CONF workarounds disable_group_policy_check_upcall True"},{"line_number":894,"context_line":"    fi"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_4c04fc7b","line":893,"in_reply_to":"bff0334d_dbc5645d","updated":"2017-04-05 18:00:51.000000000","message":"so, maybe we move it to init_nova? Or even init_nova_cells (and have basically a v1 / v2 block in there).\n\nI do see where it has to be later than configure_nova because other services might also need to add configuration to nova. But no one else should be changing things after the init phases start (if they do, their bad).","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"function start_nova_conductor {"},{"line_number":963,"context_line":"    if is_service_enabled n-cond; then"},{"line_number":964,"context_line":"        enable_service n-super-cond"},{"line_number":965,"context_line":"        run_process n-super-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $NOVA_CONF\""},{"line_number":966,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":967,"context_line":"            enable_service n-cond-cell${i}"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_a0894f27","line":964,"updated":"2017-04-05 16:35:21.000000000","message":"we probably need something like \"enable_conductor_fleet\" that is going to turn n-cond into n-super-cond, and n-cond-cell$i, because we\u0027re *also* going to need that on stop.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f05285b87df9f74cb3cfe380d2ead8dedc167cce","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"function start_nova_conductor {"},{"line_number":963,"context_line":"    if is_service_enabled n-cond; then"},{"line_number":964,"context_line":"        enable_service n-super-cond"},{"line_number":965,"context_line":"        run_process n-super-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $NOVA_CONF\""},{"line_number":966,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":967,"context_line":"            enable_service n-cond-cell${i}"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_fb76e83e","line":964,"in_reply_to":"bff0334d_a0894f27","updated":"2017-04-05 16:48:47.000000000","message":"I\u0027m not sure I follow. What do you mean \"turn n-cond into n-super-cond\" ? Do you just mean enable_service those names?","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e29c6f1cb0c27a0cbbeaf58645c29915085dbbbd","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"function start_nova_conductor {"},{"line_number":963,"context_line":"    if is_service_enabled n-cond; then"},{"line_number":964,"context_line":"        enable_service n-super-cond"},{"line_number":965,"context_line":"        run_process n-super-cond \"$NOVA_BIN_DIR/nova-conductor --config-file $NOVA_CONF\""},{"line_number":966,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":967,"context_line":"            enable_service n-cond-cell${i}"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_2ccf7880","line":964,"in_reply_to":"bff0334d_fb76e83e","updated":"2017-04-05 18:00:51.000000000","message":"right.\n\nfunction enable_conductor_fleet {\n   if is_service_enabled n-conf; then\n       enable_service n-super-cond\n       for i in $(seq 1 $NOVA_NUM_CELLS); do\n            enable_service n-cond-cell${i}\n       done\n   fi\n}\n\n\nThen it can be used in stop as well, because otherwise you can\u0027t stop things that aren\u0027t enabled.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3ec9da50051e003729678dd272875dc9ebf9c45c","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"    # Kill the nova screen windows"},{"line_number":1004,"context_line":"    # Some services are listed here twice since more than one instance"},{"line_number":1005,"context_line":"    # of a service may be running in certain configs."},{"line_number":1006,"context_line":"    for serv in n-api n-crt n-net n-sch n-novnc n-xvnc n-cauth n-spice n-cond n-cell n-cell n-api-meta n-sproxy; do"},{"line_number":1007,"context_line":"        stop_process $serv"},{"line_number":1008,"context_line":"    done"},{"line_number":1009,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"bff0334d_6098e769","line":1006,"updated":"2017-04-05 16:35:21.000000000","message":"stop won\u0027t work outside of screen here during an unstack.sh because nothing has enabled n-super-cond and friends.","commit_id":"56a8569cd091a5168fbbf3ce9a3753e75140ca0b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6eca13b4f1df91c0f13751e6dfaeb650e1164d5b","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"        stop_process n-api"},{"line_number":1005,"context_line":"    fi"},{"line_number":1006,"context_line":"    # Kill the nova screen windows"},{"line_number":1007,"context_line":"    # Some services are listed here twice since more than one instance"},{"line_number":1008,"context_line":"    # of a service may be running in certain configs."},{"line_number":1009,"context_line":"    for serv in n-api n-crt n-net n-sch n-novnc n-xvnc n-cauth n-spice n-cell n-cell n-api-meta n-sproxy; do"},{"line_number":1010,"context_line":"        stop_process $serv"}],"source_content_type":"application/x-shellscript","patch_set":31,"id":"bf091321_0556c32a","line":1007,"range":{"start_line":1007,"start_character":6,"end_line":1007,"end_character":70},"updated":"2017-06-08 12:28:11.000000000","message":"I see it now.","commit_id":"3a832398cabf4f0901443d8c4a3bc68c7c380349"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b11e341bfe9f7d3f86ab9a51d6f3f0f111d75b02","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"    # Kill the nova screen windows"},{"line_number":1007,"context_line":"    # Some services are listed here twice since more than one instance"},{"line_number":1008,"context_line":"    # of a service may be running in certain configs."},{"line_number":1009,"context_line":"    for serv in n-api n-crt n-net n-sch n-novnc n-xvnc n-cauth n-spice n-cell n-cell n-api-meta n-sproxy; do"},{"line_number":1010,"context_line":"        stop_process $serv"},{"line_number":1011,"context_line":"    done"},{"line_number":1012,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":31,"id":"bf091321_c5e1ebd2","line":1009,"range":{"start_line":1009,"start_character":71,"end_line":1009,"end_character":84},"updated":"2017-06-08 12:27:23.000000000","message":"Why is n-cell in here twice? I see it was before also...","commit_id":"3a832398cabf4f0901443d8c4a3bc68c7c380349"}]}