)]}'
{"lib/baremetal":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"478a8e15fee2519b96c9e2d072db35980fe26800","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        PXEBIN\u003d/usr/lib/syslinux/pxelinux.0"},{"line_number":222,"context_line":"        if [ ! -f $PXEBIN ]; then"},{"line_number":223,"context_line":"            echo \"pxelinux.0 (from SYSLINUX) not found.\""},{"line_number":224,"context_line":"            exit 1"},{"line_number":225,"context_line":"        fi"},{"line_number":226,"context_line":"    fi"},{"line_number":227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAASn%2F%2FiAU%3D","line":224,"updated":"2013-09-03 19:02:12.000000000","message":"I think an abrupt exit isn\u0027t a good call, as it leaves you in a half way setup devstack at a weird place","commit_id":"204096b3e0145e682b6f0bf54e64f085bfc1ce32"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"29946750230f0a82f68c0a9f41b9c37644ac8b0a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        PXEBIN\u003d/usr/lib/syslinux/pxelinux.0"},{"line_number":222,"context_line":"        if [ ! -f $PXEBIN ]; then"},{"line_number":223,"context_line":"            echo \"pxelinux.0 (from SYSLINUX) not found.\""},{"line_number":224,"context_line":"            exit 1"},{"line_number":225,"context_line":"        fi"},{"line_number":226,"context_line":"    fi"},{"line_number":227,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAASn%2F%2Fe14%3D","line":224,"in_reply_to":"AAAASn%2F%2FiAU%3D","updated":"2013-09-04 09:21:04.000000000","message":"thanks for the review...\n\no.k... So what\u0027s ur suggestion? I don\u0027t think that just printing a warning message and keep going with the installation would be a good idea, this file is needed in order to PXE boot the machines and even if you wanna just test nova baremetal with virtual machines you will need to PXE boot them, so I rather exit if that required file is not found than finish the setup not correctly configured.\n\n\nNow, looking at other parts of the file: Instead of \"exit 1\" I should use the \"die\" function. I will submit a new patch set for that.","commit_id":"204096b3e0145e682b6f0bf54e64f085bfc1ce32"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"64f15ffa05f8ff610e3289803d27c387541b0612","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    if [ ! -f $PXEBIN ]; then"},{"line_number":221,"context_line":"        PXEBIN\u003d/usr/lib/syslinux/pxelinux.0"},{"line_number":222,"context_line":"        if [ ! -f $PXEBIN ]; then"},{"line_number":223,"context_line":"            die \"pxelinux.0 (from SYSLINUX) not found.\""},{"line_number":224,"context_line":"        fi"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAASn%2F%2FTwo%3D","line":223,"updated":"2013-09-06 15:53:50.000000000","message":"die() needs $LINENO as its first arg:\n\n  die $LINENO \"message\"","commit_id":"a976ed677537d0febc48214c64679582bd6f5738"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a12e5cdd48b13059db8a43e673be0ed759f0fb9b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    if [ ! -f $PXEBIN ]; then"},{"line_number":221,"context_line":"        PXEBIN\u003d/usr/lib/syslinux/pxelinux.0"},{"line_number":222,"context_line":"        if [ ! -f $PXEBIN ]; then"},{"line_number":223,"context_line":"            die \"pxelinux.0 (from SYSLINUX) not found.\""},{"line_number":224,"context_line":"        fi"},{"line_number":225,"context_line":"    fi"},{"line_number":226,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAASn%2F%2FThI%3D","line":223,"in_reply_to":"AAAASn%2F%2FTwo%3D","updated":"2013-09-06 17:12:48.000000000","message":"Oh I see, all the other \"die\u0027s\" in this file are without the $LINENO, I\u0027m going to fix that in a another patch.\n\nThanks for the review!","commit_id":"a976ed677537d0febc48214c64679582bd6f5738"}]}