)]}'
{"lib/neutron":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8ac88039c24b653fafd282fb796b9d6d5e5e30ea","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    # Since neutron command is executed in admin context at this point,"},{"line_number":321,"context_line":"    # ``--tenant_id`` needs to be specified."},{"line_number":322,"context_line":"    if is_baremetal; then"},{"line_number":323,"context_line":"        if [[ $PUBLIC_INTERFACE \u003d\u003d \u0027\u0027 || $OVS_PHYSICAL_BRIDGE \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":324,"context_line":"            die $LINENO \"Neutron settings for baremetal not set.. exiting\""},{"line_number":325,"context_line":"        fi"},{"line_number":326,"context_line":"        sudo ovs-vsctl add-port $OVS_PHYSICAL_BRIDGE $PUBLIC_INTERFACE"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASn%2F%2FehU%3D","line":323,"updated":"2013-09-04 11:09:57.000000000","message":"see line 340, you need to quote the variables otherwise a blank variable gives you a syntax error.","commit_id":"e3127096e8f258991e1efb29c7cab46426f6d939"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ebce7420ce5562a9b3e370cf079bd10199cec08f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    # Since neutron command is executed in admin context at this point,"},{"line_number":321,"context_line":"    # ``--tenant_id`` needs to be specified."},{"line_number":322,"context_line":"    if is_baremetal; then"},{"line_number":323,"context_line":"        if [[ $PUBLIC_INTERFACE \u003d\u003d \u0027\u0027 || $OVS_PHYSICAL_BRIDGE \u003d\u003d \u0027\u0027 ]]; then"},{"line_number":324,"context_line":"            die $LINENO \"Neutron settings for baremetal not set.. exiting\""},{"line_number":325,"context_line":"        fi"},{"line_number":326,"context_line":"        sudo ovs-vsctl add-port $OVS_PHYSICAL_BRIDGE $PUBLIC_INTERFACE"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASn%2F%2FeZo%3D","line":323,"in_reply_to":"AAAASn%2F%2FehU%3D","updated":"2013-09-04 11:50:55.000000000","message":"Oh, my bad. I usually do it, this is a typo. Fixing it for patch #2","commit_id":"e3127096e8f258991e1efb29c7cab46426f6d939"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8ac88039c24b653fafd282fb796b9d6d5e5e30ea","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type flat --provider:physical_network \"$PHYSICAL_NETWORK\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":332,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --gateway $NETWORK_GATEWAY --name $PRIVATE_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":333,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":334,"context_line":"        sudo ip route add default via $NETWORK_GATEWAY dev $OVS_PHYSICAL_BRIDGE"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"        NET_ID\u003d$(neutron net-create --tenant_id $TENANT_ID \"$PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":337,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 --gateway $NETWORK_GATEWAY --name $PRIVATE_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASn%2F%2FehI%3D","line":334,"updated":"2013-09-04 11:09:57.000000000","message":"so.... shouldn\u0027t we not be mixing ifconfig and ip calls? I thought you really should be using one or the other.","commit_id":"e3127096e8f258991e1efb29c7cab46426f6d939"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ebce7420ce5562a9b3e370cf079bd10199cec08f","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        NET_ID\u003d$(neutron net-create $PHYSICAL_NETWORK --tenant_id $TENANT_ID --provider:network_type flat --provider:physical_network \"$PHYSICAL_NETWORK\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":332,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 ${ALLOCATION_POOL:+--allocation-pool $ALLOCATION_POOL} --gateway $NETWORK_GATEWAY --name $PRIVATE_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"},{"line_number":333,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":334,"context_line":"        sudo ip route add default via $NETWORK_GATEWAY dev $OVS_PHYSICAL_BRIDGE"},{"line_number":335,"context_line":"    else"},{"line_number":336,"context_line":"        NET_ID\u003d$(neutron net-create --tenant_id $TENANT_ID \"$PRIVATE_NETWORK_NAME\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":337,"context_line":"        SUBNET_ID\u003d$(neutron subnet-create --tenant_id $TENANT_ID --ip_version 4 --gateway $NETWORK_GATEWAY --name $PRIVATE_SUBNET_NAME $NET_ID $FIXED_RANGE | grep \u0027 id \u0027 | get_field 2)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAASn%2F%2FeZY%3D","line":334,"in_reply_to":"AAAASn%2F%2FehI%3D","updated":"2013-09-04 11:50:55.000000000","message":"OK, will stick to ifconfig then.","commit_id":"e3127096e8f258991e1efb29c7cab46426f6d939"}]}