)]}'
{"lib/swift":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6c061019411bc5256740b38387045f7ac2f9f76e","unresolved":false,"context_lines":[{"line_number":735,"context_line":"function install_swift {"},{"line_number":736,"context_line":"    git_clone $SWIFT_REPO $SWIFT_DIR $SWIFT_BRANCH"},{"line_number":737,"context_line":"    setup_develop $SWIFT_DIR"},{"line_number":738,"context_line":"    pip_install keystonemiddleware"},{"line_number":739,"context_line":"    if [ \"$SWIFT_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":740,"context_line":"        install_apache_wsgi"},{"line_number":741,"context_line":"    fi"}],"source_content_type":"text/x-swift","patch_set":1,"id":"9a30ddce_ed093396","line":738,"updated":"2017-03-13 12:45:20.000000000","message":"Shouldn\"t this be:\n  pip_install_gr keystonemiddleware\n\nAlso, I am not sure this is is the best way to fix this. Could you describe, in the commit message, what you mean by \"In some specific environments\" ? Maybe the correct fix is not to include keystonemiddleware in the Swift pipeline if Keystone is not enabled.","commit_id":"559f9594c4bac7be00371d425d62fe161accc552"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"6122cedc9ae848ddbe2a768737ce4aedd183f5b9","unresolved":false,"context_lines":[{"line_number":735,"context_line":"function install_swift {"},{"line_number":736,"context_line":"    git_clone $SWIFT_REPO $SWIFT_DIR $SWIFT_BRANCH"},{"line_number":737,"context_line":"    setup_develop $SWIFT_DIR"},{"line_number":738,"context_line":"    pip_install keystonemiddleware"},{"line_number":739,"context_line":"    if [ \"$SWIFT_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":740,"context_line":"        install_apache_wsgi"},{"line_number":741,"context_line":"    fi"}],"source_content_type":"text/x-swift","patch_set":1,"id":"7a25e98e_86d24a33","line":738,"in_reply_to":"9a30ddce_1356a605","updated":"2017-03-13 17:51:47.000000000","message":"However, I don\u0027t actually understand how this fixes things, because there is a non conditional call to this here:\n\nhttps://github.com/openstack-dev/devstack/blob/477c55866bc5ee7d46b947da794c77f141d60e79/stack.sh#L815\n\nhttps://github.com/openstack-dev/devstack/blob/477c55866bc5ee7d46b947da794c77f141d60e79/lib/keystone#L558\n\nSo we\u0027re already calling this code path, and it\u0027s not installing under python2 for some reason. We should figure out why.","commit_id":"559f9594c4bac7be00371d425d62fe161accc552"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"70ca57341ce04fea7628022fbe56335c803a1823","unresolved":false,"context_lines":[{"line_number":735,"context_line":"function install_swift {"},{"line_number":736,"context_line":"    git_clone $SWIFT_REPO $SWIFT_DIR $SWIFT_BRANCH"},{"line_number":737,"context_line":"    setup_develop $SWIFT_DIR"},{"line_number":738,"context_line":"    pip_install keystonemiddleware"},{"line_number":739,"context_line":"    if [ \"$SWIFT_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":740,"context_line":"        install_apache_wsgi"},{"line_number":741,"context_line":"    fi"}],"source_content_type":"text/x-swift","patch_set":1,"id":"9a30ddce_1356a605","line":738,"in_reply_to":"9a30ddce_ed093396","updated":"2017-03-13 13:18:32.000000000","message":"I don\u0027t know what difference pip_install_gr makes.\n\nI showed the issue I hit in the first review comment. I\u0027m installing swift on python2 while everything else is python3, and hitting this issue. Keystone is enabled.","commit_id":"559f9594c4bac7be00371d425d62fe161accc552"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"4da64533d96177b1f561d2bd2ea4789ba593159e","unresolved":false,"context_lines":[{"line_number":738,"context_line":"    keystonemiddleware_package\u003d$(get_from_global_requirements keystonemiddleware)"},{"line_number":739,"context_line":"    # Enforce keystonemiddleware as a dependency. Swift doesn\u0027t have it, but we"},{"line_number":740,"context_line":"    # need it in devstack"},{"line_number":741,"context_line":"    echo $keystonemiddleware_package \u003e\u003e $SWIFT_DIR/requirements.txt"},{"line_number":742,"context_line":"    setup_develop $SWIFT_DIR"},{"line_number":743,"context_line":"    if [ \"$SWIFT_USE_MOD_WSGI\" \u003d\u003d \"True\" ]; then"},{"line_number":744,"context_line":"        install_apache_wsgi"}],"source_content_type":"text/x-swift","patch_set":2,"id":"1a1ced50_5309cb2b","line":741,"updated":"2017-03-17 15:19:26.000000000","message":"yeh, that will get us through this, but honestly, this is something I\u0027d like to avoid encoding.","commit_id":"b008645ad037fcc9b428362ac4e1bbbb42b20101"}]}